linux-stable.git/drivers/staging/dgnc, branch v4.13

dgnc: fix multiple blank lines coding style problem

2017-05-25T16:56:45+00:00

According to the coding-style documentation, functions in source files
should be separated with one blank line. Redundant blank lines were
removed from this source file, in accordance with coding-style
documentation.

Signed-off-by: Aliza Minkov 
Signed-off-by: Greg Kroah-Hartman

drivers/staging: refactor dgnc tty registration.

2017-05-16T11:55:23+00:00

-remove duplicate tty allocation code for serial and printer drivers.
-add missing tty c_ispeed and c_ospeed initialization to 9600.
-fix sparse warning: too long initializer-string for array of char.

This patch was only unit tested due to lack of the actual hardware.

Signed-off-by: Haim Daniel 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: remove error message task

2017-03-29T07:37:10+00:00

TODO file lists task to remove unnecessary error messages. There are
no unnecessary error messages in the driver, this must have been done
already.

Remove task from TODO file.

Signed-off-by: Tobin C. Harding 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: remove dead code

2017-03-29T07:37:10+00:00

Driver contains dead code, guarded with #ifdef's. We can safely remove
this, it will be in the git history if it is later needed.

Remove dead code.

Signed-off-by: Tobin C. Harding 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: remove struct member magic numbers

2017-03-29T07:37:10+00:00

Driver uses magic number members within structs, this is an antiquated
method of catching data errors. We don't do things that way any more.

Remove magic number struct members. Remove all checks to magic
numbers.

Signed-off-by: Tobin C. Harding 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: remove unnecessary comments

2017-03-29T07:37:10+00:00

TODO file lists task to remove unnecessary comments.

Make initial attempt at removing unnecessary comments. Choose not to
be to vicious in removal. We can remove more once the driver is
cleaned up/tested some more.

For functions with internal linkage, reduce the function comment where
possible. For functions with external linkage, migrate the function
comment to kernel doc format.

Signed-off-by: Tobin C. Harding 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: remove double underscore

2017-03-29T07:37:10+00:00

Pre-processor header guards use double underscore, typically kernel
code uses single underscore when defining header guards. 'endif'
statement should include what is ending as a comment string.

Remove double underscore, add comment string to 'endif'

Signed-off-by: Tobin C. Harding 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: clean up header comments

2017-03-29T07:37:10+00:00

TODO file has task: remove unnecessary comments. Driver uses some
custom comment format. Driver would be better if it used kernel doc
format.

Audit header file comments. Replace struct comments with kernel doc
format comments. Remove unnecessary comments.

Signed-off-by: Tobin C. Harding 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: remove tracing prints in dgnc_tty.c

2017-03-23T13:21:25+00:00

Remove tracing prints in dgnc_tty_send_xchar. The same functionality
could be achieved by using ftrace.

Signed-off-by: Abhishek Bhardwaj 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: preserve return code

2017-03-16T02:45:42+00:00

Return code from tty_check_change() should be being
preserved.

Preserve return code from call to tty_check_change().

Signed-off-by: Tobin C. Harding 
Signed-off-by: Greg Kroah-Hartman