linux-stable.git/drivers/staging/dgnc, branch v4.1

staging: dgnc_sysfs: Replace printk(KERN_ERR ) with pr_err()

2015-04-01T15:37:57+00:00

Fix the following checkpatch warning:
WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ...
then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...

Signed-off-by: Ioana Ciornei 
Signed-off-by: Greg Kroah-Hartman

dgnc: Clean up dgnc_sysfs.h

2015-03-24T14:41:00+00:00

Remove redundant blank lines, move absolute include after relative
include.

Signed-off-by: Giedrius Statkevičius 
Signed-off-by: Greg Kroah-Hartman

dgnc: remove unused stuff from dgnc_cls.h

2015-03-24T14:41:00+00:00

Remove unused defines from dgnc_cls.h

Signed-off-by: Giedrius Statkevičius 
Signed-off-by: Greg Kroah-Hartman

dgnc: remove old 2.4-2.6 compat kernel defines

2015-03-24T14:40:59+00:00

dgnc_kcompat.h contains some old legacy defines in case the kernel
doesn't have __user defined but for current kernel versions these
defines don't make sense and are useless so remove them. Move the
TTY_FLIPBUF_SIZE define to digi.h because it's used in the code.

Signed-off-by: Giedrius Statkevičius 
Signed-off-by: Greg Kroah-Hartman

dgnc: use linux/types.h instead of dgnc_types.h

2015-03-24T14:40:59+00:00

Dgnc_types.h unnecesarily defines TRUE as 1 and FALSE as 0 because we
already have a widely used linux/types.h so convert all TRUE to true,
FALSE to false and edit the dgnc_board struct to make sure it uses
"bool".

Signed-off-by: Giedrius Statkevičius 
Signed-off-by: Greg Kroah-Hartman

dgnc: get rid of dpacompat.h, move remaining stuff to digi.h

2015-03-24T14:40:59+00:00

Dpacompat.h contained a lot of unused #defines and only few things are
used from it so since we've trimmed down digi.h, now we can delete
dpacompat.h and move remaining stuff into digi.h.

Signed-off-by: Giedrius Statkevičius 
Signed-off-by: Greg Kroah-Hartman

dgnc: clean up digi.h

2015-03-24T14:40:59+00:00

Remove a lot of unused structs and defines from digi.h. We still have to
be careful with TIOCM_LE and TIOCMSET/TIOCMBIC because termios.h and
ioctls.h respectfully redefine them.

Signed-off-by: Giedrius Statkevičius 
Signed-off-by: Greg Kroah-Hartman

dgnc: remove unused dgnc_ioctl_name() command

2015-03-24T14:40:59+00:00

dgnc_ioctl_name() is never used anywhere so remove it

Signed-off-by: Giedrius Statkevičius 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: some off by one bugs

2015-03-24T14:31:24+00:00

"dgnc_NumBoards" is the number of filled out elements in the
dgnc_Board[] array.  "->nasync" and "->maxports" are the same value.
They are the number of channels in the ->channels[] array so these tests
should be ">=" instead of ">" so we avoid reading past the end of the
arrays.

I cleaned up the conditions in dgnc_mgmt_ioctl() a bit.  There was a
work around for the off by one bug in the case where there were no
boards which is no longer needed.  "channel" is unsigned so it can't be
negative.

Signed-off-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

Staging: dgnc: release the lock before testing for nullity

2015-03-18T16:34:11+00:00

The refactoring intrduced in
c84a083b995b ("Staging: dgnc: Use goto for spinlock release before return")
inverts the order in which the lock is released and ld is tested for nullity.

This patch restores the execution flow.

Fixes: c84a083b995b ("Staging: dgnc: Use goto for spinlock release before return")
Signed-off-by: Quentin Lambert 
Signed-off-by: Greg Kroah-Hartman