linux-stable.git/drivers/staging/dgnc, branch v4.0 Linux kernel stable tree drivers/staging: use current->state helpers 2015-01-28T19:25:28+00:00 Davidlohr Bueso dave@stgolabs.net 2015-01-26T10:15:02+00:00 2be90fef97ada3df61736435dc9ef6c3e432a747 Call __set_current_state() instead of assigning the new state directly. These interfaces also aid CONFIG_DEBUG_ATOMIC_SLEEP environments, keeping track of who changed the state. Signed-off-by: Davidlohr Bueso <dbueso@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Call __set_current_state() instead of assigning the new state directly.
These interfaces also aid CONFIG_DEBUG_ATOMIC_SLEEP environments,
keeping track of who changed the state.

Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Staging: dgnc: fixed some coding style errors 2015-01-25T12:04:15+00:00 Andrew Milkovich amilkovich@gmail.com 2015-01-18T18:41:30+00:00 6f6304b85f734dab956cbacc017fcdbe48693d51 This patch fixes the following checkpatch.pl error: ERROR: Macros with complex values should be enclosed in parentheses Outer parentheses were added to macro definitions. Signed-off-by: Andrew Milkovich <amilkovich@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This patch fixes the following checkpatch.pl error:
ERROR: Macros with complex values should be enclosed in parentheses
Outer parentheses were added to macro definitions.

Signed-off-by: Andrew Milkovich <amilkovich@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: dgnc: fix long lines in PCI device table 2015-01-25T12:03:23+00:00 Krzysztof Adamski k@japko.eu 2015-01-22T19:19:26+00:00 60e27886fd615adc81e810bec23f4b929ab81d0e This patch fixes coding style of PCI device table declaration. Signed-off-by: Krzysztof Adamski <k@japko.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This patch fixes coding style of PCI device table declaration.

Signed-off-by: Krzysztof Adamski <k@japko.eu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: dgnc: implement proper error handling in dgnc_start() 2015-01-17T23:04:12+00:00 Alexey Khoroshilov khoroshilov@ispras.ru 2014-12-19T21:51:26+00:00 d7312aab230f975b8ec41c0055a17f0d395b7fb5 dgnc_start() ignores errors in class_create() and device_create() and it does not deallocate resources if dgnc_tty_preinit() fails. The patch implements proper error handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
dgnc_start() ignores errors in class_create() and device_create()
and it does not deallocate resources if dgnc_tty_preinit() fails.

The patch implements proper error handling.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: dgnc: Remove useless cast on void pointer 2014-10-30T20:05:46+00:00 Tapasweni Pathak tapaswenipathak@gmail.com 2014-10-30T11:32:04+00:00 fc33bd2921c27241f0b695bb265fa020c51d352b void pointers do not need to be cast to other pointer types. The semantic patch used to find this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T *)x)->f | - (T *) e ) Build tested it. Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
void pointers do not need to be cast to other pointer types.

The semantic patch used to find this:

@r@
expression x;
void* e;
type T;
identifier f;
@@

(
  *((T *)e)
|
  ((T *)x)[...]
|
  ((T *)x)->f
|
- (T *)
  e
)

Build tested it.

Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: dgnc: dgnc_kcompat.h: remove unused macro 2014-10-28T08:12:39+00:00 Aya Mahfouz mahfouz.saif.elyazal@gmail.com 2014-10-25T21:47:57+00:00 ac611dc60fc0cc050344861668f916c191f4b6cd This patch removes the macro PARM_INT after removing all the variables that depended on it. Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This patch removes the macro PARM_INT after removing all the variables
that depended on it.

Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: dgnc: remove debug symbols 2014-10-28T08:12:39+00:00 Aya Mahfouz mahfouz.saif.elyazal@gmail.com 2014-10-25T21:46:03+00:00 2a71a3c7c7c1add1ecbfba4ef77c28ef234e82b4 This patch removes all of the debug symbols and the variable dgnc_debug since they are not used anywhere in the code. Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This patch removes all of the debug symbols and the variable dgnc_debug
since they are not used anywhere in the code.

Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: dgnc: remove unused variable named rawreadok 2014-10-28T08:12:39+00:00 Aya Mahfouz mahfouz.saif.elyazal@gmail.com 2014-10-25T21:43:33+00:00 ade5b9435bd6038f552dd25f7529103a7c7af5ff This patch removes the variable rawreadok since it is only intialized but not used in any of the driver functions. Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This patch removes the variable rawreadok since it is only intialized
but not used in any of the driver functions.

Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: dgnc: dgnc_driver: remove all occurences of trcbuf_size 2014-10-28T08:12:39+00:00 Aya Mahfouz mahfouz.saif.elyazal@gmail.com 2014-10-25T21:40:15+00:00 6db43a9c388061060dfab0146d4f4e1cc990ecf8 This patch removes the variable trcbuf_size given there is no real use for it anymore. All of the debug variables in this driver is basically dead code. Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This patch removes the variable trcbuf_size given there is no real
use for it anymore. All of the debug variables in this driver is
basically dead code.

Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: dgnc: dgnc_kcompat.h: remove unused macros 2014-10-28T08:12:39+00:00 Aya Mahfouz mahfouz.saif.elyazal@gmail.com 2014-10-25T21:33:06+00:00 8a43572c32ffbfe122c38873e29e98ef7ace1709 This patch removes the macros PARM_STR and PARM_ULONG given that they are not used anywhere in the driver files. Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This patch removes the macros PARM_STR and PARM_ULONG given that they
are not used anywhere in the driver files.

Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>