linux-stable.git/drivers/staging/dgnc, branch linux-4.9.y

staging: dgnc: Fix lines longer than 80 characters

2016-10-02T15:24:00+00:00

All the chunks of the patch apply to comments save the first one.

Signed-off-by: Fernando Apesteguia 
Signed-off-by: Greg Kroah-Hartman

Staging: dgnc: constify attribute_group structures

2016-10-02T15:24:00+00:00

Check for attribute_group structures that are only passed as a second
argument to the functions sysfs_remove_group and sysfs_create_group. As
these arguments are constant so, attribute_group structures having this
property  can also be made constant.
Done using coccinelle:

@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct attribute_group i@p = {...};

@ok1@
identifier r1.i;
position p;
expression e1;
@@
(
sysfs_remove_group(e1,&i@p)
|
sysfs_create_group(e1,&i@p)
)

@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
static
+const
struct attribute_group i={...};

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct attribute_group i;

File size before:
   text	   data	    bss	    dec	    hex	filename
   6248	   1024	      0	   7272	   1c68
drivers/staging/dgnc/dgnc_sysfs.o

File size after:
   text	   data	    bss	    dec	    hex	filename
   6288	    960	      0	   7248	   1c50
drivers/staging/dgnc/dgnc_sysfs.o

Signed-off-by: Bhumika Goyal 
Acked-by: Julia Lawall 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: introduce find_board_by_major()

2016-09-27T11:12:26+00:00

It was used to get a board structure with dgnc_BoardsByMajor array.
But this driver already has the array for managing initialized board
as dgap_board[]. It can be used for searching the board structure
by major number.

Signed-off-by: Daeseok Youn 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: remove useless variables

2016-09-27T11:12:26+00:00

The dgnc_major_serial_registered and dgnc_major_serial_registered
do not need to use to check whether the tty driver is registered or not.
These variables are used only in dgnc_cleanup_tty() function,
This function will be called normally with initialized board structure.
It means the dgnc_cleanup_tty() cannot be called with unregistered tty.

Signed-off-by: Daeseok Youn 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: rename dgnc_tty_uninit() to dgnc_cleanup_tty()

2016-09-27T11:12:26+00:00

The dgnc_tty_uninit() doesn't match with dgnc_tty_init() at all.
And also the dgnc_cleanup_tty() is only called for exiting the module.

Signed-off-by: Daeseok Youn 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: introduce the dgnc_free_irq()

2016-09-27T11:12:26+00:00

The dgnc_free_irq() will free the requested IRQ from
the dgnc_request_irq().

Signed-off-by: Daeseok Youn 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: rename dgnc_finalize_board_init() to dgnc_request_irq()

2016-09-27T11:12:26+00:00

The dgnc_finalize_board_init() function has only job for
requesting the IRQ. It should be renamed to dgnc_request_irq()

Signed-off-by: Daeseok Youn 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: introduce the dgnc_tty_unregister()

2016-09-27T11:12:26+00:00

The dgnc_tty_unregister() will be called when
the dgnc_tty_register() is failed.

Signed-off-by: Daeseok Youn 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: move functions unrelated with dgnc_found_board()

2016-09-27T11:12:26+00:00

The functions related with tty device initialization are needed
to be moved from dgnc_found_board() to dgnc_init_one().

Signed-off-by: Daeseok Youn 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: kfree for board structure in dgnc_found_board()

2016-09-27T11:12:25+00:00

The board structure should be freed when any function was failed
in dgnc_found_board(). And the board strucure will be stored
into dgnc_board array when the dgnc_found_board() function has no error.

Signed-off-by: Daeseok Youn 
Signed-off-by: Greg Kroah-Hartman