linux-stable.git/drivers/staging/dgnc, branch linux-4.12.y Linux kernel stable tree staging: dgnc: remove error message task 2017-03-29T07:37:10+00:00 Tobin C. Harding me@tobin.cc 2017-03-27T23:28:40+00:00 a4b513f0afd19b36f3135161d23ee3c4cfd55475 TODO file lists task to remove unnecessary error messages. There are no unnecessary error messages in the driver, this must have been done already. Remove task from TODO file. Signed-off-by: Tobin C. Harding <me@tobin.cc> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
TODO file lists task to remove unnecessary error messages. There are
no unnecessary error messages in the driver, this must have been done
already.

Remove task from TODO file.

Signed-off-by: Tobin C. Harding <me@tobin.cc>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: dgnc: remove dead code 2017-03-29T07:37:10+00:00 Tobin C. Harding me@tobin.cc 2017-03-27T23:28:39+00:00 a21f95e5cffd016d81d30cbfbef0b929355b2eef Driver contains dead code, guarded with #ifdef's. We can safely remove this, it will be in the git history if it is later needed. Remove dead code. Signed-off-by: Tobin C. Harding <me@tobin.cc> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Driver contains dead code, guarded with #ifdef's. We can safely remove
this, it will be in the git history if it is later needed.

Remove dead code.

Signed-off-by: Tobin C. Harding <me@tobin.cc>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: dgnc: remove struct member magic numbers 2017-03-29T07:37:10+00:00 Tobin C. Harding me@tobin.cc 2017-03-27T23:28:38+00:00 0053fe0eba9f5d6a992e0e4b45595a55809fc27b Driver uses magic number members within structs, this is an antiquated method of catching data errors. We don't do things that way any more. Remove magic number struct members. Remove all checks to magic numbers. Signed-off-by: Tobin C. Harding <me@tobin.cc> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Driver uses magic number members within structs, this is an antiquated
method of catching data errors. We don't do things that way any more.

Remove magic number struct members. Remove all checks to magic
numbers.

Signed-off-by: Tobin C. Harding <me@tobin.cc>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: dgnc: remove unnecessary comments 2017-03-29T07:37:10+00:00 Tobin C. Harding me@tobin.cc 2017-03-27T23:28:37+00:00 510616521f1c1ce68da84bbcceab61b35abdce6f TODO file lists task to remove unnecessary comments. Make initial attempt at removing unnecessary comments. Choose not to be to vicious in removal. We can remove more once the driver is cleaned up/tested some more. For functions with internal linkage, reduce the function comment where possible. For functions with external linkage, migrate the function comment to kernel doc format. Signed-off-by: Tobin C. Harding <me@tobin.cc> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
TODO file lists task to remove unnecessary comments.

Make initial attempt at removing unnecessary comments. Choose not to
be to vicious in removal. We can remove more once the driver is
cleaned up/tested some more.

For functions with internal linkage, reduce the function comment where
possible. For functions with external linkage, migrate the function
comment to kernel doc format.

Signed-off-by: Tobin C. Harding <me@tobin.cc>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: dgnc: remove double underscore 2017-03-29T07:37:10+00:00 Tobin C. Harding me@tobin.cc 2017-03-27T23:28:36+00:00 2539fc0c7c7b0dcb076a4bceafff4fb64091b2c2 Pre-processor header guards use double underscore, typically kernel code uses single underscore when defining header guards. 'endif' statement should include what is ending as a comment string. Remove double underscore, add comment string to 'endif' Signed-off-by: Tobin C. Harding <me@tobin.cc> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Pre-processor header guards use double underscore, typically kernel
code uses single underscore when defining header guards. 'endif'
statement should include what is ending as a comment string.

Remove double underscore, add comment string to 'endif'

Signed-off-by: Tobin C. Harding <me@tobin.cc>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: dgnc: clean up header comments 2017-03-29T07:37:10+00:00 Tobin C. Harding me@tobin.cc 2017-03-27T23:28:35+00:00 e14047e4e3b54a988411a0fea207c9bb69c13711 TODO file has task: remove unnecessary comments. Driver uses some custom comment format. Driver would be better if it used kernel doc format. Audit header file comments. Replace struct comments with kernel doc format comments. Remove unnecessary comments. Signed-off-by: Tobin C. Harding <me@tobin.cc> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
TODO file has task: remove unnecessary comments. Driver uses some
custom comment format. Driver would be better if it used kernel doc
format.

Audit header file comments. Replace struct comments with kernel doc
format comments. Remove unnecessary comments.

Signed-off-by: Tobin C. Harding <me@tobin.cc>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: dgnc: remove tracing prints in dgnc_tty.c 2017-03-23T13:21:25+00:00 Abhishek Bhardwaj abshkbh@gmail.com 2017-03-22T08:43:39+00:00 fdbcd023576a4397dcef3acffa1b8c00993cbf90 Remove tracing prints in dgnc_tty_send_xchar. The same functionality could be achieved by using ftrace. Signed-off-by: Abhishek Bhardwaj <abshkbh@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Remove tracing prints in dgnc_tty_send_xchar. The same functionality
could be achieved by using ftrace.

Signed-off-by: Abhishek Bhardwaj <abshkbh@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: dgnc: preserve return code 2017-03-16T02:45:42+00:00 Tobin C. Harding me@tobin.cc 2017-03-14T23:44:29+00:00 f15e60ce4ee90b713e1d84653c715dc8fa0d49ec Return code from tty_check_change() should be being preserved. Preserve return code from call to tty_check_change(). Signed-off-by: Tobin C. Harding <me@tobin.cc> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Return code from tty_check_change() should be being
preserved.

Preserve return code from call to tty_check_change().

Signed-off-by: Tobin C. Harding <me@tobin.cc>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: dgnc: remove useless switch-case statements 2017-03-14T03:20:33+00:00 Daeseok Youn daeseok.youn@gmail.com 2017-03-14T02:07:45+00:00 940f6daec092819674ce26f1b6f0be4bbb9923a8 The dgnc_tty_send_break() has a switch-case condition for msec. It is no use except case -1. Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
The dgnc_tty_send_break() has a switch-case condition for msec.
It is no use except case -1.

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: dgnc: ch->ch_bd is already assigned to bd variable 2017-03-14T03:20:33+00:00 Daeseok Youn daeseok.youn@gmail.com 2017-03-14T02:05:32+00:00 dec5b6c569d2992e550951662ba27576f24924f7 The bd variables in functions are already assigned from ch->ch_bd but it is not used in those functions except checking NULL. The ch->ch_bd could be replaced with bd variable. Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
The bd variables in functions are already assigned from
ch->ch_bd but it is not used in those functions except checking NULL.

The ch->ch_bd could be replaced with bd variable.

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>