linux-stable.git/drivers/staging/dgnc, branch linux-3.19.y

staging: dgnc: Remove useless cast on void pointer

2014-10-30T20:05:46+00:00

void pointers do not need to be cast to other pointer types.

The semantic patch used to find this:

@r@
expression x;
void* e;
type T;
identifier f;
@@

(
  *((T *)e)
|
  ((T *)x)[...]
|
  ((T *)x)->f
|
- (T *)
  e
)

Build tested it.

Signed-off-by: Tapasweni Pathak 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: dgnc_kcompat.h: remove unused macro

2014-10-28T08:12:39+00:00

This patch removes the macro PARM_INT after removing all the variables
that depended on it.

Signed-off-by: Aya Mahfouz 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: remove debug symbols

2014-10-28T08:12:39+00:00

This patch removes all of the debug symbols and the variable dgnc_debug
since they are not used anywhere in the code.

Signed-off-by: Aya Mahfouz 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: remove unused variable named rawreadok

2014-10-28T08:12:39+00:00

This patch removes the variable rawreadok since it is only intialized
but not used in any of the driver functions.

Signed-off-by: Aya Mahfouz 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: dgnc_driver: remove all occurences of trcbuf_size

2014-10-28T08:12:39+00:00

This patch removes the variable trcbuf_size given there is no real
use for it anymore. All of the debug variables in this driver is
basically dead code.

Signed-off-by: Aya Mahfouz 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: dgnc_kcompat.h: remove unused macros

2014-10-28T08:12:39+00:00

This patch removes the macros PARM_STR and PARM_ULONG given that they
are not used anywhere in the driver files.

Signed-off-by: Aya Mahfouz 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: delete successive assignments to the same location

2014-10-28T07:41:43+00:00

Successive assignments to the same location is meaningless and can be
deleted. The Coccinelle semantic patch was used to find cases.

@@
expression e1,e2,e3;
@@

(
 (<+...e1++...+>)=e2;
|
 (<+...e1--...+>)=e2;
|
 (<+...++e1...+>)=e2;
|
 (<+...--e1...+>)=e2;
|
e1=e2;
e1 = <+...e1...+>;
|
*e1=e2;
*e1=e3;
)

Signed-off-by: Jiayi Ye 
Reviewed-by: Josh Triplett 
Signed-off-by: Greg Kroah-Hartman

Staging: dgnc: Remove unused sniff code

2014-10-23T00:34:25+00:00

The output written by dgnc_sniff_nowait_nolock() is never used
anywhere since commit 35cf90459312f ("staging: dgnc: removes proc code")
deleted the code that used to copy it to user space.
dgnc_sniff_nowait_nolock() uses 'timeval' to create header timestamps for
the data dump.

32-bit systems using 'struct timeval' will break in the year 2038,
This patch removes dgnc_sniff_nowait_nolock() and all ch_sniff_* members
of struct channel_t defined in "dgnc_driver.h". It also removes their usage
from the driver files and hence y2038 issue is also resolved.

Signed-off-by: Somya Anand 
Reviewed-by: Arnd Bergmann 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: Remove space before tabs

2014-10-20T02:29:18+00:00

This patch fixes the warning of "Please, no space before tab" produced
by checkpatch.pl. The modified file: dgnc_tty.c

Signed-off-by: Dilek Uzulmez 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: Remove non-standard APR/RAPR printing macros

2014-10-20T02:29:18+00:00

This patch removes non-standard macros used by dgnc driver for printing error
or debugging messages. These are replaced by dev_err/dev_dbg (when possible)
or pr_err. There were cases where the message is completely removed since is
not adding any useful information.

Signed-off-by: Roberta Dobrescu 
Reviewed-by: Josh Triplett 
Signed-off-by: Greg Kroah-Hartman