linux-stable.git/drivers/staging/dgnc, branch linux-3.16.y

staging: dgnc: Fix frame size is larger than 1024B

2017-11-11T13:33:57+00:00

commit ea6e9dea2e72a7abd146a2c5bab726b27f34b36c upstream.

This comit fixes the following sparse warnign:

drivers/staging/dgnc/dgnc_tty.c:572:1:
    warning: the frame size of 1060 bytes is larger than 1024 bytes
    [-Wframe-larger-than=]

This was caused by having buffer as an automatic variable. This commit
moves it from the stack to the heap.

Signed-off-by: Konrad Zapalowicz 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Arnd Bergmann 
Signed-off-by: Ben Hutchings

staging/dgnc: fix info leak in ioctl

2015-11-16T11:27:22+00:00

commit 4b6184336ebb5c8dc1eae7f7ab46ee608a748b05 upstream.

The dgnc_mgmt_ioctl() code fails to initialize the 16 _reserved bytes of
struct digi_dinfo after the ->dinfo_nboards member. Add an explicit
memset(0) before filling the structure to avoid the info leak.

Signed-off-by: Salva Peiró 
Signed-off-by: Greg Kroah-Hartman 
Cc: Moritz Mühlenhoff 
Signed-off-by: Luis Henriques

staging: dgnc: Use time_after_eq()

2014-05-25T18:53:44+00:00

To be future-proof and for better readability the time comparisons are
modified to use time_after_eq() instead of plain, error-prone math.

Signed-off-by: Manuel Schölling 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: dgnc_tty: Remove a prohibited space

2014-05-23T17:12:40+00:00

Remove a prohibited space before a closed parenthesis of if statement
to meet kernel coding style.

Signed-off-by: Masaru Nomura 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: dgnc_tty: Add a required space

2014-05-23T17:12:40+00:00

Add a required space before an open parenthesis of if statement
to meet kernel coding style.

Signed-off-by: Masaru Nomura 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: Remove extra curly braces

2014-05-18T17:11:24+00:00

Remove unnecessary curly braces of if statements in dgnc_neo.c and
dgnc_tty.c to meet kernel coding style.

Signed-off-by: Masaru Nomura 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: dgnc_neo: Clean up if statement

2014-05-18T17:11:24+00:00

Fix line over 80 characters and indenting of condition part.
Also, remove unnecessary braces to meet coding style.

Signed-off-by: Masaru Nomura 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: Put else statements on the right line

2014-05-18T17:11:24+00:00

Fix indenting of if-else statement in dgnc_neo.c and dgnc_tty.c
so that following else-if or else statement meets coding style.

Signed-off-by: Masaru Nomura 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: UART_IIR_XOFF code is buggy

2014-05-15T20:46:00+00:00

The UART_IIR_XOFF was supposed to be a no-op but, because there was a
missing semi-colon, the if statement is not "Empty".  I have just deleted
this code because it was supposed to be a no-op anyway.  UART_IIR_XOFF
is a standard define and not something specific to this driver.

Signed-off-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: use dev_err() instead of printk()

2014-05-15T20:46:00+00:00

Use dev_err() insted of printk() in order to provice userspace with
more useful information and use the common kernel coding style.

Signed-off-by: Martin Kepplinger 
Signed-off-by: Greg Kroah-Hartman