linux-stable.git/drivers/staging/dgnc, branch linux-3.12.y

staging/dgnc: fix info leak in ioctl

2016-01-15T08:31:27+00:00

commit 4b6184336ebb5c8dc1eae7f7ab46ee608a748b05 upstream.

The dgnc_mgmt_ioctl() code fails to initialize the 16 _reserved bytes of
struct digi_dinfo after the ->dinfo_nboards member. Add an explicit
memset(0) before filling the structure to avoid the info leak.

Signed-off-by: Salva Peiró 
Signed-off-by: Greg Kroah-Hartman 
Cc: Yuki Machida 
Signed-off-by: Jiri Slaby

dgnc: Move DG_PART definition from Makefile to dgnc_driver.h

2015-06-09T10:22:50+00:00

commit f11cc568758f23088c1f7a8369100c59e4c07bd6 upstream.

Avoid deprecated usage of EXTRA_CFLAGS by moving definition of DG_PART into dgnc_driver.h

Signed-off-by: Cass May 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Jiri Slaby

staging: dgnc: fix potential format string flaw

2013-09-17T14:39:27+00:00

Make sure that format strings cannot leak into printk() calls from the
msgbuf string.

Signed-off-by: Kees Cook 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: adds TODO

2013-08-30T18:28:58+00:00

This patchs adds a TODO for the driver.

Signed-off-by: Lidza Louina 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: driver.c and .h: removes dgnc_driver_kzmalloc func

2013-08-28T04:56:32+00:00

This patch removes the dgnc_driver_kzmalloc function from
driver.c and driver.h. A previous patch replaced all
dgnc_driver_kzmalloc function calls with kzalloc.

Signed-off-by: Lidza Louina 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: driver.c and tty.c: replaces dgnc_driver_kzmalloc with kzalloc

2013-08-28T04:55:26+00:00

This patch replaces dgnc_driver_kzmalloc with kzalloc.
A patch that follows removes the dgnc_driver_kzmalloc
function.

Signed-off-by: Lidza Louina 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: tty.c: updates uart_struct declaration for sparse

2013-08-28T04:55:26+00:00

This patch edits the type casts neo_uart_struct and
cls_uart_struct. A previous patch added the marker __iomem
to these structs. This patch ensures that the change to
the marker is consistent. This also removes these
sparse warnings:

warning: incorrect type in assignment (different address spaces)
  expected struct neo_uart_struct [noderef] *ch_neo_uart
  got struct neo_uart_struct *
warning: incorrect type in assignment (different address spaces)
  expected struct cls_uart_struct [noderef] *ch_cls_uart
  got struct cls_uart_struct *

Signed-off-by: Lidza Louina 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: tty.c: edits var in init func for sparse

2013-08-26T23:26:56+00:00

This patch edits the vaddr variable in dgnc_tty_init.
The variable gets set to board_t->re_map_membase. A
previous patch changed the re_map_membase variable's
marker and type. This patch makes sure that the
changes are consistent and that it doesn't cause
sparse warnings.

Signed-off-by: Lidza Louina 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: neo.c: changes param in neo_read_eeprom function for sparse

2013-08-26T23:26:56+00:00

This patch adds a marker to neo_read_eeprom function's
base parameter.

It removes these warnings found in neo.c:

warning: incorrect type in argument 1 (different address spaces)
  expected unsigned char *base
  got unsigned char [noderef] [usertype] *re_map_membase
warning: incorrect type in argument 2 (different address spaces)
  expected void volatile [noderef] *addr
  got unsigned char *

These warnings happen because this function gets
called with a board_t->re_map_base variable. A previous
patch added the __iomem marker to this variable. This
patch ensures that the changes are consistent.

Signed-off-by: Lidza Louina 
Signed-off-by: Greg Kroah-Hartman

staging: dgnc: cls.c: changes var in cls_vpd function for sparse

2013-08-26T23:26:55+00:00

This patch changes cls_vpd function's re_map_vpdbase variable
type and marker.

It removes these warnings found in cls.c:

warning: incorrect type in assignment (different address spaces)
  expected unsigned char [usertype] *re_map_vpdbase
  got void [noderef] *
warning: incorrect type in argument 1 (different address spaces)
  expected void const volatile [noderef] *addr
  got unsigned char [usertype] *
warning: incorrect type in argument 1 (different address spaces)
  expected void volatile [noderef] *addr
  got unsigned char [usertype] *re_map_vpdbase

The variables passed to readb needs to be of type u8
with a __iomem marker. re_map_vpdbase is passed into
readb in the code.

Signed-off-by: Lidza Louina 
Signed-off-by: Greg Kroah-Hartman