linux-stable.git/drivers/staging/dgap, branch v4.0.2

staging: dgap: fix "if" statement that always evaluates to true

2015-01-25T12:08:13+00:00

cppcheck warning:
(warnning) Logical disjunction always evaluates to true

Reported-by: David Binderman 
Signed-off-by: Daeseok Youn 
Signed-off-by: Greg Kroah-Hartman

staging: dgap: use gotos for handling error in dgap_remap()

2015-01-18T00:10:48+00:00

Signed-off-by: Daeseok Youn 
Signed-off-by: Greg Kroah-Hartman

Drivers:staging:dgap: Added a blank line after declaration

2014-11-26T22:00:22+00:00

This patch fixes the checkpatch.pl warning:

WARNING:Missing a blank line after declaration

Signed-off-by: Anjana Sasindran 
Signed-off-by: Greg Kroah-Hartman

staging: dgap: introducing find_board_by_major()

2014-11-07T17:30:22+00:00

use find_board_by_major function instead of getting a brd from static
arrary. Becasue tty's major number doesn't start zero and we can
find a brd from dgap_board[].

Signed-off-by: Daeseok Youn 
Signed-off-by: Greg Kroah-Hartman

staging: dgap: remove useless variables for saving tty's major

2014-11-07T17:30:22+00:00

The board_t has a tty_struct(serial_driver and print_driver)
that has a major number. When major number is compared in
dgap_tty_open(), just use brd->serial_driver{print_driver}->major.

Signed-off-by: Daeseok Youn 
Signed-off-by: Greg Kroah-Hartman

staging: dgap: fix memory leak caused by double allocation of tty_structs

2014-11-07T17:30:22+00:00

The tty_struct of serial_driver and print_driver were getting
allocated twice. One is allocated in tty_alloc_driver(), the other
is in dgap_tty_register(). So remove these in dgap_tty_register().

Signed-off-by: Daeseok Youn 
Signed-off-by: Greg Kroah-Hartman

staging: dgap: set tty's flags by tty_alloc_driver()

2014-11-07T17:30:21+00:00

tty's flags can be set by calling tty_alloc_driver().

Signed-off-by: Daeseok Youn 
Signed-off-by: Greg Kroah-Hartman

staging: dgap: remove unnecessary function

2014-11-05T22:49:14+00:00

The dgap_init_global() initialize the dgap_board
that is a global variable as static and dgap_poll_timer.
But init_timer() is called twice in dgap_start() and dgap_board
doesn't need to be initialized to NULL.

Signed-off-by: Daeseok Youn 
Signed-off-by: Greg Kroah-Hartman

staging: dgap: re-arrange functions for removing forward declarations

2014-11-04T00:24:56+00:00

Re-arrange the functions for removing forward declarations.

Signed-off-by: Daeseok Youn 
Tested-by: Mark Hounschell 
Signed-off-by: Greg Kroah-Hartman

staging: dgap: Remove useless cast on NULL

2014-10-30T20:09:15+00:00

Cast on NULL to a pointer type is not required. This
patch removes NULL casted to some pointer type.

The sematic patch used is:
@r@
type T;
@@
- (T *)NULL
+ NULL

Build tested it.

Signed-off-by: Tapasweni Pathak 
Reviewed-by: Josh Triplett 
Signed-off-by: Greg Kroah-Hartman