linux-stable.git/drivers/staging/comedi, branch v4.13

staging: comedi: comedi_fops: do not call blocking ops when !TASK_RUNNING

2017-07-30T15:38:43+00:00

Comedi's read and write file operation handlers (`comedi_read()` and
`comedi_write()`) currently call `copy_to_user()` or `copy_from_user()`
whilst in the `TASK_INTERRUPTIBLE` state, which falls foul of the
`might_fault()` checks when enabled.  Fix it by setting the current task
state back to `TASK_RUNNING` a bit earlier before calling these
functions.

Reported-by: Piotr Gregor 
Signed-off-by: Ian Abbott 
Cc:  # 4.5+
Signed-off-by: Greg Kroah-Hartman

staging: comedi: ni_mio_common: fix AO timer off-by-one regression

2017-07-16T07:13:53+00:00

As reported by Éric Piel on the Comedi mailing list (see
),
the analog output asynchronous commands are running too fast with a
period 50 ns shorter than it should be.  This affects all boards with AO
command support that are supported by the "ni_pcimio", "ni_atmio", and
"ni_mio_cs" drivers.

This is a regression bug introduced by commit 080e6795cba3 ("staging:
comedi: ni_mio_common: Cleans up/clarifies ni_ao_cmd"), specifically,
this line in `ni_ao_cmd_set_update()`:

		/* following line: N-1 per STC */
		ni_stc_writel(dev, trigvar - 1, NISTC_AO_UI_LOADA_REG);

The `trigvar` variable value comes from a call to `ni_ns_to_timer()`
which converts a timer period in nanoseconds to a hardware divisor
value. The function already reduces the divisor by 1 as required by the
hardware, so the above line should not reduce it further by 1.  Fix it
by replacing `trigvar` by `trigvar - 1` in the above line, and remove
the misleading comment.

Reported-by: Éric Piel 
Fixes: 080e6795cba3 ("staging: comedi: ni_mio_common: Cleans up/clarifies ni_ao_cmd")
Cc: Éric Piel 
Cc: Spencer E. Olson 
Cc:  # 4.7+
Signed-off-by: Ian Abbott 
Signed-off-by: Greg Kroah-Hartman

staging: comedi: use centralized error clean-up in comedi_init()

2017-06-23T16:37:07+00:00

Centralize the "clean-up on error" handling in `comedi_init()` using
`goto` statements.  Also change some of the explicit `-EIO` return
values to the error return values from the failing functions as there is
no good reason to use `-EIO` explicitly.

Signed-off-by: Ian Abbott 
Signed-off-by: Greg Kroah-Hartman

staging: comedi: fix clean-up of comedi_class in comedi_init()

2017-06-23T16:37:07+00:00

There is a clean-up bug in the core comedi module initialization
functions, `comedi_init()`.  If the `comedi_num_legacy_minors` module
parameter is non-zero (and valid), it creates that many "legacy" devices
and registers them in SysFS.  A failure causes the function to clean up
and return an error.  Unfortunately, it fails to destroy the "comedi"
class that was created earlier.  Fix it by adding a call to
`class_destroy(comedi_class)` at the appropriate place in the clean-up
sequence.

Signed-off-by: Ian Abbott 
Cc:  # 3.9+
Signed-off-by: Greg Kroah-Hartman

Staging: comedi: ni_labpc_regs: fixed a block comment alignment issue

2017-06-13T10:06:56+00:00

Fixed a coding style issue.

Signed-off-by: Amisha Singh 
Reviewed-by: Ian Abbott 
Signed-off-by: Greg Kroah-Hartman

staging: comedi: ni_labpc_isadma: fixed a comment coding style issue

2017-06-06T14:16:09+00:00

Fixed a BLOCK_COMMENT_STYLE warning reported by checkpatch.pl script.

Signed-off-by: Adrian Stanciu 
Signed-off-by: Greg Kroah-Hartman

Staging: comedi: s626.c: fixed trailing */ style issue

2017-06-04T08:17:42+00:00

Fixed coding style issue where trailing */ in block comments
were not on separate lines.

Signed-off-by: Elias Carter 
Signed-off-by: Greg Kroah-Hartman

staging: comedi: addi_apci_3xxx: check return value

2017-04-25T18:43:42+00:00

Function pci_ioremap_bar() will return a NULL pointer if there is no
enough memory. However, in function apci3xxx_auto_attach(), the return
value of function pci_ioremap_bar() is not validated. This may result in
NULL dereference in following access to dev->mmio. This patch fixes the
bug.

Signed-off-by: Pan Bian 
Reviewed-by: Ian Abbott 
Signed-off-by: Greg Kroah-Hartman

staging: comedi: support vm_access_process for mmap'd buffer

2017-04-25T18:43:42+00:00

If a process that has mmap'd a COMEDI buffer is being run under a
debugger such as GDB, the buffer contents are inaccessible from the
debugger.  Support the `access()` VM operation to allow the buffer
contents to be accessed by another process.

Signed-off-by: Ian Abbott 
Signed-off-by: Greg Kroah-Hartman

staging: comedi: drivers: s626.c - fixed checkpatch issue about data type

2017-04-08T15:05:59+00:00

staging: comedi: drivers: s626.c - fixed the following checkpatch issue:
CHECK: Prefer kernel type 's16' over 'int16_t'
#1939: FILE: drivers/staging/comedi/drivers/s626.c:1939:
+               int16_t dacdata = (int16_t)data[i];

Signed-off-by: Andrea della Porta 
Signed-off-by: Greg Kroah-Hartman