linux-stable.git/drivers/staging/ced1401, branch v3.10 Linux kernel stable tree staging: Remove unnecessary OOM messages 2013-02-11T18:10:33+00:00 Joe Perches joe@perches.com 2013-02-11T17:41:29+00:00 78110bb8dc4a7ff331bfa3cfe7d4e287cfb3f22b alloc failures already get standardized OOM messages and a dump_stack. For the affected mallocs around these OOM messages: Converted kzallocs with multiplies to kcalloc. Converted kmallocs with multiplies to kmalloc_array. Converted a kmalloc/strlen/strncpy to kstrdup. Moved a spin_lock below a removed OOM message and removed a now unnecessary spin_unlock. Neatened alignment and whitespace. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
alloc failures already get standardized OOM
messages and a dump_stack.

For the affected mallocs around these OOM messages:

Converted kzallocs with multiplies to kcalloc.
Converted kmallocs with multiplies to kmalloc_array.
Converted a kmalloc/strlen/strncpy to kstrdup.
Moved a spin_lock below a removed OOM message and
removed a now unnecessary spin_unlock.
Neatened alignment and whitespace.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: ced1401: fix GFP_KERNEL in spinlock context 2013-01-12T00:44:10+00:00 Alexey Khoroshilov khoroshilov@ispras.ru 2013-01-11T09:01:39+00:00 955e7da82d8cc917a2c604c782b525dec3466921 Allowi() calls usb_submit_urb(pdx->pUrbCharIn, bInCallback ? GFP_ATOMIC : GFP_KERNEL) under spin_lock_irqsave(&pdx->charInLock, flags). That means it should use GFP_ATOMIC anyway. As soon as it is the only usage of bInCallback argument, the patch removes it at all. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Allowi() calls usb_submit_urb(pdx->pUrbCharIn, bInCallback ? GFP_ATOMIC : GFP_KERNEL)
under spin_lock_irqsave(&pdx->charInLock, flags). That means it should use GFP_ATOMIC anyway.
As soon as it is the only usage of bInCallback argument, the patch removes it at all.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: ced1401: Fix typo in staging/ced1401 2012-11-27T00:21:58+00:00 Masanari Iida standby24x7@gmail.com 2012-11-22T15:47:54+00:00 b1a21ee9deb2492cbff38943dd6fa502161319a6 Correct spelling typo in comments within staging/ced1401 Signed-off-by: Masanari Iida <standby24x7@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Correct spelling typo in comments within staging/ced1401

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: ced1401: remove useless value cast on kmalloc() 2012-10-30T18:06:59+00:00 Fengguang Wu fengguang.wu@intel.com 2012-10-27T03:29:03+00:00 e6c5abf2542f1a91d31ae536707c00cf0ceaf376 Casting value returned by k[cmz]alloc to (struct page * *) is useless. Generated by: scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci Reported-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Casting value returned by k[cmz]alloc to (struct page * *) is useless.

Generated by: scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci

Reported-by: Fengguang Wu <fengguang.wu@intel.com>

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: ced1401: usb1401: remove unused including <linux/version.h> 2012-10-26T16:13:40+00:00 Wei Yongjun yongjun_wei@trendmicro.com.cn 2012-10-26T14:36:45+00:00 c665814d750a5f5a378e0adfd5bedcf08cb177c3 Remove including <linux/version.h> that don't need it. dpatch engine is used to auto generate this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Remove including <linux/version.h> that don't need it.

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: ced1401: fix a frame size warning 2012-10-24T03:35:54+00:00 Devendra Naga devendra.aaru@gmail.com 2012-10-22T21:22:20+00:00 5c092f41fdb636859a20f57372f8dd25633adbef gcc/sparse complain about the following: drivers/staging/ced1401/ced_ioc.c:931:1: warning: the frame size of 4144 bytes is larger than 2048 bytes [-Wframe-larger-than=] Fix it by dynamically allocating it. Signed-off-by: Devendra Naga <devendra.aaru@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
gcc/sparse complain about the following:

drivers/staging/ced1401/ced_ioc.c:931:1: warning: the frame size of 4144 bytes is larger than 2048 bytes [-Wframe-larger-than=]

Fix it by dynamically allocating it.

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Staging: ced1401: fix missing unlock on error in FreeCircBlock() 2012-10-22T20:28:43+00:00 Wei Yongjun yongjun_wei@trendmicro.com.cn 2012-10-22T05:22:15+00:00 a5e0f69c983a142daa95b70f709a3dabf76cb55f Add the missing unlock on the error handle path in function FreeCircBlock(). Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Add the missing unlock on the error handle path in function
FreeCircBlock().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: ced1401: remove kernel version ifdef 's 2012-10-22T20:28:13+00:00 Devendra Naga devendra.aaru@gmail.com 2012-10-22T15:49:47+00:00 7d82c65f04b00093088002a1d8c147006c98f960 We dont need these kernel versioning checks anyways. Signed-off-by: Devendra Naga <devendra.aaru@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
We dont need these kernel versioning checks anyways.

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: ced1401: fix some style warnings 2012-10-22T20:28:13+00:00 Devendra Naga devendra.aaru@gmail.com 2012-10-22T15:49:28+00:00 0965be39641589a66fd0ea5745d11a11ed0d3335 this fixes: comments to in kernel comment style the opening brace of if statement must be beside the if not below to it Signed-off-by: Devendra Naga <devendra.aaru@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
this fixes:

comments to in kernel comment style
the opening brace of if statement must be beside the if not below
to it

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: ced1401: remove an obvious commit about the minor number 2012-10-22T20:28:12+00:00 Devendra Naga devendra.aaru@gmail.com 2012-10-22T15:49:06+00:00 ff549e4772c8bcb787077fbf67006bff5961f149 in disconnect we assign the device minor number from the interface pointer to the localvarible minor, and then print it at the end, this code seems self explanatory so remove the comment of assigning the minor number to a local variable. Signed-off-by: Devendra Naga <devendra.aaru@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
in disconnect we assign the device minor number from the interface
pointer to the localvarible minor, and then print it at the end,

this code seems self explanatory so remove the comment of assigning
the minor number to a local variable.

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>