linux-stable.git/drivers/staging/ccree, branch linux-4.15.y

staging: ccree: fix fips event irq handling build

2018-02-03T16:58:37+00:00

commit dc5591dc9c03e4cd22d3f0c3659196cc34668452 upstream.

When moving from internal for kernel FIPS infrastructure the FIPS event irq
handling code was left with the old ifdef by mistake. Fix it.

Fixes: b7e607bf33a2 ("staging: ccree: move FIPS support to kernel infrastructure")
Signed-off-by: Gilad Ben-Yossef 
Signed-off-by: Greg Kroah-Hartman

staging: ccree: NULLify backup_info when unused

2018-02-03T16:58:37+00:00

commit 46df8824982e4fb0198776078d4a8c3e2d531464 upstream.

backup_info field is only allocated for decrypt code path.
The field was not nullified when not used causing a kfree
in an error handling path to attempt to free random
addresses as uncovered in stress testing.

Fixes: 737aed947f9b ("staging: ccree: save ciphertext for CTS IV")
Signed-off-by: Gilad Ben-Yossef 
Signed-off-by: Greg Kroah-Hartman

staging: ccree: Uninitialized return in ssi_ahash_import()

2017-12-06T14:49:26+00:00

The return value isn't initialized on some success paths.

Fixes: c5f39d07860c ("staging: ccree: fix leak of import() after init()")
Signed-off-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

staging: ccree: fix leak of import() after init()

2017-11-28T13:36:45+00:00

crypto_ahash_import() may be called either after
crypto_ahash_init() or without such call. Right now
we always internally call init() as part of
import(), thus leaking memory and mappings if the
user has already called init() herself.

Fix this by only calling init() internally if the
state is not already initialized.

Fixes: commit 454527d0d94f ("staging: ccree: fix hash import/export")
Cc: stable 
Signed-off-by: Gilad Ben-Yossef 
Reviewed-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

staging: ccree: simplify ioread/iowrite

2017-11-06T15:47:04+00:00

Registers ioread/iowrite operations were done via macros,
sometime using a "magical" implicit parameter.

Replace all register access with simple inline macros.

Signed-off-by: Gilad Ben-Yossef 
Signed-off-by: Greg Kroah-Hartman

staging: ccree: simplify registers access

2017-11-06T15:47:04+00:00

The register offset calculation macro was taking a HW block base
parameter that was not actually used. Simplify the whole thing
by dropping it and rename the macro for better readability.

Signed-off-by: Gilad Ben-Yossef 
Signed-off-by: Greg Kroah-Hartman

staging: ccree: simplify error handling logic

2017-11-06T15:47:04+00:00

Turn the code sites that don't require any special handling
on error return to a simple return.

Signed-off-by: Gilad Ben-Yossef 
Signed-off-by: Greg Kroah-Hartman

staging: ccree: remove dead code

2017-11-06T15:46:03+00:00

The inflight_counter field is updated in a single location and
never used. Remove it.

Signed-off-by: Gilad Ben-Yossef 
Signed-off-by: Greg Kroah-Hartman

staging: ccree: handle limiting of DMA masks

2017-11-06T15:46:03+00:00

Properly handle limiting of DMA masks based on device and bus
capabilities.

Signed-off-by: Gilad Ben-Yossef 
Signed-off-by: Greg Kroah-Hartman

staging: ccree: copy IV to DMAable memory

2017-11-06T15:46:03+00:00

We are being passed an IV buffer from unknown origin, which may be
stack allocated and thus not safe for DMA. Allocate a DMA safe
buffer for the IV and use that instead.

Signed-off-by: Gilad Ben-Yossef 
Signed-off-by: Greg Kroah-Hartman