linux-stable.git/drivers/staging/bcm, branch v3.2.99

staging: bcm: add 32-bit host dependency

2017-11-11T13:34:51+00:00

The driver uses a 32-bit variable to store a pointer, causing a couple of
warnings:

../drivers/staging/bcm/CmHost.c: In function 'StoreCmControlResponseMessage':
../drivers/staging/bcm/CmHost.c:1503:3: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
   (struct bcm_connect_mgr_params *) ntohl(
   ^
../drivers/staging/bcm/CmHost.c:1546:3: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
   (struct bcm_connect_mgr_params *) ntohl(
   ^
../drivers/staging/bcm/CmHost.c:1564:3: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
   (struct bcm_connect_mgr_params *) ntohl(

I fixed other warnings in an earlier commit 9f1c75ac2dba ("staging/bcm: fix most
build warnings"), but couldn't figure out what was the intended behavior on
64-bit machines here.

The driver was removed in linux-3.19, commit d09e9b160fc1 ("staging: bcm: remove
driver") which explains that it never worked on 64-bit machines. This adds
a Kconfig dependency instead to prevent it from being built in the known
broken configuration. This workaround applies to v2.6.37 or higher.

Fixes: f8942e07a3db ("staging: Beeceem USB Wimax driver")
Signed-off-by: Arnd Bergmann 
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings

Staging: bcm: info leak in ioctl

2013-11-28T14:02:06+00:00

commit 8d1e72250c847fa96498ec029891de4dc638a5ba upstream.

The DevInfo.u32Reserved[] array isn't initialized so it leaks kernel
information to user space.

Reported-by: Nico Golde 
Reported-by: Fabian Yamaguchi 
Signed-off-by: Dan Carpenter 
Signed-off-by: Linus Torvalds 
Signed-off-by: Ben Hutchings

Staging: bcm: Add two products and remove an existing product.

2013-01-03T03:33:08+00:00

commit 4f29ef050848245f7c180b95ccf67dfcd76b1fd8 upstream.

This patch adds two new products and modifies
the device id table to include them. In addition,
product of 0xbccd - BCM_USB_PRODUCT_ID_SM250 is
removed because Beceem, ZTE, Sprint use this id
for block devices.

Reported-by: Muhammad Minhazul Haque 
Signed-off-by: Kevin McKinney 
Signed-off-by: Greg Kroah-Hartman 
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings

Staging: bcm: Create and initialize new device id in InterfaceInit

2013-01-03T03:33:07+00:00

commit e66fc1fba248738d32f3b64508f9ef1176d9e767 upstream.

This patch create and initalizes a new device
id of 0x172 as reported by Rinat Camalov
. In addition, a
comment is added to the potential invalid
existing device id.

Reported-by: Rinat Camalov 
Signed-off-by: Kevin McKinney 
Signed-off-by: Greg Kroah-Hartman 
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings

Staging: bcm: Fix three initialization errors in InterfaceDld.c

2011-10-23T08:16:34+00:00

This patch fixes three initialization errors.
One is an incorrect initialization of a static
variable. The other two are incorrect
initializations in an if statement. These
errors were found by checkpatch.pl.

Signed-off-by: Kevin McKinney 
Signed-off-by: Greg Kroah-Hartman

Staging: bcm: Fix coding style issues in InterfaceDld.c

2011-10-23T08:16:34+00:00

This patch fixes multiple coding style issues in file,
InterfaceDld.c, found by checkpatch.pl.

Signed-off-by: Kevin McKinney 
Signed-off-by: Greg Kroah-Hartman

Staging: bcm: Fix coding style issues in InterfaceMisc.c

2011-10-11T16:18:58+00:00

This patch cleans up several code style issues found
in InterfaceMisc.c reported by checkpatch.pl.

Signed-off-by: Kevin McKinney 
Signed-off-by: Greg Kroah-Hartman

Staging: bcm: Remove assignment from if conditions reported by checkpatch.pl

2011-10-11T16:18:57+00:00

This patch removes an assignment from three if
conditions.  In all three cases, the line of code was
attempting to allocate memory, and check
if the memory was allocated in the if statement.
This issue was reported by checkpatch.pl.

Signed-off-by: Kevin McKinney 
Signed-off-by: Greg Kroah-Hartman

Staging: bcm: Fix coding style issues reported by checkpatch.pl

2011-10-11T16:18:57+00:00

This patch cleans up several code style issues found
in InterfaceInit.c reported by checkpatch.pl.

Signed-off-by: Kevin McKinney 
Signed-off-by: Greg Kroah-Hartman

Staging: bcm: Fix assignment issue in if statement reported by checkpatch.pl.

2011-10-11T16:18:21+00:00

This patch fixes an error where an assignment "="
was being used in an if statement to determine if
Firmware was downloaded. This patch removes that
assignment, and places it above the if statement.
The if statement then evaluates the status to
verify if "0" successful, or != 0 failure.

Signed-off-by: Kevin McKinney 
Signed-off-by: Greg Kroah-Hartman