linux-stable.git/drivers/staging/bcm, branch v3.16 Linux kernel stable tree drivers/staging: Remove useless return variables 2014-05-26T17:32:15+00:00 Peter Senna Tschudin peter.senna@gmail.com 2014-05-26T14:08:50+00:00 4764ca981b040048766e4f39a45a4b9c5cecff9c This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that find and fixes this issue is: // <smpl> @@ type T; constant C; identifier ret; @@ - T ret = C; ... when != ret when strict return - ret + C ; // </smpl> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.

Verified by compilation only.

The coccinelle script that find and fixes this issue is:
// <smpl>
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
    when strict
return
- ret
+ C
;
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
staging: Convert __FUNCTION__ to __func__ 2014-05-25T18:05:07+00:00 Joe Perches joe@perches.com 2014-05-24T05:13:20+00:00 f8628a47ba502ec2ec795dc0134f052f45ce2cd4 Use the normal mechanism for emitting a function name. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Use the normal mechanism for emitting a function name.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Staging: bcm: Shortened prototype for GetNextTargetBufferLocation() 2014-05-23T22:26:39+00:00 Matthias Beyer mail@beyermatthias.de 2014-05-23T20:24:05+00:00 1808bc67b1f00a54b3b5a23c51c361fd618796eb Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Staging: bcm: Shortened lines in SearchClsid() 2014-05-23T22:26:39+00:00 Matthias Beyer mail@beyermatthias.de 2014-05-23T20:24:04+00:00 3fdf44ca2a52c1ecd339e9ed19b6f60e547835df Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Staging: bcm: Shortened lines in deleteSFBySfid() 2014-05-23T22:26:39+00:00 Matthias Beyer mail@beyermatthias.de 2014-05-23T20:24:03+00:00 3563e4ee9ca099c10a0bc4bebe38a5661ba2ac28 Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Staging: bcm: Shortened lines in CopyIpAddrToClassifier() 2014-05-23T22:26:38+00:00 Matthias Beyer mail@beyermatthias.de 2014-05-23T20:24:02+00:00 e61f63557bcbe7bc036048c4f2b8391eb2134423 Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Staging: bcm: Replaced member accessing by variable 2014-05-23T22:26:38+00:00 Matthias Beyer mail@beyermatthias.de 2014-05-23T20:24:01+00:00 780eb92c857c63c995807193f6b3bdf86855ade0 Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Staging: bcm: Shortened lines and replaced member accessing in CopyIpAddrToClassifier() 2014-05-23T22:26:38+00:00 Matthias Beyer mail@beyermatthias.de 2014-05-23T20:24:00+00:00 d52fe04a6448bae89ce8820911efdb38001324df Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Staging: bcm: Shortened lines in CopyClassifierRuleToSF() 2014-05-23T22:26:38+00:00 Matthias Beyer mail@beyermatthias.de 2014-05-23T20:23:59+00:00 eb8d0c9195de173e055ec5fc7a9deebe05025b41 Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Staging: bcm: Replaced member accessing with variable 2014-05-23T22:26:38+00:00 Matthias Beyer mail@beyermatthias.de 2014-05-23T20:23:58+00:00 732f1eee33e5f1322a3c3cef8cdd31593698e796 Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>