linux-stable.git/drivers/staging/bcm, branch linux-3.13.y

net: core: explicitly select a txq before doing l2 forwarding

2014-01-10T18:23:08+00:00

Currently, the tx queue were selected implicitly in ndo_dfwd_start_xmit(). The
will cause several issues:

- NETIF_F_LLTX were removed for macvlan, so txq lock were done for macvlan
  instead of lower device which misses the necessary txq synchronization for
  lower device such as txq stopping or frozen required by dev watchdog or
  control path.
- dev_hard_start_xmit() was called with NULL txq which bypasses the net device
  watchdog.
- dev_hard_start_xmit() does not check txq everywhere which will lead a crash
  when tso is disabled for lower device.

Fix this by explicitly introducing a new param for .ndo_select_queue() for just
selecting queues in the case of l2 forwarding offload. netdev_pick_tx() was also
extended to accept this parameter and dev_queue_xmit_accel() was used to do l2
forwarding transmission.

With this fixes, NETIF_F_LLTX could be preserved for macvlan and there's no need
to check txq against NULL in dev_hard_start_xmit(). Also there's no need to keep
a dedicated ndo_dfwd_start_xmit() and we can just reuse the code of
dev_queue_xmit() to do the transmission.

In the future, it was also required for macvtap l2 forwarding support since it
provides a necessary synchronization method.

Cc: John Fastabend 
Cc: Neil Horman 
Cc: e1000-devel@lists.sourceforge.net
Signed-off-by: Jason Wang 
Acked-by: Neil Horman 
Acked-by: John Fastabend 
Signed-off-by: David S. Miller

Merge tag 'staging-3.13-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging

2013-11-07T06:07:58+00:00

Pull staging driver update from Greg KH:
 "Here's the big drivers/staging/ update for 3.13-rc1.

  Nothing major here, just a _ton_ of fixes and cleanups, mostly driven
  by the new round of OPW applicants, but also there are lots of other
  people doing staging tree cleanups these days in order to help get the
  drivers into mergable shape.

  We also merge, and then revert, the ktap code, as Ingo and the other
  perf/ftrace developers feel it should go into the "real" part of the
  kernel with only a bit more work, so no need to put it in staging for
  now.

  All of this has been in linux-next for a while with no reported
  issues"

* tag 'staging-3.13-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging: (1045 commits)
  staging: drm/imx: fix return value check in ipu_add_subdevice_pdata()
  Staging: zram: Fix access of NULL pointer
  Staging: zram: Fix variable dereferenced before check
  Staging: rtl8187se: space prohibited before semicolon in r8185b_init.c
  Staging: rtl8187se: fix space prohibited after that open parenthesis '(' in r8185b_init.c
  Staging: rtl8187se: fix braces {} are not necessary for single statement blocks in r8185b_init.c
  Staging: rtl8187se: fix trailing whitespace in r8185b_init.c
  Staging: rtl8187se: fix please, no space before tabs in r8185b_init.c
  drivers/staging/nvec/Kconfig: remove trailing whitespace
  Staging: dwc2: Fix variable dereferenced before check
  Staging: xgifb: fix braces {} are not necessary for any arm of this statement
  staging: rtl8192e: remove unneeded semicolons
  staging: rtl8192e: use true and false for bool variables
  staging: ft1000: return values corrected in scram_start_dwnld
  staging: ft1000: change values of status return variable in write_dpram32_and_check
  staging: bcm: Remove unnecessary pointer casting
  imx-drm: ipuv3-crtc: Invert IPU DI0 clock polarity
  staging: r8188eu: Fix sparse warnings in rtl_p2p.c
  staging: r8188eu: Fix sparse warnings in rtw_mlme_ext.c
  staging: r8188eu: Fix sparse warnings in rtl8188e.cmd.c
  ...

Staging: bcm: info leak in ioctl

2013-10-30T19:24:49+00:00

The DevInfo.u32Reserved[] array isn't initialized so it leaks kernel
information to user space.

Reported-by: Nico Golde 
Reported-by: Fabian Yamaguchi 
Signed-off-by: Dan Carpenter 
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds

staging: bcm: Remove unnecessary pointer casting

2013-10-30T00:03:40+00:00

Some void pointers can be assigned to other
pointer variables in functions without casting.

Signed-off-by: Lisa Nguyen 
Signed-off-by: Greg Kroah-Hartman

Staging: bcm: Fix WARNING: space prohibited before semicolon.

2013-10-29T15:54:12+00:00

This patch removes a space before semicolon as
specified by checkpatch.pl.

Signed-off-by: Kevin McKinney 
Signed-off-by: Greg Kroah-Hartman

drivers: staging: bcm: Removed a developer debug statement.

2013-10-29T15:51:07+00:00

Removed a developer debug statement per the TODO list.  Additionally,
removed braces for the if-statement to match coding style.

Signed-off-by: Chuong Ngo 
Signed-off-by: Greg Kroah-Hartman

Stging: bcm: Adapter.h : removed typedef from struct _U_IP_ADDRESS and changed it to lowercase

2013-10-29T15:44:54+00:00

Running checkpatch.pl on the file drivers/staging/bcm/Adapter.h gave
an error as it is a mistake to use typedef for structures
according to CodeingStyle as it reduces readability. The typedef was
removed and all occurrences of the typedef union were replaced with
union u_ip_address as types are all lowercase.

Signed-off-by: Himangi Saraogi 
Signed-off-by: Greg Kroah-Hartman

staging: bcm: Replace FALSE with false

2013-10-28T21:13:46+00:00

Replace user-defined type FALSE with C defined false keyword.

Signed-off-by: Lisa Nguyen 
Signed-off-by: Greg Kroah-Hartman

staging: bcm: Replace BOOLEAN with bool

2013-10-28T21:13:08+00:00

Remove user-defined BOOLEAN data type with C bool data
type.

Signed-off-by: Lisa Nguyen 
Signed-off-by: Greg Kroah-Hartman

Staging: bcm: line over 80 characters in Bcmnet.c

2013-10-08T01:39:32+00:00

Fix checkpatch.pl issues with line over 80 characters in Bcmnet.c

Signed-off-by: Ebru Akagunduz 
Signed-off-by: Greg Kroah-Hartman