linux-stable.git/drivers/staging/bcm/InterfaceInit.c, branch v3.12

staging: Remove unnecessary OOM messages

2013-02-11T18:10:33+00:00

alloc failures already get standardized OOM
messages and a dump_stack.

For the affected mallocs around these OOM messages:

Converted kzallocs with multiplies to kcalloc.
Converted kmallocs with multiplies to kmalloc_array.
Converted a kmalloc/strlen/strncpy to kstrdup.
Moved a spin_lock below a removed OOM message and
removed a now unnecessary spin_unlock.
Neatened alignment and whitespace.

Signed-off-by: Joe Perches 
Signed-off-by: Greg Kroah-Hartman

Staging: bcm: Add two products and remove an existing product.

2012-11-13T20:38:29+00:00

This patch adds two new products and modifies
the device id table to include them. In addition,
product of 0xbccd - BCM_USB_PRODUCT_ID_SM250 is
removed because Beceem, ZTE, Sprint use this id
for block devices.

Reported-by: Muhammad Minhazul Haque 
Signed-off-by: Kevin McKinney 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

Staging: bcm: Remove typedef for _S_INTERFACE_ADAPTER and call directly.

2012-11-02T18:36:46+00:00

This patch removes typedef for
_S_INTERFACE_ADAPTER, changes the
name of the struct to bcm_interface_adapter.
In addition, any calls to typedefs
S_INTERFACE_ADAPTER, or *PS_INTERFACE_ADAPTER
are changed to call the struct directly.

Signed-off-by: Kevin McKinney 
Signed-off-by: Greg Kroah-Hartman

Staging: bcm: Create and initialize new device id in InterfaceInit

2012-09-12T16:43:45+00:00

This patch create and initalizes a new device
id of 0x172 as reported by Rinat Camalov
. In addition, a
comment is added to the potential invalid
existing device id.

Reported-by: Rinat Camalov 
Signed-off-by: Kevin McKinney 
Signed-off-by: Greg Kroah-Hartman

staging: bcm: use pr_info and pr_err rather than printk

2012-09-04T21:28:42+00:00

Convert printk(KERN_INFO to pr_info( and printk(KERN_ERR to pr_err(.

Signed-off-by: Alexey Khoroshilov 
Acked-by: Kevin McKinney 
Signed-off-by: Greg Kroah-Hartman

staging: bcm: fix error handling in bcm_init()

2012-09-04T21:28:42+00:00

bcm_init() does not have proper error handling of usb_register().
The patch implements one.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov 
Acked-by: Kevin McKinney 
Signed-off-by: Greg Kroah-Hartman

Staging: bcm: Remove typedef for _MINI_ADAPTER and call directly.

2012-06-05T04:09:22+00:00

This patch removes typedef for _MINI_ADAPTER, changes the
name of the struct from _MINI_ADAPTER to bcm_mini_adapter.
In addition, any calls to the following typedefs
"MINI_ADAPTER, *PMINI_ADAPTER" are changed to call
the struct directly.

Signed-off-by: Kevin McKinney 
Signed-off-by: Greg Kroah-Hartman

Staging: bcm: Fix information leak in ioctl: IOCTL_BCM_REGISTER_READ_PRIVATE, IOCTL_BCM_EEPROM_REGISTER_READ

2011-11-27T01:11:58+00:00

This patch fixes an information leak in ioctl
IOCTL_BCM_REGISTER_READ_PRIVATE and
IOCTL_BCM_EEPROM_REGISTER_READ when determining
the number of bytes to copy to user space.  Function,
usb_control_msg, returns the correct number of
bytes from the hardware.  Instead of using
this value, we were using a value derived from
user space. In this case, this value could be more
than the hardware allocated.  Therefore, this
patch copies the proper number of bytes from
the hardware, and uses this value as the maximum
number of bytes for user space.

Signed-off-by: Kevin McKinney 
Reviewed-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

Staging: bcm: Remove assignment from if conditions reported by checkpatch.pl

2011-10-11T16:18:57+00:00

This patch removes an assignment from three if
conditions.  In all three cases, the line of code was
attempting to allocate memory, and check
if the memory was allocated in the if statement.
This issue was reported by checkpatch.pl.

Signed-off-by: Kevin McKinney 
Signed-off-by: Greg Kroah-Hartman

Staging: bcm: Fix coding style issues reported by checkpatch.pl

2011-10-11T16:18:57+00:00

This patch cleans up several code style issues found
in InterfaceInit.c reported by checkpatch.pl.

Signed-off-by: Kevin McKinney 
Signed-off-by: Greg Kroah-Hartman