linux-stable.git/drivers/staging/asus_oled, branch v3.3

Staging: asus_oled: fix NULL-ptr crash on unloading

2012-02-08T22:14:13+00:00

Asus_oled triggers the following bug on module unloading:

 usbcore: deregistering interface driver asus-oled
 BUG: unable to handle kernel NULL pointer dereference at 0000000000000038
 IP: [] sysfs_delete_link+0x30/0x66

 Call Trace:
  [] device_remove_class_symlinks+0x6b/0x70
  [] device_del+0x9f/0x1ab
  [] device_unregister+0x11/0x1e
  [] asus_oled_disconnect+0x4f/0x9e [asus_oled]
  [] usb_unbind_interface+0x54/0x103
  [] __device_release_driver+0xa2/0xeb
  [] driver_detach+0x87/0xad
  [] bus_remove_driver+0x91/0xc1
  [] driver_unregister+0x66/0x6e
  [] usb_deregister+0xbb/0xc4
  [] asus_oled_exit+0x2f/0x31 [asus_oled]
  [] sys_delete_module+0x1b8/0x21b
  [] ? do_munmap+0x2ef/0x313
  [] system_call_fastpath+0x16/0x1b

This is due to an incorrect destruction sequence in asus_oled_exit().

Fix the order, fixes the bug. Tested on an Asus G50V laptop only.

Cc: Jakub Schmidtke 
Signed-off-by: Pekka Paalanen 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

Staging: asus_oled: fix image processing

2012-02-08T22:14:13+00:00

Programming an image was broken, because odev->buf_offs was not advanced
for val == 0 in append_values(). This regression was introduced in:

 commit 1ff12a4aa354bed093a0240d5e6347b1e27601bc
 Author: Kevin A. Granade 
 Date:   Sat Sep 5 01:03:39 2009 -0500

     Staging: asus_oled: Cleaned up checkpatch issues.

Fix the image processing by special-casing val == 0.

I have tested this change on an Asus G50V laptop only.

Cc: Jakub Schmidtke 
Cc: Kevin A. Granade 
Signed-off-by: Pekka Paalanen 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

Staging: asus_oled: Fixed use of obsolete function.

2011-11-27T02:13:54+00:00

Removed use of obsolete function "strict_strtoul". Replaced with "kstrtoul"
as suggested by checkpatch.pl

Signed-off-by: Ken O'Brien 
Signed-off-by: Greg Kroah-Hartman

Staging: Merge 2.6.37-rc5 into staging-next

2010-12-07T18:47:56+00:00

This was done to handle a number of conflicts in the batman-adv
and winbond drivers properly.  It also now allows us to fix up the sysfs
attributes properly that were not in the .37 release due to them being
only in this tree at the time.

Signed-off-by: Greg Kroah-Hartman

Staging: asus_oled: fix up my fixup for some sysfs attribute permissions

2010-11-18T19:27:18+00:00

They should be writable by root, not readable.
Doh, stupid me with the wrong flags.

Reported-by: Jonathan Cameron 
Cc: Jakub Schmidtke 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

Staging: asus_oled: fix up some sysfs attribute permissions

2010-11-16T19:17:01+00:00

They should not be writable by any user

Reported-by: Linus Torvalds 
Cc: Jakub Schmidtke 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

Staging: asus_oled: fix coding style issue in asus_oled.c

2010-11-10T00:37:17+00:00

This is a patch to the asus_oled.c file that fixes up brace and enum
warning found by the checkpatch.pl tool

Signed-off-by: Johan Meiring 
Signed-off-by: Greg Kroah-Hartman

Update broken web addresses in the kernel.

2010-10-18T09:03:14+00:00

The patch below updates broken web addresses in the kernel

Signed-off-by: Justin P. Mattock 
Cc: Maciej W. Rozycki 
Cc: Geert Uytterhoeven 
Cc: Finn Thain 
Cc: Randy Dunlap 
Cc: Matt Turner 
Cc: Dimitry Torokhov 
Cc: Mike Frysinger 
Acked-by: Ben Pfaff 
Acked-by: Hans J. Koch 
Reviewed-by: Finn Thain 
Signed-off-by: Jiri Kosina

Staging: asus_oled: asus_oled.c: Checkpatch cleanup

2010-05-11T18:35:30+00:00

drivers/staging/asus_oled/asus_oled.c:774: ERROR: code indent should use tabs where possible

Signed-off-by: Andrea Gelmini 
Signed-off-by: Greg Kroah-Hartman

driver core: Convert some drivers to CLASS_ATTR_STRING

2010-03-08T01:04:48+00:00

Convert some drivers who export a single string as class attribute
to the new class_attr_string functions. This removes redundant
code all over.

Signed-off-by: Andi Kleen 
Signed-off-by: Greg Kroah-Hartman