linux-stable.git/drivers/staging/android/logger.c, branch v3.5

staging: android: logger: Fix some sparse and whitespace issues

2012-05-10T22:47:01+00:00

Fix a few sparse warnings, and improve whitespace.

Cc: Brian Swetland 
Signed-off-by: Tim Bird 
Signed-off-by: Greg Kroah-Hartman

staging: android: logger: Allocate logs dynamically at boot (v3)

2012-05-10T22:40:56+00:00

This changes the log initialization to be dynamic, but still
at boot time.  These changes are a predecessor to implementing
runtime allocation and freeing of logs, to make the Android logger
less hard-coded.

Change from a fixed set of static log structures, to allocation
at init time into a list.  Return proper error numbers on log
allocation failure.

Cc: Brian Swetland 
Signed-off-by: Tim Bird 
Signed-off-by: Greg Kroah-Hartman

staging: logger: hold mutex while removing reader

2012-02-24T20:03:14+00:00

The readers list is traversed under the log->mutex lock
(for example from fix_up_readers()), but the deletion of
elements from this list is not being done under this lock.

Cc: Brian Swetland 
Cc: Dima Zavin 
Signed-off-by: Rabin Vincent 
Signed-off-by: Greg Kroah-Hartman

staging: android: logger: clarify non-update of w_off in do_write_log_from_user

2012-02-09T00:52:45+00:00

Add comment to explain when w_off is not updated in case of failed second
fragment copy to buffer.

Signed-off-by: Tim Bird 
Signed-off-by: Greg Kroah-Hartman

staging: android: logger: clarify code in clock_interval

2012-02-09T00:52:44+00:00

Add commentary, rename the function and make the code easier to read.

Signed-off-by: Tim Bird 
Signed-off-by: Greg Kroah-Hartman

staging: android: logger: reorder prepare_to_wait and mutex_lock

2012-02-09T00:52:44+00:00

If mutex_lock waits, it will return in state TASK_RUNNING,
rubbing out the effect of prepare_to_wait().

Signed-off-by: Tim Bird 
Signed-off-by: Greg Kroah-Hartman

staging: android: logger: simplify and optimize get_entry_len

2012-02-09T00:51:45+00:00

Make this code slightly easier to read, and eliminate calls
to sub-routines.  Some of these were previously optimized away
by the compiler, but one memcpy was not.

In my testing, this makes the code about 20% smaller, and
has no sub-routine calls and no branches (on ARM).

v2 of this patch is, IMHO, easier to read than v1. Compared to
that patch it uses __u8 instead of unsigned char, for
consistency with the __u16 val data type, simplifies the
conditional expression, adds a another comment, and
moves a common statement out of the if.

Signed-off-by: Tim Bird 
Signed-off-by: Greg Kroah-Hartman

staging: android: logger: Change logger_offset() from macro to function

2012-02-09T00:51:45+00:00

Convert to function and add log as a parameter, rather than relying
on log in the context of the macro.

Signed-off-by: Tim Bird 
Signed-off-by: Greg Kroah-Hartman

Staging: android: fixed white spaces coding style issue in logger.c

2011-12-16T18:54:14+00:00

This patch fixes some space-before-tabs warnings found by checkpatch tool on the staging android driver file logger.c

Signed-off-by: Marco Navarra 
Signed-off-by: Greg Kroah-Hartman

android: logger: bump up the logger buffer sizes

2011-11-30T12:22:32+00:00

(port from common android-2.6.39
  commit: 11430f16545205c614dd5bd58e4a7ee630fc0f9f)

events: (no change, 256)
main: 64 -> 256
radio: 64 -> 256
system: 64 -> 256

Signed-off-by: JP Abgrall 
Signed-off-by: Greg Kroah-Hartman