linux-stable.git/drivers/staging/android/ion, branch v4.1

staging: android: ion: fix wrong init of dma_buf_export_info

2015-04-21T09:17:16+00:00

Fixes: 817bd7253291 ("dma-buf: cleanup dma_buf_export() to make it
easily extensible")

Stupid copy-paste from me in the above patch leads to the following static
checker warning:

        drivers/staging/android/ion/ion.c:1112 ion_share_dma_buf()
        error: potentially dereferencing uninitialized 'buffer'.

drivers/staging/android/ion/ion.c
  1103  struct dma_buf *ion_share_dma_buf(struct ion_client *client,
  1104                                                  struct
ion_handle *handle)
  1105  {
  1106          struct ion_buffer *buffer;
                                   ^^^^^^
  1107          struct dma_buf *dmabuf;
  1108          bool valid_handle;
  1109          DEFINE_DMA_BUF_EXPORT_INFO(exp_info);
  1110
  1111          exp_info.ops = &dma_buf_ops;
  1112          exp_info.size = buffer->size;
                                ^^^^^^
  1113          exp_info.flags = O_RDWR;
  1114          exp_info.priv = buffer;
                                ^^^^^^
And here also.

  1115

This patch corrects this stupidity.

Reported-by: Dan Carpenter 
Reviewed-by: Dan Carpenter 
Acked-by: Greg Kroah-Hartman 
Signed-off-by: Sumit Semwal

dma-buf: cleanup dma_buf_export() to make it easily extensible

2015-04-21T09:17:16+00:00

At present, dma_buf_export() takes a series of parameters, which
makes it difficult to add any new parameters for exporters, if required.

Make it simpler by moving all these parameters into a struct, and pass
the struct * as parameter to dma_buf_export().

While at it, unite dma_buf_export_named() with dma_buf_export(), and
change all callers accordingly.

Reviewed-by: Maarten Lankhorst 
Reviewed-by: Daniel Thompson 
Acked-by: Mauro Carvalho Chehab 
Acked-by: Dave Airlie 
Signed-off-by: Sumit Semwal

staging: android: ion_test: Add the MODULE_LICENSE macro

2015-04-03T13:13:52+00:00

Base on the file comment should define GPL v2 for ion test driver

Signed-off-by: Phong Tran 
Signed-off-by: Greg Kroah-Hartman

ion: improve ion_phys error message

2015-03-20T12:44:39+00:00

Clients often get confused when ion_phys errors out due to some heap
being used that they didn't expect.  Add the heap name and heap type to
the error message to make it more obvious.

Signed-off-by: Mitchel Humpherys 
Signed-off-by: Greg Kroah-Hartman

staging: android: ion: fix some format strings

2015-03-02T02:46:15+00:00

C99 says that a precision which is simply '.' with no following digits
or * should be interpreted as 0, which means that these format strings
actually mean 'print 16 spaces'. However, the kernel's printf
implementation treats this case as if the precision was omitted. Don't
rely on that quirk.

Signed-off-by: Rasmus Villemoes 
Signed-off-by: Greg Kroah-Hartman

staging: ion: always initialize the free list parameters

2015-01-18T00:16:00+00:00

Currently we initialize the heap free_lock and free list size in
ion_heap_init_deferred_free, which is only called when the
ION_HEAP_FLAG_DEFER_FREE heap flag is given.  However, the lock and size
are used in the shrinker path as well as the deferred free path, and we
can register a shrinker *without* enabling deferred freeing.  So, if a
heap provides a shrinker but *doesn't* set the DEFER_FREE flag we will
use these parameters uninitialized (resulting in a spinlock bug and
broken shrinker accounting).

Fix these problems by initializing the free list parameters directly in
ion_device_add_heap, which is always called no matter which heap
features are being used.

Signed-off-by: Mitchel Humpherys 
Signed-off-by: Greg Kroah-Hartman

staging: ion: ion_cma_heap: remove ion_cma_get_sgtable

2015-01-18T00:14:16+00:00

Remove the temporary code ion_cma_get_sgtable,
use dma_common_get_sgtable instead

Signed-off-by: Zeng Tao 
Signed-off-by: Greg Kroah-Hartman

staging: android: ion: Deletion of unnecessary checks before two function calls

2014-11-26T21:42:53+00:00

The functions ion_heap_destroy() and vfree() perform also input
parameter validation. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
Signed-off-by: Greg Kroah-Hartman

Staging: android: ion: fix typos in comments

2014-11-04T00:22:50+00:00

s/comming/coming/ in drivers/staging/android/ion/ion.c
s/specfic/specific/ in drivers/staging/android/ion/ion.h
s/peformance/performance/ in drivers/staging/android/ion/ion_priv.h

Signed-off-by: Tristan Lelong 
Signed-off-by: Greg Kroah-Hartman

staging: android: Assign bool to true

2014-10-23T04:38:32+00:00

high is a bool type variable.

bool variable should be assigned true, false not 1 or 0.

This patch assigns high to true, replacing 1.

Signed-off-by: Tapasweni Pathak 
Signed-off-by: Greg Kroah-Hartman