linux-stable.git/drivers/staging/android/binder.c, branch v3.18

staging: binder: fix coding style issues

2014-09-08T20:29:01+00:00

Fix coding style issues:
* put braces in all if-else branches;
* limit the length of changed lines to 80 columns.
checkpatch.pl warning count reduces by 3.

Signed-off-by: Dmitry Voytik 
Signed-off-by: Greg Kroah-Hartman

staging: android: Break up a long line in binder_send_failed_reply

2014-09-08T20:29:01+00:00

Kernel coding style. Breaking long lines and strings.

Signed-off-by: William Panlener 
Signed-off-by: Greg Kroah-Hartman

mm/vmalloc.c: clean up map_vm_area third argument

2014-08-07T01:01:19+00:00

Currently map_vm_area() takes (struct page *** pages) as third argument,
and after mapping, it moves (*pages) to point to (*pages +
nr_mappped_pages).

It looks like this kind of increment is useless to its caller these
days.  The callers don't care about the increments and actually they're
trying to avoid this by passing another copy to map_vm_area().

The caller can always guarantee all the pages can be mapped into vm_area
as specified in first argument and the caller only cares about whether
map_vm_area() fails or not.

This patch cleans up the pointer movement in map_vm_area() and updates
its callers accordingly.

Signed-off-by: WANG Chao 
Cc: Zhang Yanfei 
Acked-by: Greg Kroah-Hartman 
Cc: Minchan Kim 
Cc: Nitin Gupta 
Cc: Rusty Russell 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

staging: android: Clean up else statement from binder_send_failed_reply

2014-07-15T19:08:52+00:00

Kernel coding style. Remove useless else statement after return.

Changes from v1 and v2: Fix warning for mixed declarations and code.
Declaration of "struct binder_transaction *next" made outside of while.

Changes from v3: Removed initialization to NULL for next variable.

Signed-off-by: Lucas Tanure 
Signed-off-by: Greg Kroah-Hartman

staging: android: binder.c: binder_ioctl() cleanup

2014-07-08T22:42:06+00:00

binder_ioctl() is quite huge and checkpatch dirty - mostly because of
the amount of code for the BINDER_WRITE_READ and BINDER_SET_CONTEXT_MGR.
Moved that code into the new binder_ioctl_write_read() and
binder_ioctl_set_ctx_mgr()

Signed-off-by: Tair Rzayev 
Cc: Arve HjÃ¸nnevÃ¥g 
Signed-off-by: Greg Kroah-Hartman

staging: binder: add vm_fault handler

2014-07-08T22:42:06+00:00

An issue was observed when a userspace task exits.
The page which hits error here is the zero page.
In binder mmap, the whole of vma is not mapped.
On a task crash, when debuggerd reads the binder regions,
the unmapped areas fall to do_anonymous_page in handle_pte_fault,
due to the absence of a vm_fault handler. This results in
zero page being mapped. Later in zap_pte_range, vm_normal_page
returns zero page in the case of VM_MIXEDMAP and it results in the
error.

BUG: Bad page map in process mediaserver  pte:9dff379f pmd:9bfbd831
page:c0ed8e60 count:1 mapcount:-1 mapping:  (null) index:0x0
page flags: 0x404(referenced|reserved)
addr:40c3f000 vm_flags:10220051 anon_vma:  (null) mapping:d9fe0764 index:fd
vma->vm_ops->fault:   (null)
vma->vm_file->f_op->mmap: binder_mmap+0x0/0x274
CPU: 0 PID: 1463 Comm: mediaserver Tainted: G        W    3.10.17+ #1
[] (unwind_backtrace+0x0/0x11c) from [] (show_stack+0x10/0x14)
[] (show_stack+0x10/0x14) from [] (print_bad_pte+0x158/0x190)
[] (print_bad_pte+0x158/0x190) from [] (unmap_single_vma+0x2e4/0x598)
[] (unmap_single_vma+0x2e4/0x598) from [] (unmap_vmas+0x34/0x50)
[] (unmap_vmas+0x34/0x50) from [] (exit_mmap+0xc8/0x1e8)
[] (exit_mmap+0xc8/0x1e8) from [] (mmput+0x54/0xd0)
[] (mmput+0x54/0xd0) from [] (do_exit+0x360/0x990)
[] (do_exit+0x360/0x990) from [] (do_group_exit+0x84/0xc0)
[] (do_group_exit+0x84/0xc0) from [] (get_signal_to_deliver+0x4d4/0x548)
[] (get_signal_to_deliver+0x4d4/0x548) from [] (do_signal+0xa8/0x3b8)

Add a vm_fault handler which returns VM_FAULT_SIGBUS, and prevents the
wrong fallback to do_anonymous_page.

Signed-off-by: Vinayak Menon 
Signed-off-by: Greg Kroah-Hartman

Staging: Android: removed an unnecessary else statement

2014-06-27T00:18:58+00:00

As per checkpatch warning, removed an unnecessary else statement
proceeding an if statement with a return.

Signed-off-by: Karthik Nayak 
Signed-off-by: Greg Kroah-Hartman

Merge branch 'sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip into next

2014-06-03T21:00:15+00:00

Pull scheduler updates from Ingo Molnar:
 "The main scheduling related changes in this cycle were:

   - various sched/numa updates, for better performance

   - tree wide cleanup of open coded nice levels

   - nohz fix related to rq->nr_running use

   - cpuidle changes and continued consolidation to improve the
     kernel/sched/idle.c high level idle scheduling logic.  As part of
     this effort I pulled cpuidle driver changes from Rafael as well.

   - standardized idle polling amongst architectures

   - continued work on preparing better power/energy aware scheduling

   - sched/rt updates

   - misc fixlets and cleanups"

* 'sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip: (49 commits)
  sched/numa: Decay ->wakee_flips instead of zeroing
  sched/numa: Update migrate_improves/degrades_locality()
  sched/numa: Allow task switch if load imbalance improves
  sched/rt: Fix 'struct sched_dl_entity' and dl_task_time() comments, to match the current upstream code
  sched: Consolidate open coded implementations of nice level frobbing into nice_to_rlimit() and rlimit_to_nice()
  sched: Initialize rq->age_stamp on processor start
  sched, nohz: Change rq->nr_running to always use wrappers
  sched: Fix the rq->next_balance logic in rebalance_domains() and idle_balance()
  sched: Use clamp() and clamp_val() to make sys_nice() more readable
  sched: Do not zero sg->cpumask and sg->sgp->power in build_sched_groups()
  sched/numa: Fix initialization of sched_domain_topology for NUMA
  sched: Call select_idle_sibling() when not affine_sd
  sched: Simplify return logic in sched_read_attr()
  sched: Simplify return logic in sched_copy_attr()
  sched: Fix exec_start/task_hot on migrated tasks
  arm64: Remove TIF_POLLING_NRFLAG
  metag: Remove TIF_POLLING_NRFLAG
  sched/idle: Make cpuidle_idle_call() void
  sched/idle: Reflow cpuidle_idle_call()
  sched/idle: Delay clearing the polling bit
  ...

staging: android: binder.c: Use more appropriate functions for euid retrieval

2014-06-01T18:36:47+00:00

Instead of getting the reference to whole credential structure, use
task_euid() and current_euid() to get it.

Signed-off-by: Tair Rzayev 
Signed-off-by: Greg Kroah-Hartman

staging: binder: fix usage of uninit scalar in binder_transaction()

2014-05-23T11:51:32+00:00

Fix the error path when a cookie mismatch is detected. In that case the
function jumps to the exit label without setting the uninitialized, local
variable 'return_error'. Detected by Coverity - CID 201453.

Signed-off-by: Christian Engelmayer 
Acked-by: Arve 
Signed-off-by: Greg Kroah-Hartman