linux-stable.git/drivers/spmi, branch v4.14.331

spmi: Add a check for remove callback when removing a SPMI driver

2023-05-17T09:11:44+00:00

[ Upstream commit b56eef3e16d888883fefab47425036de80dd38fc ]

When removing a SPMI driver, there can be a crash due to NULL pointer
dereference if it does not have a remove callback defined. This is
one such call trace observed when removing the QCOM SPMI PMIC driver:

 dump_backtrace.cfi_jt+0x0/0x8
 dump_stack_lvl+0xd8/0x16c
 panic+0x188/0x498
 __cfi_slowpath+0x0/0x214
 __cfi_slowpath+0x1dc/0x214
 spmi_drv_remove+0x16c/0x1e0
 device_release_driver_internal+0x468/0x79c
 driver_detach+0x11c/0x1a0
 bus_remove_driver+0xc4/0x124
 driver_unregister+0x58/0x84
 cleanup_module+0x1c/0xc24 [qcom_spmi_pmic]
 __do_sys_delete_module+0x3ec/0x53c
 __arm64_sys_delete_module+0x18/0x28
 el0_svc_common+0xdc/0x294
 el0_svc+0x38/0x9c
 el0_sync_handler+0x8c/0xf0
 el0_sync+0x1b4/0x1c0

If a driver has all its resources allocated through devm_() APIs and
does not need any other explicit cleanup, it would not require a
remove callback to be defined. Hence, add a check for remove callback
presence before calling it when removing a SPMI driver.

Link: https://lore.kernel.org/r/1671601032-18397-2-git-send-email-quic_jprakash@quicinc.com
Fixes: 6f00f8c8635f ("mfd: qcom-spmi-pmic: Use devm_of_platform_populate()")
Fixes: 5a86bf343976 ("spmi: Linux driver framework for SPMI")
Signed-off-by: Jishnu Prakash 
Signed-off-by: Stephen Boyd 
Link: https://lore.kernel.org/r/20230413223834.4084793-7-sboyd@kernel.org
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Sasha Levin

spmi: pmic-arb: correct duplicate APID to PPID mapping logic

2022-10-26T11:17:07+00:00

[ Upstream commit 1f1693118c2476cb1666ad357edcf3cf48bf9b16 ]

Correct the way that duplicate PPID mappings are handled for PMIC
arbiter v5.  The final APID mapped to a given PPID should be the
one which has write owner = APPS EE, if it exists, or if not
that, then the first APID mapped to the PPID, if it exists.

Fixes: 40f318f0ed67 ("spmi: pmic-arb: add support for HW version 5")
Signed-off-by: David Collins 
Signed-off-by: Fenglin Wu 
Link: https://lore.kernel.org/r/1655004286-11493-7-git-send-email-quic_fenglinw@quicinc.com
Signed-off-by: Stephen Boyd 
Link: https://lore.kernel.org/r/20220930005019.2663064-8-sboyd@kernel.org
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Sasha Levin

spmi: pmic-arb: Move the ownership check to irq_chip callback

2017-08-28T11:52:22+00:00

Check the irq ownership in the irq_request_resources callback
instead of checking it during the irq mapping. This can prevent
installing the flow handler for the interrupt that is not owned by the EE
and allow the irq translation during the gpio driver probe.

Signed-off-by: Kiran Gunda 
Tested-by: Shawn Guo 
Signed-off-by: Greg Kroah-Hartman

spmi: Convert to using %pOF instead of full_name

2017-08-28T11:51:20+00:00

Now that we have a custom printf format specifier, convert users of
full_name to use %pOF instead. This is preparation to remove storing
of the full path string for each node.

Signed-off-by: Rob Herring 
Reviewed-by: Stephen Boyd 
Signed-off-by: Greg Kroah-Hartman

spmi: pmic-arb: Remove checking opc value not less than 0

2017-08-28T11:51:19+00:00

The opc parameter in pmic_arb_write_cmd() function is defined with type
u8 and it's always greater than or equal to 0. Checking that it's not
less than 0 is redundant and it can cause a forbidden warning during
compilation. Remove the check.

Signed-off-by: Fenglin Wu 
Signed-off-by: Kiran Gunda 
Reviewed-by: Stephen Boyd 
Signed-off-by: Greg Kroah-Hartman

spmi: pmic-arb: add support for HW version 5

2017-08-28T11:51:19+00:00

Add support for version 5 of the SPMI PMIC arbiter.  It utilizes
different offsets for registers than those found on version 3.
Also, the procedure to determine if writing and IRQ access is
allowed for a given PPID changes for version 5.

Signed-off-by: David Collins 
Signed-off-by: Kiran Gunda 
Reviewed-by: Stephen Boyd 
Signed-off-by: Greg Kroah-Hartman

spmi: pmic-arb: fix a possible null pointer dereference

2017-08-28T11:51:19+00:00

If "core" memory resource is not specified, then the driver could
end up dereferencing a null pointer. Fix this issue.

Signed-off-by: Kiran Gunda 
Reviewed-by: Stephen Boyd 
Signed-off-by: Greg Kroah-Hartman

spmi: pmic-arb: return __iomem pointer instead of offset

2017-08-28T11:51:19+00:00

Modify the pmic_arb version ops to return an __iomem pointer
to the address instead of an offset. That way we do not need to
care about the base address changes in the new HW version.

Signed-off-by: Kiran Gunda 
Reviewed-by: Stephen Boyd 
Signed-off-by: Greg Kroah-Hartman

spmi: pmic-arb: use irq_chip callback to set spmi irq wakeup capability

2017-08-28T11:51:19+00:00

Currently the driver sets the pmic arbiter core interrupt as wakeup capable
irrespective of the child irqs which causes the system to wakeup
unnecessarily. To fix this, set the core interrupt as wakeup capable
only if any of the child irqs request for it. Do this by marking it as
wakeup capable in the irq_set_wake callback.

Signed-off-by: Kiran Gunda 
Reviewed-by: Stephen Boyd 
Signed-off-by: Greg Kroah-Hartman

spmi: pmic-arb: return the value instead of passing by pointer

2017-08-28T11:51:19+00:00

Returning the output value from a function, when it is possible, is the
better and cleaner way than passing it by the pointer. Hence, modify
the ppid_to_apid mapping function to return apid instead of passing
it by a pointer. While at it, pass the ppid as function parameter to
ppid_to_apid mapping function instead of passing the sid and addr.

Signed-off-by: Kiran Gunda 
Reviewed-by: Stephen Boyd 
Signed-off-by: Greg Kroah-Hartman