linux-stable.git/drivers/spi, branch linux-2.6.32.y

spi: fix parent-device reference leak

2016-01-29T21:12:54+00:00

commit 157f38f993919b648187ba341bfb05d0e91ad2f6 upstream.

Fix parent-device reference leak due to SPI-core taking an unnecessary
reference to the parent when allocating the master structure, a
reference that was never released.

Note that driver core takes its own reference to the parent when the
master device is registered.

Fixes: 49dce689ad4e ("spi doesn't need class_device")
Signed-off-by: Johan Hovold 
Signed-off-by: Mark Brown 
Signed-off-by: Ben Hutchings 
(cherry picked from commit 40ddf30ca43b50019304303949c9b2676cfbd820)
Signed-off-by: Willy Tarreau

spi: spidev: fix possible arithmetic overflow for multi-transfer message

2015-05-24T08:10:51+00:00

commit f20fbaad7620af2df36a1f9d1c9ecf48ead5b747 upstream.

`spidev_message()` sums the lengths of the individual SPI transfers to
determine the overall SPI message length.  It restricts the total
length, returning an error if too long, but it does not check for
arithmetic overflow.  For example, if the SPI message consisted of two
transfers and the first has a length of 10 and the second has a length
of (__u32)(-1), the total length would be seen as 9, even though the
second transfer is actually very long.  If the second transfer specifies
a null `rx_buf` and a non-null `tx_buf`, the `copy_from_user()` could
overrun the spidev's pre-allocated tx buffer before it reaches an
invalid user memory address.  Fix it by checking that neither the total
nor the individual transfer lengths exceed the maximum allowed value.

Thanks to Dan Carpenter for reporting the potential integer overflow.

Signed-off-by: Ian Abbott 
Signed-off-by: Mark Brown 
[Ian Abbott: Note: original commit compares the lengths to INT_MAX
 instead of bufsiz due to changes in earlier commits.]
Signed-off-by: Ben Hutchings 
(cherry picked from commit 7499401e4a0b01ee43cff768de4ca630dcd0bc64)
Signed-off-by: Willy Tarreau

SPI: spi_txx9: Fix bit rate calculation

2009-12-02T23:58:32+00:00

TXx9 SPI bit rate is calculated by:
        fBR = (spi-baseclk) / (n + 1)
Fix calculation of min_speed_hz, max_speed_hz and n.

Signed-off-by: Atsushi Nemoto 
Signed-off-by: Ralf Baechle

spi: error status should be negative

2009-11-18T01:40:32+00:00

Return a negative error value instead of a positive

Signed-off-by: Roel Kluin 
Cc: David Brownell 
Cc: dmitry pervushin 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ARM: 5741/1: pl022: fix peripheral id for ST vendor

2009-10-05T16:55:55+00:00

This fixes the wrong peripheral id being
used in pl022 driver for ST derivative.

Signed-off-by: srinidhi kasagar 
Signed-off-by: Russell King

spi-imx: strip down chipselect function to only drive the chipselect

2009-10-01T23:11:17+00:00

spi_imx_chipselect() made things that should be (and mostly are) done by
spi_imx_setupxfer.  Only setting the tx and rx functions was missing.

Signed-off-by: Uwe Kleine-König 
Acked-by: Sascha Hauer 
Cc: David Brownell 
Cc: Guennadi Liakhovetski 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

spi-imx: initialize complete config struct

2009-10-01T23:11:17+00:00

Otherwise the config function uses random data from the stack.  This
didn't stick out because config is called once more in the chipselect
function with correct parameters.

Signed-off-by: Uwe Kleine-König 
Acked-by: Sascha Hauer 
Cc: David Brownell 
Cc: Guennadi Liakhovetski 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

spi-imx: no need to assert bits_per_word being initialized

2009-10-01T23:11:16+00:00

spi_imx_setup() is only called by spi_setup().  The latter does the
initialization already.

Signed-off-by: Uwe Kleine-König 
Acked-by: Sascha Hauer 
Cc: David Brownell 
Cc: Guennadi Liakhovetski 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

spi-imx: setup mode_bits we can handle

2009-10-01T23:11:16+00:00

Signed-off-by: Sascha Hauer 
Signed-off-by: Uwe Kleine-König 
Cc: David Brownell 
Cc: Guennadi Liakhovetski 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

spi-imx: fix initial chipselect settings

2009-10-01T23:11:16+00:00

We can only setup the gpio pins in spi_setup time when we know the
SPI_CS_HIGH setting.

Signed-off-by: Sascha Hauer 
Signed-off-by: Uwe Kleine-König 
Cc: David Brownell 
Cc: Guennadi Liakhovetski 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds