linux-stable.git/drivers/soundwire/stream.c, branch v5.3

Merge tag 'soundwire-5.3-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/soundwire into char-misc-next

2019-07-05T06:15:08+00:00

Vinod writes:

soundwire updates for v5.3-rc1

Updates for 5.3 include:
 - module_sdw_driver macro for drivers
 - Documentation updates for code-blocks
 - Improvement from Pierre on intel and cadence driver
 - Clarification of DisCo properties and updates

* tag 'soundwire-5.3-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/soundwire:
  soundwire: add module_sdw_driver helper macro
  docs: soundwire: locking: fix tags for a code-block
  soundwire: intel_init: add checks on link numbers
  soundwire: fix typo in comments
  soundwire: Intel: add log for number of PCM and PDM PDIs
  soundwire: cadence_master: check the number of bidir PDIs
  soundwire: cadence_master: log Slave status mask on errors
  soundwire: cadence_master: use rate_limited dynamic debug
  soundwire: rename/clarify MIPI DisCo properties
  soundwire: clarify comment
  soundwire: mipi-disco: fix clock stop modes
  soundwire: rename 'freq' fields
  soundwire: mipi-disco: remove master_count property for masters
  soundwire: remove master data port properties
  soundwire: add port-related definitions
  soundwire: mipi_disco: fix master/link error
  soundwire: intel: filter SoundWire controller device search
  soundwire: cdns: Fix compilation error on arm64

soundwire: stream: fix bad unlock balance

2019-06-06T17:16:04+00:00

the msg lock is taken for multi-link cases only but released
unconditionally, leading to an unlock balance warning for single-link usages
This patch fixes this.

 =====================================
 WARNING: bad unlock balance detected!
 5.1.0-16506-gc1c383a6f0a2-dirty #1523 Tainted: G        W
 -------------------------------------
 aplay/2954 is trying to release lock (&bus->msg_lock) at:
 do_bank_switch+0x21c/0x480
 but there are no more locks to release!

Signed-off-by: Srinivas Kandagatla 
Acked-by: Pierre-Louis Bossart 
Acked-by: Sanyog Kale 
[vkoul: edited the change log as suggested by Pierre]
Signed-off-by: Vinod Koul

soundwire: rename/clarify MIPI DisCo properties

2019-05-27T05:23:00+00:00

The existing definitions are ambiguous and possibly misleading.

For DP0, 'flow-control' is only relevant for the BRA protocol and
should not be confused with async modes explicitly not supported for
DP0, add prefix to follow MIPI DisCo definition

The use of 'device_interrupts' is also questionable. The MIPI
SoundWire spec defines Slave-, DP0- and DPN-level
implementation-defined interrupts. Using the 'device' prefix in the
last two cases is misleading, not only is the term 'device' overloaded
but these properties are only valid at the DP0 and DPn levels. Rename
to follow the MIPI definitions, no need to be creative here.

Signed-off-by: Pierre-Louis Bossart 
Signed-off-by: Vinod Koul

soundwire: rename 'freq' fields

2019-05-27T05:23:00+00:00

Rename all fields with 'freq' as 'clk_freq' to follow the MIPI
specification and avoid confusion between bus clock and audio clocks.

No functionality change.

Signed-off-by: Pierre-Louis Bossart 
Signed-off-by: Vinod Koul

soundwire: stream: fix out of boundary access on port properties

2019-05-27T05:04:12+00:00

Assigning local iterator to array element and using it again for
indexing would cross the array boundary.
Fix this by directly referring array element without using the local
variable.

Signed-off-by: Srinivas Kandagatla 
Acked-by: Pierre-Louis Bossart 
Signed-off-by: Vinod Koul

soundwire: add a blank line between functions

2019-05-02T15:17:51+00:00

For improving code readability it helps to have a blank line between
function so add when missing.

Checkpatch complains:
CHECK: Please use a blank line after function/struct/union/enum
declarations

Signed-off-by: Vinod Koul 
Signed-off-by: Greg Kroah-Hartman

soundwire: fix more typos

2019-05-02T15:17:51+00:00

Found few more typos in the code, fix them

CHECK: 'and and' may be misspelled - perhaps 'and'?
CHECK: 'smaple' may be misspelled - perhaps 'sample'?

Signed-off-by: Vinod Koul 
Signed-off-by: Greg Kroah-Hartman

soundwire: more alignment fixes

2019-05-02T15:17:51+00:00

Found few more issues reported checkpatch on code alignment so fix those
as well in the soundwire core.

Signed-off-by: Vinod Koul 
Signed-off-by: Greg Kroah-Hartman

soundwire: remove empty line before/after braces

2019-05-02T15:17:50+00:00

Linux code style doesn't expect empty lines before or after braces and
gives warning:

CHECK: Blank lines aren't necessary after an open brace '{'
CHECK: Blank lines aren't necessary before a close brace '}'

Fix these instances in soundwire core

Signed-off-by: Vinod Koul 
Signed-off-by: Greg Kroah-Hartman

soundwire: add missing newlines in dynamic debug logs

2019-05-02T15:16:29+00:00

For some reason the newlines are not used everywhere. Fix as needed.

Reported-by: Joe Perches 
Reviewed-by: Takashi Iwai 
Signed-off-by: Pierre-Louis Bossart 
Signed-off-by: Greg Kroah-Hartman