linux-stable.git/drivers/soc/fsl, branch linux-4.9.y

soc: fsl: qe: Check of ioremap return value

2022-03-08T18:00:58+00:00

[ Upstream commit a222fd8541394b36b13c89d1698d9530afd59a9c ]

As the possible failure of the ioremap(), the par_io could be NULL.
Therefore it should be better to check it and return error in order to
guarantee the success of the initiation.
But, I also notice that all the caller like mpc85xx_qe_par_io_init() in
`arch/powerpc/platforms/85xx/common.c` don't check the return value of
the par_io_init().
Actually, par_io_init() needs to check to handle the potential error.
I will submit another patch to fix that.
Anyway, par_io_init() itsely should be fixed.

Fixes: 7aa1aa6ecec2 ("QE: Move QE from arch/powerpc to drivers/soc")
Signed-off-by: Jiasheng Jiang 
Signed-off-by: Li Yang 
Signed-off-by: Sasha Levin

soc/fsl: qbman: fix conflicting alignment attributes

2021-04-16T09:59:08+00:00

[ Upstream commit 040f31196e8b2609613f399793b9225271b79471 ]

When building with W=1, gcc points out that the __packed attribute
on struct qm_eqcr_entry conflicts with the 8-byte alignment
attribute on struct qm_fd inside it:

drivers/soc/fsl/qbman/qman.c:189:1: error: alignment 1 of 'struct qm_eqcr_entry' is less than 8 [-Werror=packed-not-aligned]

I assume that the alignment attribute is the correct one, and
that qm_eqcr_entry cannot actually be unaligned in memory,
so add the same alignment on the outer struct.

Fixes: c535e923bb97 ("soc/fsl: Introduce DPAA 1.x QMan device driver")
Signed-off-by: Arnd Bergmann 
Link: https://lore.kernel.org/r/20210323131530.2619900-1-arnd@kernel.org'
Signed-off-by: Arnd Bergmann 
Signed-off-by: Sasha Levin

soc/fsl/qe: Fix an error code in qe_pin_request()

2020-01-29T09:24:20+00:00

[ Upstream commit 5674a92ca4b7e5a6a19231edd10298d30324cd27 ]

We forgot to set "err" on this error path.

Fixes: 1a2d397a6eb5 ("gpio/powerpc: Eliminate duplication of of_get_named_gpio_flags()")
Signed-off-by: Dan Carpenter 
Signed-off-by: Li Yang 
Signed-off-by: Sasha Levin

soc: fsl: qbman: avoid race in clearing QMan interrupt

2019-03-13T21:04:58+00:00

[ Upstream commit 89857a8a5c89a406b967ab2be7bd2ccdbe75e73d ]

By clearing all interrupt sources, not only those that
already occurred, the existing code may acknowledge by
mistake interrupts that occurred after the code checks
for them.

Signed-off-by: Madalin Bucur 
Signed-off-by: Roy Pledge 
Signed-off-by: Li Yang 
Signed-off-by: Sasha Levin

soc: fsl: qe: Fix copy/paste bug in ucc_get_tdm_sync_shift()

2018-11-10T15:42:42+00:00

[ Upstream commit 96fc74333f84cfdf8d434c6c07254e215e2aad00 ]

There is a copy and paste bug so we accidentally use the RX_ shift when
we're in TX_ mode.

Fixes: bb8b2062aff3 ("fsl/qe: setup clock source for TDM mode")
Signed-off-by: Dan Carpenter 
Signed-off-by: Zhao Qiang 
Signed-off-by: Li Yang 
(cherry picked from commit 3cb31b634052ed458922e0c8e2b4b093d7fb60b9)
Signed-off-by: Olof Johansson 
Signed-off-by: Sasha Levin

soc: fsl: qbman: qman: avoid allocating from non existing gen_pool

2018-11-10T15:42:42+00:00

[ Upstream commit 64e9e22e68512da8df3c9a7430f07621e48db3c2 ]

If the qman driver didn't probe, calling qman_alloc_fqid_range,
qman_alloc_pool_range or qman_alloc_cgrid_range (as done in dpaa_eth) will
pass a NULL pointer to gen_pool_alloc, leading to a NULL pointer
dereference.

Signed-off-by: Alexandre Belloni 
Reviewed-by: Roy Pledge 
Signed-off-by: Li Yang 
(cherry picked from commit f72487a2788aa70c3aee1d0ebd5470de9bac953a)
Signed-off-by: Olof Johansson 
Signed-off-by: Sasha Levin

soc/fsl/qbman: fix issue in qman_delete_cgr_safe()

2018-03-31T16:11:35+00:00

[ Upstream commit 96f413f47677366e0ae03797409bfcc4151dbf9e ]

The wait_for_completion() call in qman_delete_cgr_safe()
was triggering a scheduling while atomic bug, replacing the
kthread with a smp_call_function_single() call to fix it.

Signed-off-by: Madalin Bucur 
Signed-off-by: Roy Pledge 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

soc/fsl/qe: round brg_freq to 1kHz granularity

2018-03-24T10:00:19+00:00

[ Upstream commit 2ccf80b7566cc035d903dd0ac5d7ebd25c2c1060 ]

Because of integer computation rounding in u-boot (that sets the QE
brg-frequency DTS prop), the clk value is 99999999 Hz even though it is
100 MHz.

When setting brg clks that are exact divisors of 100 MHz, this small
differnce plays a role and can result in lower clks to be output (for
instance 20 MHz - divide by 5 - results in 16.666 MHz - divide by 6).

This patch fixes that by "forcing" the brg_clk to the nearest kHz when
the difference is below 2 integer rounding errors (i.e. 4).

Signed-off-by: Valentin Longchamp 
Signed-off-by: Scott Wood 
Signed-off-by: Sasha Levin 
Signed-off-by: Greg Kroah-Hartman

arch/powerpc: Add CONFIG_FSL_DPAA to corenetXX_smp_defconfig

2016-09-25T07:39:01+00:00

Enable the drivers on the powerpc arch.

Signed-off-by: Roy Pledge 
Signed-off-by: Claudiu Manoil 
Signed-off-by: Scott Wood

soc/qman: Add self-test for QMan driver

2016-09-25T07:39:00+00:00

Add self tests for the DPAA 1.x Queue Manager driver. The tests
ensure that the driver can properly enqueue and dequeue to/from
frame queues using the QMan portal infrastructure.

Signed-off-by: Roy Pledge 
Signed-off-by: Claudiu Manoil 
Signed-off-by: Scott Wood