linux-stable.git/drivers/sh, branch linux-5.10.y

sh: clk: Fix clk_enable() to return 0 on NULL clk

2025-01-09T12:24:54+00:00

commit ff30bd6a6618e979b16977617371c0f28a95036e upstream.

On SH, devm_clk_get_optional_enabled() fails with -EINVAL if the clock
is not found.  This happens because __devm_clk_get() assumes it can pass
a NULL clock pointer (as returned by clk_get_optional()) to the init()
function (clk_prepare_enable() in this case), while the SH
implementation of clk_enable() considers that an error.

Fix this by making the SH clk_enable() implementation return zero
instead, like the Common Clock Framework does.

Reported-by: John Paul Adrian Glaubitz 
Signed-off-by: Geert Uytterhoeven 
Tested-by: John Paul Adrian Glaubitz 
Acked-by: Stephen Boyd 
Link: https://lore.kernel.org/r/b53e6b557b4240579933b3359dda335ff94ed5af.1675354849.git.geert+renesas@glider.be
Signed-off-by: John Paul Adrian Glaubitz 
Signed-off-by: Greg Kroah-Hartman

sh: intc: Fix use-after-free bug in register_intc_controller()

2024-12-14T18:48:16+00:00

[ Upstream commit 63e72e551942642c48456a4134975136cdcb9b3c ]

In the error handling for this function, d is freed without ever
removing it from intc_list which would lead to a use after free.
To fix this, let's only add it to the list after everything has
succeeded.

Fixes: 2dcec7a988a1 ("sh: intc: set_irq_wake() support")
Signed-off-by: Dan Carpenter 
Reviewed-by: John Paul Adrian Glaubitz 
Signed-off-by: John Paul Adrian Glaubitz 
Signed-off-by: Sasha Levin

maple: fix wrong return value of maple_bus_init().

2021-11-26T09:39:12+00:00

[ Upstream commit bde82ee391fa6d3ad054313c4aa7b726d32515ce ]

If KMEM_CACHE or maple_alloc_dev failed, the maple_bus_init() will return 0
rather than error, because the retval is not changed after KMEM_CACHE or
maple_alloc_dev failed.

Fixes: 17be2d2b1c33 ("sh: Add maple bus support for the SEGA Dreamcast.")
Reported-by: Hulk Robot 
Signed-off-by: Lu Wei 
Acked-by: John Paul Adrian Glaubitz 
Signed-off-by: Rich Felker 
Signed-off-by: Sasha Levin

iomap: constify ioreadX() iomem argument (as in generic implementation)

2020-08-15T02:56:57+00:00

Patch series "iomap: Constify ioreadX() iomem argument", v3.

The ioread8/16/32() and others have inconsistent interface among the
architectures: some taking address as const, some not.

It seems there is nothing really stopping all of them to take pointer to
const.

This patch (of 4):

The ioreadX() and ioreadX_rep() helpers have inconsistent interface.  On
some architectures void *__iomem address argument is a pointer to const,
on some not.

Implementations of ioreadX() do not modify the memory under the address so
they can be converted to a "const" version for const-safety and
consistency among architectures.

[krzk@kernel.org: sh: clk: fix assignment from incompatible pointer type for ioreadX()]
  Link: http://lkml.kernel.org/r/20200723082017.24053-1-krzk@kernel.org
[akpm@linux-foundation.org: fix drivers/mailbox/bcm-pdc-mailbox.c]
  Link: http://lkml.kernel.org/r/202007132209.Rxmv4QyS%25lkp@intel.com

Suggested-by: Geert Uytterhoeven 
Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Andrew Morton 
Reviewed-by: Geert Uytterhoeven 
Reviewed-by: Arnd Bergmann 
Cc: Richard Henderson 
Cc: Ivan Kokshaysky 
Cc: Matt Turner 
Cc: "James E.J. Bottomley" 
Cc: Helge Deller 
Cc: Michael Ellerman 
Cc: Benjamin Herrenschmidt 
Cc: Paul Mackerras 
Cc: Yoshinori Sato 
Cc: Rich Felker 
Cc: Kalle Valo 
Cc: "David S. Miller" 
Cc: Jakub Kicinski 
Cc: Dave Jiang 
Cc: Jon Mason 
Cc: Allen Hubbe 
Cc: "Michael S. Tsirkin" 
Cc: Jason Wang 
Link: http://lkml.kernel.org/r/20200709072837.5869-1-krzk@kernel.org
Link: http://lkml.kernel.org/r/20200709072837.5869-2-krzk@kernel.org
Signed-off-by: Linus Torvalds

sh: clkfwk: remove r8/r16/r32

2020-08-15T02:56:57+00:00

SH will get below warning

${LINUX}/drivers/sh/clk/cpg.c: In function 'r8':
${LINUX}/drivers/sh/clk/cpg.c:41:17: warning: passing argument 1 of 'ioread8'
 discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
  return ioread8(addr);
                 ^~~~
In file included from ${LINUX}/arch/sh/include/asm/io.h:21,
                 from ${LINUX}/include/linux/io.h:13,
                 from ${LINUX}/drivers/sh/clk/cpg.c:14:
${LINUX}/include/asm-generic/iomap.h:29:29: note: expected 'void *' but
argument is of type 'const void *'
 extern unsigned int ioread8(void __iomem *);
                             ^~~~~~~~~~~~~~

We don't need "const" for r8/r16/r32.  And we don't need r8/r16/r32
themselvs.  This patch cleanup these.

Signed-off-by: Kuninori Morimoto 
Signed-off-by: Andrew Morton 
Cc: Alan Modra 
Cc: Bin Meng 
Cc: Chen Zhou 
Cc: Geert Uytterhoeven 
Cc: John Paul Adrian Glaubitz 
Cc: Krzysztof Kozlowski 
Cc: Rich Felker 
Cc: Romain Naour 
Cc: Sam Ravnborg 
Cc: Yoshinori Sato 
X-MARC-Message: https://marc.info/?l=linux-renesas-soc&m=157852973916903
Signed-off-by: Linus Torvalds

remove ioremap_nocache and devm_ioremap_nocache

2020-01-06T08:45:59+00:00

ioremap has provided non-cached semantics by default since the Linux 2.6
days, so remove the additional ioremap_nocache interface.

Signed-off-by: Christoph Hellwig 
Acked-by: Arnd Bergmann

sh/intc: Use pr_warn instead of pr_warning

2019-10-18T13:01:55+00:00

As said in commit f2c2cbcc35d4 ("powerpc: Use pr_warn instead of
pr_warning"), removing pr_warning so all logging messages use a
consistent _warn style. Let's do it.

Link: http://lkml.kernel.org/r/20191018031850.48498-22-wangkefeng.wang@huawei.com
To: linux-kernel@vger.kernel.org
Cc: Yoshinori Sato 
Cc: Rich Felker 
Signed-off-by: Kefeng Wang 
Reviewed-by: Sergey Senozhatsky 
Signed-off-by: Petr Mladek

treewide: Add SPDX license identifier - Makefile/Kconfig

2019-05-21T08:50:46+00:00

Add SPDX license identifiers to all Make/Kconfig files which:

 - Have no license information of any form

These files fall under the project license, GPL v2 only. The resulting SPDX
license identifier is:

  GPL-2.0-only

Signed-off-by: Thomas Gleixner 
Signed-off-by: Greg Kroah-Hartman

treewide: replace #include with #include

2019-05-15T02:52:52+00:00

Since commit dccd2304cc90 ("ARM: 7430/1: sizes.h: move from asm-generic
to "),  and  are just
wrappers of .

This commit replaces all  and  to
prepare for the removal.

Link: http://lkml.kernel.org/r/1553267665-27228-1-git-send-email-yamada.masahiro@socionext.com
Signed-off-by: Masahiro Yamada 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

sh: introduce a sh_cacheop_vaddr helper

2018-08-02T11:54:06+00:00

And use it in the maple bus code to avoid a dma API dependency.

Signed-off-by: Christoph Hellwig 
Acked-by: Yoshinori Sato