linux-stable.git/drivers/scsi, branch v4.1.41

scsi: mac_scsi: Fix MAC_SCSI=m option when SCSI=m

2017-06-13T13:29:20+00:00

[ Upstream commit 2559a1ef688f933835912c731bed2254146a9b04 ]

The mac_scsi driver still gets disabled when SCSI=m. This should have
been fixed back when I enabled the tristate but I didn't see the bug.

Fixes: 6e9ae6d560e1 ("[PATCH] mac_scsi: Add module option to Kconfig")
Signed-off-by: Finn Thain 
Signed-off-by: Martin K. Petersen 
Signed-off-by: Sasha Levin

scsi: sd: Fix capacity calculation with 32-bit sector_t

2017-05-17T19:08:21+00:00

[ Upstream commit 7c856152cb92f8eee2df29ef325a1b1f43161aff ]

We previously made sure that the reported disk capacity was less than
0xffffffff blocks when the kernel was not compiled with large sector_t
support (CONFIG_LBDAF). However, this check assumed that the capacity
was reported in units of 512 bytes.

Add a sanity check function to ensure that we only enable disks if the
entire reported capacity can be expressed in terms of sector_t.

Cc: 
Reported-by: Steve Magnani 
Cc: Bart Van Assche 
Reviewed-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen 
Signed-off-by: Sasha Levin

scsi: sr: Sanity check returned mode data

2017-05-17T19:08:21+00:00

[ Upstream commit a00a7862513089f17209b732f230922f1942e0b9 ]

Kefeng Wang discovered that old versions of the QEMU CD driver would
return mangled mode data causing us to walk off the end of the buffer in
an attempt to parse it. Sanity check the returned mode sense data.

Cc: 
Reported-by: Kefeng Wang 
Tested-by: Kefeng Wang 
Signed-off-by: Martin K. Petersen 
Signed-off-by: Sasha Levin

scsi: libsas: fix ata xfer length

2017-05-17T19:07:02+00:00

[ Upstream commit 9702c67c6066f583b629cf037d2056245bb7a8e6 ]

The total ata xfer length may not be calculated properly, in that we do
not use the proper method to get an sg element dma length.

According to the code comment, sg_dma_len() should be used after
dma_map_sg() is called.

This issue was found by turning on the SMMUv3 in front of the hisi_sas
controller in hip07. Multiple sg elements were being combined into a
single element, but the original first element length was being use as
the total xfer length.

Cc: 
Fixes: ff2aeb1eb64c8a4770a6 ("libata: convert to chained sg")
Signed-off-by: John Garry 
Signed-off-by: Martin K. Petersen 
Signed-off-by: Sasha Levin

scsi: sg: check length passed to SG_NEXT_CMD_LEN

2017-05-17T19:07:02+00:00

[ Upstream commit bf33f87dd04c371ea33feb821b60d63d754e3124 ]

The user can control the size of the next command passed along, but the
value passed to the ioctl isn't checked against the usable max command
size.

Cc: 
Signed-off-by: Peter Chang 
Acked-by: Douglas Gilbert 
Signed-off-by: Martin K. Petersen 
Signed-off-by: Sasha Levin

scsi: lpfc: Add shutdown method for kexec

2017-05-17T19:07:00+00:00

[ Upstream commit 85e8a23936ab3442de0c42da97d53b29f004ece1 ]

We see lpfc devices regularly fail during kexec. Fix this by adding a
shutdown method which mirrors the remove method.

Cc: 
Signed-off-by: Anton Blanchard 
Reviewed-by: Mauricio Faria de Oliveira 
Tested-by: Mauricio Faria de Oliveira 
Signed-off-by: Martin K. Petersen 
Signed-off-by: Sasha Levin

scsi: libiscsi: add lock around task lists to fix list corruption regression

2017-05-17T19:07:00+00:00

[ Upstream commit 6f8830f5bbab16e54f261de187f3df4644a5b977 ]

There's a rather long standing regression from the commit "libiscsi:
Reduce locking contention in fast path"

Depending on iSCSI target behavior, it's possible to hit the case in
iscsi_complete_task where the task is still on a pending list
(!list_empty(&task->running)).  When that happens the task is removed
from the list while holding the session back_lock, but other task list
modification occur under the frwd_lock.  That leads to linked list
corruption and eventually a panicked system.

Rather than back out the session lock split entirely, in order to try
and keep some of the performance gains this patch adds another lock to
maintain the task lists integrity.

Major enterprise supported kernels have been backing out the lock split
for while now, thanks to the efforts at IBM where a lab setup has the
most reliable reproducer I've seen on this issue.  This patch has been
tested there successfully.

Signed-off-by: Chris Leech 
Fixes: 659743b02c41 ("[SCSI] libiscsi: Reduce locking contention in fast path")
Reported-by: Prashantha Subbarao 
Reviewed-by: Guilherme G. Piccoli 
Cc:  # v3.15+
Signed-off-by: Martin K. Petersen 
Signed-off-by: Sasha Levin

scsi: aacraid: Reorder Adapter status check

2017-05-17T19:06:59+00:00

[ Upstream commit c421530bf848604e97d0785a03b3fe2c62775083 ]

The driver currently checks the SELF_TEST_FAILED first and then
KERNEL_PANIC next. Under error conditions(boot code failure) both
SELF_TEST_FAILED and KERNEL_PANIC can be set at the same time.

The driver has the capability to reset the controller on an KERNEL_PANIC,
but not on SELF_TEST_FAILED.

Fixed by first checking KERNEL_PANIC and then the others.

Cc: stable@vger.kernel.org
Fixes: e8b12f0fb835223752 ([SCSI] aacraid: Add new code for PMC-Sierra's SRC base controller family)
Signed-off-by: Raghava Aditya Renukunta 
Reviewed-by: David Carroll 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen 
Signed-off-by: Sasha Levin

scsi: storvsc: properly handle SRB_ERROR when sense message is present

2017-05-16T03:16:18+00:00

[ Upstream commit bba5dc332ec2d3a685cb4dae668c793f6a3713a3 ]

When sense message is present on error, we should pass along to the upper
layer to decide how to deal with the error.
This patch fixes connectivity issues with Fiber Channel devices.

Signed-off-by: Long Li 
Reviewed-by: K. Y. Srinivasan 
Signed-off-by: K. Y. Srinivasan 
Cc: 
Signed-off-by: Martin K. Petersen 
Signed-off-by: Sasha Levin

scsi: storvsc: use tagged SRB requests if supported by the device

2017-05-16T03:16:12+00:00

[ Upstream commit 3cd6d3d9b1abab8dcdf0800224ce26daac24eea2 ]

Properly set SRB flags when hosting device supports tagged queuing.
This patch improves the performance on Fiber Channel disks.

Signed-off-by: Long Li 
Reviewed-by: K. Y. Srinivasan 
Signed-off-by: K. Y. Srinivasan 
Cc: 
Signed-off-by: Martin K. Petersen 
Signed-off-by: Sasha Levin