linux-stable.git/drivers/scsi, branch v3.9.8

tcm_qla2xxx: Fix residual for underrun commands that fail

2013-06-27T17:39:09+00:00

commit b5aff3d2747bea08b386edd070941a45611ffe51 upstream.

Suppose an initiator sends a DATA IN command with an allocation length
shorter than the FC transfer length -- we get a target message like

    TARGET_CORE[qla2xxx]: Expected Transfer Length: 256 does not match SCSI CDB Length: 0 for SAM Opcode: 0x12

In that case, the target core adjusts the data_length and sets
se_cmd->residual_count for the underrun.  But now suppose that command
fails and we end up in tcm_qla2xxx_queue_status() -- that function
unconditionally overwrites residual_count with the already adjusted
data_length, and the initiator will burp with a message like

    qla2xxx [0000:00:06.0]-301d:0: Dropped frame(s) detected (0x100 of 0x100 bytes).

Fix this by adding on to the existing underflow residual count instead.

Signed-off-by: Roland Dreier 
Cc: Giridhar Malavali 
Cc: Chad Dupuis 
Signed-off-by: Nicholas Bellinger 
Signed-off-by: Greg Kroah-Hartman

SCSI: ipr: Need to reset adapter after the 6th EEH error

2013-06-07T19:52:44+00:00

commit 96b04db9f2c16e77c31ef0e17e143da1e0cbfd78 upstream.

Add reset adapter after the 6th EEH errors in ipr driver. This triggers
the adapter reset via the PCI config space even when the slot is frozen.

Signed-off-by: Wen Xiong 
Acked-by: Brian King 
Signed-off-by: James Bottomley 
Signed-off-by: Greg Kroah-Hartman

SCSI: sd: fix array cache flushing bug causing performance problems

2013-05-19T18:38:23+00:00

commit 39c60a0948cc06139e2fbfe084f83cb7e7deae3b upstream.

Some arrays synchronize their full non volatile cache when the sd driver sends
a SYNCHRONIZE CACHE command.  Unfortunately, they can have Terrabytes of this
and we send a SYNCHRONIZE CACHE for every barrier if an array reports it has a
writeback cache.  This leads to massive slowdowns on journalled filesystems.

The fix is to allow userspace to turn off the writeback cache setting as a
temporary measure (i.e. without doing the MODE SELECT to write it back to the
device), so even though the device reported it has a writeback cache, the
user, knowing that the cache is non volatile and all they care about is
filesystem correctness, can turn that bit off in the kernel and avoid the
performance ruinous (and safety irrelevant) SYNCHRONIZE CACHE commands.

The way you do this is add a 'temporary' prefix when performing the usual
cache setting operations, so

echo temporary write through > /sys/class/scsi_disk//cache_type

Reported-by: Ric Wheeler 
Signed-off-by: James Bottomley 
Signed-off-by: Greg Kroah-Hartman

[SCSI] lpfc: fix potential NULL pointer dereference in lpfc_sli4_rq_put()

2013-04-11T21:17:15+00:00

The dereference to 'put_index' should be moved below the NULL test.

Signed-off-by: Wei Yongjun 
Acked-by: James Smart 
Signed-off-by: James Bottomley

[SCSI] libsas: fix handling vacant phy in sas_set_ex_phy()

2013-04-06T10:36:54+00:00

If a result of the SMP discover function is PHY VACANT,
the content of discover response structure (dr) is not valid.
It sometimes happens that dr->attached_sas_addr can contain
even SAS address of other phy. In such case an invalid phy
is created, what causes NULL pointer dereference during
destruction of expander's phys.

So if a result of SMP function is PHY VACANT, the content of discover
response structure (dr) must not be copied to phy structure.

This patch fixes the following bug:

BUG: unable to handle kernel NULL pointer dereference at 0000000000000030
IP: [] sysfs_find_dirent+0x12/0x90
Call Trace:
  [] sysfs_get_dirent+0x35/0x80
  [] sysfs_unmerge_group+0x1e/0xb0
  [] dpm_sysfs_remove+0x24/0x90
  [] device_del+0x44/0x1d0
  [] sas_rphy_delete+0x9/0x20 [scsi_transport_sas]
  [] sas_destruct_devices+0xe6/0x110 [libsas]
  [] process_one_work+0x16c/0x350
  [] worker_thread+0x17a/0x410
  [] kthread+0x96/0xa0
  [] kernel_thread_helper+0x4/0x10

Signed-off-by: Lukasz Dorau 
Signed-off-by: Pawel Baldysiak 
Reviewed-by: Maciej Patelczyk 
Cc: 
Signed-off-by: James Bottomley

[SCSI] ibmvscsi: Fix slave_configure deadlock

2013-04-06T10:35:51+00:00

No locks should be held when calling scsi_adjust_queue_depth
so drop the lock in slave_configure prior to calling it.

Signed-off-by: Brian King 
Acked-by: Robert Jennings 
Signed-off-by: James Bottomley

[SCSI] qla2xxx: Update the driver version to 8.04.00.13-k.

2013-04-06T10:32:32+00:00

Signed-off-by: Giridhar Malavali 
Signed-off-by: Saurav Kashyap 
Signed-off-by: James Bottomley

[SCSI] qla2xxx: Remove debug code that msleeps for random duration.

2013-04-06T10:31:46+00:00

Signed-off-by: Giridhar Malavali 
Signed-off-by: Saurav Kashyap 
Signed-off-by: James Bottomley

[SCSI] qla2xxx: Fix crash during firmware dump procedure.

2013-04-06T10:30:16+00:00

System crashes, in initiator mode operation, with
qla2xxx_copy_atioqueues() in stack trace when firmware dump is
attempted.

Check for atio_q_length alone does not indicate if atio_ring is
allocated, make explicit check of atio_ring to avoid the crash.

Applicable to ISP24xx, ISP25xx, ISP81xx & ISP83xx line of HBAs.

Signed-off-by: Arun Easi 
Signed-off-by: Saurav Kashyap 
Signed-off-by: James Bottomley

[SCSI] Revert "qla2xxx: Add setting of driver version string for vendor application."

2013-04-06T10:29:14+00:00

The original patch was not covering all the adapters and firmwares.

This commit reverts 3a11711ad00caebee07e262d188cea66f3473c38.

Signed-off-by: Joe Carnuccio 
Signed-off-by: Saurav Kashyap 
Signed-off-by: James Bottomley