linux-stable.git/drivers/scsi, branch linux-2.6.37.y

scsi_dh_alua: fix deadlock in stpg_endio

2011-03-23T19:50:33+00:00

commit ed0f36bc5719b25659b637f80ceea85494b84502 upstream.

The use of blk_execute_rq_nowait() implies __blk_put_request() is needed
in stpg_endio() rather than blk_put_request() -- blk_finish_request() is
called with queue lock already held.

Signed-off-by: Joseph Gruher 
Signed-off-by: Ilgu Hong 
Signed-off-by: Mike Snitzer 
Signed-off-by: James Bottomley 
Signed-off-by: Greg Kroah-Hartman

block: add @force_kblockd to __blk_run_queue()

2011-03-07T23:05:23+00:00

commit 1654e7411a1ad4999fe7890ef51d2a2bbb1fcf76 upstream.

__blk_run_queue() automatically either calls q->request_fn() directly
or schedules kblockd depending on whether the function is recursed.
blk-flush implementation needs to be able to explicitly choose
kblockd.  Add @force_kblockd.

All the current users are converted to specify %false for the
parameter and this patch doesn't introduce any behavior change.

stable: This is prerequisite for fixing ide oops caused by the new
        blk-flush implementation.

Signed-off-by: Tejun Heo 
Cc: Jan Beulich 
Cc: James Bottomley 
Signed-off-by: Jens Axboe 
Signed-off-by: Greg Kroah-Hartman

mpt2sas: Kernel Panic during Large Topology discovery

2011-02-17T23:14:01+00:00

commit 4224489f45b503f0a1f1cf310f76dc108f45689a upstream.

There was a configuration page timing out during the initial port
enable at driver load time. The port enable would fail, and this would
result in the driver unloading itself, meanwhile the driver was accessing
freed memory in another context resulting in the panic.  The fix is to
prevent access to freed memory once the driver had issued the diag reset
which woke up the sleeping port enable process.  The routine
_base_reset_handler was reorganized so the last sleeping process woken up was
the port_enable.

Signed-off-by: Kashyap Desai 
Signed-off-by: James Bottomley 
Signed-off-by: Greg Kroah-Hartman

mpt2sas: add missing initialization of scsih_cmds

2011-02-17T23:14:00+00:00

commit d685c262083dcd5fd98b7499b22a377a3225229c upstream.

Internal command scsih_cmds init is included in mpt2sas_base_attach.

Signed-off-by: Kashyap Desai 
Signed-off-by: James Bottomley 
Signed-off-by: Greg Kroah-Hartman

mpt2sas: Correct resizing calculation for max_queue_depth

2011-02-17T23:14:00+00:00

commit 11e1b961ab067ee3acaf723531da4d3f23e1d6f7 upstream.

The ioc->hba_queue_depth is not properly resized when the controller
firmware reports that it supports more outstanding IO than what can be fit
inside the reply descriptor pool depth. This is reproduced by setting the
controller global credits larger than 30,000. The bug results in an
incorrect sizing of the queues. The fix is to resize the queue_size by
dividing queue_diff by two.

Signed-off-by: Kashyap Desai 
Signed-off-by: James Bottomley 
Signed-off-by: Greg Kroah-Hartman

mpt2sas: Fix the race between broadcast asyn event and scsi command completion

2011-02-17T23:14:00+00:00

commit ec07a053597bdab51cbd23619f9f9f392712508a upstream.

False timeout after hard resets, there were two issues which leads
to timeout.
(1) Panic because of invalid memory access in the broadcast asyn
event processing routine due to a race between accessing the scsi command
pointer from broadcast asyn event processing thread and completing
the same scsi command from the interrupt context.
(2)  Broadcast asyn event notifcations are not handled due to events
ignored while the broadcast asyn event is activity being processed
from the event process kernel thread.

In addition, changed the ABRT_TASK_SET to ABORT_TASK in the
broadcast async event processing routine.   This is less disruptive to other
request that generate Broadcast Asyn Primitives besides target
reset. e.g clear reservations, microcode download,and mode select.

Signed-off-by: Kashyap Desai 
Signed-off-by: James Bottomley 
Signed-off-by: Greg Kroah-Hartman

mpt2sas: fix internal device reset for older firmware prior to MPI Rev K

2011-02-17T23:13:59+00:00

commit efe82a16bc0f9f9e1fc8fa706eb0309fcd57770a upstream.

The "internal device reset complete" event is not supported
for older firmware prior to MPI Rev K We added
a check in the driver so the "internal device reset" event is
ignored for older firmware.  When ignored, the tm_busy flag doesn't
get set nor cleared.  Without this fix, IO queues would be froozen
indefinetly after the "internal device reset" event, as the "complete" event
never sent to clear the flag.

Signed-off-by: Kashyap Desai 
Signed-off-by: James Bottomley 
Signed-off-by: Greg Kroah-Hartman

mpt2sas: Fix device removal handshake for zoned devices

2011-02-17T23:13:59+00:00

commit 4dc2757a2e9a9d1f2faee4fc6119276fc0061c16 upstream.

When zoning end devices, the driver is not sending device
removal handshake alogrithm to firmware. This results in controller
firmware not sending sas topology add events the next time the device is
added. The fix is the driver should be doing the device removal handshake
even though the PHYSTATUS_VACANT bit is set in the PhyStatus of the
event data. The current design is avoiding the handshake when the
VACANT bit is set in the phy status.

Signed-off-by: Kashyap Desai 
Signed-off-by: James Bottomley 
Signed-off-by: Greg Kroah-Hartman

mpt2sas: fix Integrated Raid unsynced on shutdown problem

2011-02-17T23:13:58+00:00

commit 3a9c913a3e57b170887d39456e04c18f2305ec67 upstream.

Issue:
IR shutdown(sending) and IR shutdown(complete) messages not
listed in /var/log/messages when driver is removed.

The driver needs to issue a MPI2_RAID_ACTION_SYSTEM_SHUTDOWN_INITIATED
request when the driver is unloaded so the IR metadata journal is updated.
If this request is not sent, then the volume would need a "check
consistency" issued on the next bootup if the volume was roamed from one
initiator to another. The current driver supports this feature only when the
system is rebooted, however this also need to be supported if the driver is
unloaded

Fix:
To fix this issue, the driver is going
to need to call the _scsih_ir_shutdown prior to reporting
the volumes missing from the OS, hence the device handles
are still present.

Signed-off-by: Kashyap Desai 
Signed-off-by: James Bottomley 
Signed-off-by: Greg Kroah-Hartman

libsas: fix runaway error handler problem

2011-02-17T23:13:58+00:00

commit 9ee91f7fb550a4c82f82d9818e42493484c754af upstream.

libsas makes use of scsi_schedule_eh() but forgets to clear the
host_eh_scheduled flag in its error handling routine.  Because of this,
the error handler thread never gets to sleep; it's constantly awake and
trying to run the error routine leading to console spew and inability to
run anything else (at least on a UP system).  The fix is to clear the
flag as we splice the work queue.

Signed-off-by: James Bottomley 
Signed-off-by: Greg Kroah-Hartman