linux-stable.git/drivers/scsi, branch linux-2.6.24.y

SCSI advansys: Fix bug in AdvLoadMicrocode

2008-03-24T18:48:30+00:00

commit: 951b62c11e86acf8c55d9828aa8c921575023c29

buf[i] can be up to 0xfd, so doubling it and assigning the result to an
unsigned char truncates the value.  Just use an unsigned int instead;
it's only a temporary.

Signed-off-by: Matthew Wilcox 
Signed-off-by: James Bottomley 
Signed-off-by: Chris Wright 
Signed-off-by: Greg Kroah-Hartman

SCSI: gdth: fix to internal commands execution

2008-03-24T18:47:41+00:00

commit: ee54cc6af95a7fa09da298493b853a9e64fa8abd

The recent patch named:
  [SCSI] gdth: !use_sg cleanup and use of scsi accessors

has done a bad job in handling internal commands issued by gdth_execute().

Internal commands are issued with device gdth_cmd_str ready made directly
to the card, without any mapping or translations of scsi commands. So here
I added a gdth_cmd_str pointer to the gdth_cmndinfo private structure which
is then copied directly to host.

following this patch is a cleanup that removes the home cooked accessors
and reverts them to regular scsi_cmnd accessors. Since they are not used
anymore. After review maybe the 2 patches should be squashed together.

FIXME: There is still a problem with gdth_get_info(). as reported there
   is a WARN_ON trigerd in dma_free_coherent() when doing:
   $ cat /proc/sys/gdth/0

Signed-off-by: Boaz Harrosh 
Tested-by: Joerg Dorchain: 
Tested-by: Stefan Priebe 
Tested-by: Jon Chelton 
Signed-off-by: James Bottomley 
Signed-off-by: Chris Wright 
Signed-off-by: Greg Kroah-Hartman

SCSI: gdth: bugfix for the at-exit problems

2008-03-24T18:47:41+00:00

commit: b31ddd31c266c2ad1b708cad0d3d8e0aa7fa2737

gdth_exit would first remove all cards then stop the timer
and would not sync with the timer function. This caused a crash
in gdth_timer() when module was unloaded.
So del_timer_sync the timer before we delete the cards.

also the reboot notifier function would crash. So clean
that up and fix the crashes.

Signed-off-by: Boaz Harrosh 
Tested-by: Joerg Dorchain: 
Tested-by: Stefan Priebe 
Tested-by: Jon Chelton 
Signed-off-by: James Bottomley 
Signed-off-by: Chris Wright 
Signed-off-by: Greg Kroah-Hartman

SCSI: fix BUG when sum(scatterlist) > bufflen

2008-03-24T18:47:38+00:00

commit: 4d2de3a50ce19af2008a90636436a1bf5b3b697b

When sending a SCSI command to a tape drive via the SCSI Generic (sg)
driver, if the command has a data transfer length more than
scatter_elem_sz (32 KB default) and not a multiple of 512, then I either
hit BUG_ON(!valid_dma_direction(direction)) in dma_unmap_sg() or else
the command never completes (depending on the LLDD).

When constructing scatterlists, the sg driver rounds up the scatterlist
element sizes to be a multiple of 512.  This can result in
sum(scatterlist lengths) > bufflen.  In this case, scsi_req_map_sg()
incorrectly sets bio->bi_size to sum(scatterlist lengths) rather than to
bufflen.  When the command completes, req_bio_endio() detects that
bio->bi_size != 0, and so it doesn't call bio_endio().  This causes the
command to be resubmitted, resulting in BUG_ON or the command never
completing.

This patch makes scsi_req_map_sg() set bio->bi_size to bufflen rather
than to sum(scatterlist lengths), which fixes the problem.

Signed-off-by: Tony Battersby 
Acked-by: Mike Christie 
Signed-off-by: James Bottomley 
Signed-off-by: Chris Wright 
Signed-off-by: Greg Kroah-Hartman

arcmsr: fix IRQs disabled warning spew

2008-03-24T18:47:31+00:00

As of 2.6.24, running the archttp passthrough daemon with the arcmsr
driver produces an endless spew of dma_free_coherent warnings:

	WARNING: at arch/x86/kernel/pci-dma_64.c:169 dma_free_coherent()

It turns out that coherent memory is not needed, so commit 76d78300 by
Nick Cheng  switched it to kmalloc (as well as
making a lot of other changes which have not been included here).

James Bottomley pointed out that the new kmalloc usage was also wrong,
I corrected this in commit 69e562c2.

This patch combines both of the above for the purpose of fixing 2.6.24.
details in http://bugs.gentoo.org/208493.

Signed-off-by: Daniel Drake 
Cc: Nick Cheng 
Cc: James Bottomley 
Signed-off-by: Chris Wright 
Signed-off-by: Greg Kroah-Hartman

SCSI advansys: fix overrun_buf aligned bug

2008-03-24T18:47:24+00:00

commit 7d5d408c77cee95d1380511de46b7a4c8dc2211d

struct asc_dvc_var needs overrun buffer to be placed on an 8 byte
boundary. advansys defines struct asc_dvc_var:

struct asc_dvc_var {
    ...
    uchar overrun_buf[ASC_OVERRUN_BSIZE] __aligned(8);

The problem is that struct asc_dvc_var is placed on
shost->hostdata. So if the hostdata is not on an 8 byte boundary, the
advansys crashes. The hostdata is placed on a sizeof(unsigned long)
boundary so the 8 byte boundary is not garanteed with x86_32.

With 2.6.23 and 2.6.24, the hostdata is on an 8 byte boundary by
chance, but with the current git, it's not.

This patch removes overrun_buf static array and use kzalloc.

Signed-off-by: FUJITA Tomonori 
Signed-off-by: James Bottomley 

FUJITA Tomonori notes:
  We thought that 2.6.24 doesn't have this bug, however it does.

Signed-off-by: Chris Wright 
Signed-off-by: Greg Kroah-Hartman

SCSI aic94xx: fix REQ_TASK_ABORT and REQ_DEVICE_RESET

2008-03-24T18:47:16+00:00

commit: cb84e2d2ff3b50c0da5a7604a6d8634294a00a01

This driver has been failing under heavy load with

aic94xx: escb_tasklet_complete: REQ_TASK_ABORT, reason=0x6
aic94xx: escb_tasklet_complete: Can't find task (tc=4) to abort!

The second message is because the driver fails to identify the task
it's being asked to abort.  On closer inpection, there's a thinko in
the for each task loop over pending tasks in both the REQ_TASK_ABORT
and REQ_DEVICE_RESET cases where it doesn't look at the task on the
pending list but at the one on the ESCB (which is always NULL).

Fix by looking at the right task.  Also add a print for the case where
the pending SCB doesn't have a task attached.

Not sure if this will fix all the problems, but it's a definite first
step.

Signed-off-by: James Bottomley 
Signed-off-by: Chris Wright 
Signed-off-by: Greg Kroah-Hartman

SCSI gdth: don't call pci_free_consistent under spinlock

2008-03-24T18:47:15+00:00

commit: ff83efacf2b77a1fe8942db6613825a4b80ee5e2

The spinlock is held over too large a region: pscratch is a permanent
address (it's allocated at boot time and never changes).  All you need
the smp lock for is mediating the scratch in use flag, so fix this by
moving the spinlock into the case where we set the pscratch_busy flag
to false.

Signed-off-by: James Bottomley 
Signed-off-by: Chris Wright 
Signed-off-by: Greg Kroah-Hartman

SCSI ips: fix data buffer accessors conversion bug

2008-03-24T18:47:14+00:00

commit: 2b28a4721e068ac89bd5435472723a1bc44442fe

This fixes a bug that can't handle a passthru command with more than
two sg entries.

Big thanks to Tim Pepper for debugging the problem.

Signed-off-by: FUJITA Tomonori 
Acked-by: Mark Salyzyn 
Signed-off-by: James Bottomley 
Signed-off-by: Chris Wright 
Signed-off-by: Greg Kroah-Hartman

SCSI ips: handle scsi_add_host() failure, and other err cleanups

2008-03-24T18:47:12+00:00

commit 2551a13e61d3c3df6c2da6de5a3ece78e6d67111

Signed-off-by: Jeff Garzik 
Acked-by: Mark Salyzyn 
Signed-off-by: Andrew Morton 
Signed-off-by: James Bottomley 

FUJITA Tomonori notes:
  It didn't intend to fix a critical bug, however, it turned out that it
  does. Without this patch, the ips driver in 2.6.23 and 2.6.24 doesn't
  work at all. You can find the more details at the following thread:

  http://marc.info/?t=120293911900023&r=1&w=2

Signed-off-by: Chris Wright 
Signed-off-by: Greg Kroah-Hartman