linux-stable.git/drivers/scsi/lpfc, branch linux-5.2.y

scsi: lpfc: Mitigate high memory pre-allocation by SCSI-MQ

2019-09-10T09:35:20+00:00

[ Upstream commit 77ffd3465ba837e9dc714e17b014e77b2eae765a ]

When SCSI-MQ is enabled, the SCSI-MQ layers will do pre-allocation of MQ
resources based on shost values set by the driver. In newer cases of the
driver, which attempts to set nr_hw_queues to the cpu count, the
multipliers become excessive, with a single shost having SCSI-MQ
pre-allocation reaching into the multiple GBytes range.  NPIV, which
creates additional shosts, only multiply this overhead. On lower-memory
systems, this can exhaust system memory very quickly, resulting in a system
crash or failures in the driver or elsewhere due to low memory conditions.

After testing several scenarios, the situation can be mitigated by limiting
the value set in shost->nr_hw_queues to 4. Although the shost values were
changed, the driver still had per-cpu hardware queues of its own that
allowed parallelization per-cpu.  Testing revealed that even with the
smallish number for nr_hw_queues for SCSI-MQ, performance levels remained
near maximum with the within-driver affiinitization.

A module parameter was created to allow the value set for the nr_hw_queues
to be tunable.

Signed-off-by: Dick Kennedy 
Signed-off-by: James Smart 
Reviewed-by: Ming Lei 
Reviewed-by: Ewan D. Milne 
Signed-off-by: Martin K. Petersen 
Signed-off-by: Sasha Levin

scsi: lpfc: Update lpfc version to 12.2.0.2

2019-05-14T00:32:50+00:00

Due to the couple of bug fixes, update lpfc version to 12.2.0.2

Signed-off-by: Dick Kennedy 
Signed-off-by: James Smart 
Tested-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen

scsi: lpfc: add check for loss of ndlp when sending RRQ

2019-05-14T00:32:50+00:00

There was a missing qualification of a valid ndlp structure when calling to
send an RRQ for an abort.  Add the check.

Signed-off-by: Dick Kennedy 
Signed-off-by: James Smart 
Tested-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen

scsi: lpfc: correct rcu unlock issue in lpfc_nvme_info_show

2019-05-14T00:32:50+00:00

Many of the exit cases were not releasing the rcu read lock.  Corrected the
exit paths.

Signed-off-by: Dick Kennedy 
Signed-off-by: James Smart 
Tested-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen

scsi: lpfc: resolve lockdep warnings

2019-05-14T00:32:49+00:00

There were a number of erroneous comments and incorrect older lockdep
checks that were causing a number of warnings.

Resolve the following:

 - Inconsistent lock state warnings in lpfc_nvme_info_show().

 - Fixed comments and code on sequences where ring lock is now held instead
   of hbalock.

 - Reworked calling sequences around lpfc_sli_iocbq_lookup(). Rather than
   locking prior to the routine and have routine guess on what lock, take
   the lock within the routine. The lockdep check becomes unnecessary.

 - Fixed comments and removed erroneous hbalock checks.

Signed-off-by: Dick Kennedy 
Signed-off-by: James Smart 
CC: Bart Van Assche 
Tested-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen

scsi: lpfc: Make lpfc_sli4_oas_verify static

2019-04-19T00:35:58+00:00

Fix sparse warning:

drivers/scsi/lpfc/lpfc_init.c:13091:1: warning:
 symbol 'lpfc_sli4_oas_verify' was not declared. Should it be static?

Signed-off-by: YueHaibing 
Acked-by: James Smart 
Signed-off-by: Martin K. Petersen

Merge branch '5.1/scsi-fixes' into 5.2/merge

2019-04-13T01:27:23+00:00

We have a few submissions for 5.2 that depend on fixes merged post
5.1-rc1. Merge the fixes branch into queue.

Signed-off-by: Martin K. Petersen

scsi: scsi_transport_fc: nvme: display FC-NVMe port roles

2019-04-13T00:09:34+00:00

Currently the FC-NVMe driver is leverating the SCSI FC transport class to
access the remote ports. Which means that all FC-NVMe remote ports will be
visible to the fc transport layer, but due to missing definitions the port
roles will always be 'unknown'.  This patch adds the missing definitions to
the fc transport class to that the port roles are correctly displayed.

Signed-off-by: Hannes Reinecke 
Reviewed-by: James Smart 
Reviewed-by: Ewan D. Milne 
Reviewed-by: Giridhar Malavali 
Reviewed-by: Himanshu Madhani 
Signed-off-by: Martin K. Petersen

scsi: lpfc: add support for posting FC events on FPIN reception

2019-04-09T01:29:16+00:00

This patch adds support to recognize FPIN ELS's that are received.  When
one is received, the fc transport will be called to handle the the FPIN.

Signed-off-by: James Smart 
Reviewed-by: Ewan D. Milne 
Signed-off-by: Martin K. Petersen

scsi: lpfc: Fix a recently introduced compiler warning

2019-04-09T01:26:11+00:00

This patch avoids that the following compiler warning is reported with
CONFIG_NVME_FC=n:

drivers/scsi/lpfc/lpfc_nvme.c:2140:1: warning: 'lpfc_nvme_lport_unreg_wait' defined but not used [-Wunused-function]
 lpfc_nvme_lport_unreg_wait(struct lpfc_vport *vport,
 ^~~~~~~~~~~~~~~~~~~~~~~~~~

Fixes: 3999df75bccb ("scsi: lpfc: Declare local functions static")
Cc: James Smart 
Signed-off-by: Bart Van Assche 
Acked-by: James Smart 
Signed-off-by: Martin K. Petersen