linux-stable.git/drivers/scsi/lpfc, branch linux-4.6.y

Revert "lpfc: Delete unnecessary checks before the function call mempool_destroy"

2016-06-08T01:23:37+00:00

commit d65c8fff867a6450c58ce31572e883148a445ddf upstream.

This reverts commit 9be321819c43417432a8376428b90fe3fe3a3510 which
caused a regression on hardware using the SLI3 interface.

Reported-by: Dick Kennedy 
Signed-off-by: Martin K. Petersen 
Signed-off-by: James Bottomley 
Signed-off-by: Greg Kroah-Hartman

lpfc: fix misleading indentation

2016-03-18T19:21:23+00:00

gcc-6 complains about the indentation of the lpfc_destroy_vport_work_array()
call in lpfc_online(), which clearly doesn't look right:

drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_online':
drivers/scsi/lpfc/lpfc_init.c:2880:3: warning: statement is indented as if it were guarded by... [-Wmisleading-indentation]
   lpfc_destroy_vport_work_array(phba, vports);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/lpfc/lpfc_init.c:2863:2: note: ...this 'if' clause, but it is not
  if (vports != NULL)
  ^~

Looking at the patch that introduced this code, it's clear that the
behavior is correct and the indentation is wrong.

This fixes the indentation and adds curly braces around the previous
if() block for clarity, as that is most likely what caused the code
to be misindented in the first place.

Signed-off-by: Arnd Bergmann 
Fixes: 549e55cd2a1b ("[SCSI] lpfc 8.2.2 : Fix locking around HBA's port_list")
Reviewed-by: Sebastian Herbszt 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Ewan D. Milne 
Signed-off-by: Martin K. Petersen

lpfc: fix missing zero termination in debugfs

2016-02-24T02:27:02+00:00

If you feed 32 bytes in then the kstrtoull() doesn't receive a terminated
string so will run off the end.

Signed-off-by: Alan Cox 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

lpfc: Add lockdep assertions

2016-02-24T02:27:02+00:00

Several functions in lpfc have comments stating that the function must
be called with the hbalock (or hostlock, or ringlock) held. Add
lockdep_assert_held() annotations to these functions, so one can
actually verify the locks are held.

Signed-off-by: Johannes Thumshirn 
Acked-by: Dick Kennedy 
Signed-off-by: Martin K. Petersen

lpfc: Remove redundant code block in lpfc_scsi_cmd_iocb_cmpl

2016-02-24T02:27:02+00:00

This removes a redundant code block that will either be executed if the
ENABLE_FCP_RING_POLLING flag is set in phba->cfg_poll or not. The code
is just duplicated in both cases, hence we unify it again.

This probably is a left over from some sort of refactoring.

Signed-off-by: Johannes Thumshirn 
Reviewed-by: Matthew R. Ochs 
Reviewed-by: Tomas Henzl 
Reviewed-by: Sebastian Herbszt 
Acked-by: Dick Kennedy 
Signed-off-by: Martin K. Petersen

lpfc: Update version to 11.0.0.10 for upstream patch set

2015-12-22T03:08:49+00:00

Update version to 11.0.0.10 for upstream patch set

Signed-off-by: Dick Kennedy 
Signed-off-by: James Smart 
Reviewed-by: Hannes Reinicke 
Signed-off-by: Martin K. Petersen

lpfc: Use kzalloc instead of kmalloc

2015-12-22T03:08:15+00:00

This patch is to the lpfc_els.c which resolves following warning
reported by coccicheck:

WARNING: kzalloc should be used for rdp_context, instead of
kmalloc/memset

Signed-off-by: Punit Vara 
Signed-off-by: James Smart 
Reviewed-by: Hannes Reinicke 
Reviewed-by: Matthew R. Ochs 
Reviewed-by: Sebastian Herbszt 
Signed-off-by: Martin K. Petersen

lpfc: Delete unnecessary checks before the function call "mempool_destroy"

2015-12-22T03:06:36+00:00

The mempool_destroy() function tests whether its argument is NULL
and then returns immediately. Thus the test around the calls is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
Signed-off-by: James Smart 
Reviewed-by: Hannes Reinicke 
Reviewed-by: Sebastian Herbszt 
Signed-off-by: Martin K. Petersen

lpfc: Add logging for misconfigured optics.

2015-12-22T03:06:09+00:00

Add logging for misconfigured optics acqe reported by fw.

Signed-off-by: Dick Kennedy 
Signed-off-by: James Smart 
Reviewed-by: Hannes Reinicke 
Signed-off-by: Martin K. Petersen

lpfc: Fix external loopback failure.

2015-12-22T03:05:04+00:00

Fix external loopback failure.

Rx sequence reassembly was incorrect.

Signed-off-by: Dick Kennedy 
Signed-off-by: James Smart 
Reviewed-by: Hannes Reinicke 
Signed-off-by: Martin K. Petersen