linux-stable.git/drivers/scsi/libfc, branch v5.2.3

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 335

2019-06-05T15:37:06+00:00

Based on 1 normalized pattern(s):

  this program is free software you can redistribute it and or modify
  it under the terms and conditions of the gnu general public license
  version 2 as published by the free software foundation this program
  is distributed in the hope it will be useful but without any
  warranty without even the implied warranty of merchantability or
  fitness for a particular purpose see the gnu general public license
  for more details you should have received a copy of the gnu general
  public license along with this program if not write to the free
  software foundation inc 51 franklin st fifth floor boston ma 02110
  1301 usa

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-only

has been chosen to replace the boilerplate/reference in 111 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Alexios Zavras 
Reviewed-by: Allison Randal 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190530000436.567572064@linutronix.de
Signed-off-by: Greg Kroah-Hartman

Revert "scsi: fcoe: clear FC_RP_STARTED flags when receiving a LOGO"

2019-04-19T00:40:00+00:00

This patch clears FC_RP_STARTED flag during logoff, because of this
re-login(flogi) didn't happen to the switch.

This reverts commit 1550ec458e0cf1a40a170ab1f4c46e3f52860f65.

Fixes: 1550ec458e0c ("scsi: fcoe: clear FC_RP_STARTED flags when receiving a LOGO")
Cc:  # v4.18+
Signed-off-by: Saurav Kashyap 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Martin K. Petersen

Revert "scsi: libfc: Add WARN_ON() when deleting rports"

2019-02-05T03:17:33+00:00

This reverts commit bbc0f8bd88abefb0f27998f40a073634a3a2db89.

It added a warning whose intent was to check whether the rport was still
linked into the peer list. It doesn't work as intended and gives false
positive warnings for two reasons:

1) If the rport is never linked into the peer list it will not be
considered empty since the list_head is never initialized.

2) If the rport is deleted from the peer list using list_del_rcu(), then
the list_head is in an undefined state and it is not considered empty.

Signed-off-by: Ross Lagerwall 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Martin K. Petersen

scsi: libfc: free skb when receiving invalid flogi resp

2019-01-29T06:19:25+00:00

The issue to be fixed in this commit is when libfc found it received a
invalid FLOGI response from FC switch, it would return without freeing the
fc frame, which is just the skb data. This would cause memory leak if FC
switch keeps sending invalid FLOGI responses.

This fix is just to make it execute `fc_frame_free(fp)` before returning
from function `fc_lport_flogi_resp`.

Signed-off-by: Ming Lu 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Martin K. Petersen

scsi: libfc: fc_rport: Mark expected switch fall-through

2018-11-29T02:47:30+00:00

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Signed-off-by: Gustavo A. R. Silva 
Acked-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

scsi: libfc: Remove set but not used variable 'disc'

2018-11-22T03:12:32+00:00

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/scsi/libfc/fc_rport.c: In function 'fc_rport_recv_flogi_req':
drivers/scsi/libfc/fc_rport.c:866:18: warning:
 variable 'disc' set but not used [-Wunused-but-set-variable]

It no used any more after
commit baa6719f902a ("libfc: Update rport reference counting")

Signed-off-by: Yue Haibing 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

scsi: libfc: retry PRLI if we cannot analyse the payload

2018-10-16T03:53:37+00:00

When we fail to analyse the payload of a PRLI response we should reset
the state machine to retry the PRLI; eventually we will be getting a
proper frame.  Not doing so will result in a stuck state machine and the
port never to be presented to the systsm.

Suggested-by: Chad Dupuis 
Signed-off-by: Hannes Reinecke 
Reviewed-by: Arun Easi 
Signed-off-by: Martin K. Petersen

scsi: libfc: check fc_frame_payload_get() return value for null

2018-10-16T03:53:36+00:00

We should not assume the payload of a PRLI or PLOGI respons is always
present.

Signed-off-by: Thomas Abraham 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Arun Easi 
Signed-off-by: Martin K. Petersen

scsi: libfc: remove set but not used variable 'rpriv'

2018-09-12T00:59:11+00:00

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/scsi/libfc/fc_fcp.c: In function 'fc_queuecommand':
drivers/scsi/libfc/fc_fcp.c:1875:30: warning:
 variable 'rpriv' set but not used [-Wunused-but-set-variable]

Signed-off-by: YueHaibing 
Acked-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

scsi: libfc: remove unnecessary condition check

2018-08-30T11:36:48+00:00

kmem_cache_destroy() can handle NULL pointer correctly, so there is no
need to check NULL pointer before calling kmem_cache_destroy()

Signed-off-by: Chengguang Xu 
Acked-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen