linux-stable.git/drivers/scsi/libfc, branch linux-5.17.y

scsi: libfc: Fix use after free in fc_exch_abts_resp()

2022-04-13T17:27:20+00:00

[ Upstream commit 271add11994ba1a334859069367e04d2be2ebdd4 ]

fc_exch_release(ep) will decrease the ep's reference count. When the
reference count reaches zero, it is freed. But ep is still used in the
following code, which will lead to a use after free.

Return after the fc_exch_release() call to avoid use after free.

Link: https://lore.kernel.org/r/20220303015115.459778-1-niejianglei2021@163.com
Reviewed-by: Hannes Reinecke 
Signed-off-by: Jianglei Nie 
Signed-off-by: Martin K. Petersen 
Signed-off-by: Sasha Levin

scsi: libfc: Call scsi_done() directly

2021-10-17T01:28:48+00:00

Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.

Link: https://lore.kernel.org/r/20211007202923.2174984-44-bvanassche@acm.org
Signed-off-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen

scsi: libfc: Fix array index out of bound exception

2021-06-29T02:31:16+00:00

Fix array index out of bound exception in fc_rport_prli_resp().

Link: https://lore.kernel.org/r/20210615165939.24327-1-jhasan@marvell.com
Signed-off-by: Javed Hasan 
Signed-off-by: Martin K. Petersen

scsi: libfc: FDMI enhancements

2021-06-10T04:03:56+00:00

Add all the attributes for FDMI.

Fall back mechanism is added in between FDMI V2 and FDMI V1 attributes. In
case FDMI get fails for V2 attributes we fall back to V1 attributes.

Link: https://lore.kernel.org/r/20210603121623.10084-5-jhasan@marvell.com
Reviewed-by: Himanshu Madhani 
Signed-off-by: Javed Hasan 
Signed-off-by: Martin K. Petersen

scsi: libfc: Add FDMI-2 attributes

2021-06-10T04:03:56+00:00

Add all attributes for RHBA and RPA registration.

Fallback mechanism is added between RBHA V2 and RHBA V1 attributes. In case
RHBA get fails for V2 attributes we fall back to V1 attribute registration.

Link: https://lore.kernel.org/r/20210603121623.10084-4-jhasan@marvell.com
Reviewed-by: Himanshu Madhani 
Signed-off-by: Javed Hasan 
Signed-off-by: Martin K. Petersen

scsi: libfc: Initialisation of RHBA and RPA attributes

2021-06-10T04:03:32+00:00

Initialize RHBA and RPA attributes.

Link: https://lore.kernel.org/r/20210603121623.10084-2-jhasan@marvell.com
Reviewed-by: Himanshu Madhani 
Signed-off-by: Javed Hasan 
Signed-off-by: Martin K. Petersen

scsi: libfc: Correct the condition check and invalid argument passed

2021-06-10T03:55:38+00:00

Incorrect condition check was leading to data corruption.

Link: https://lore.kernel.org/r/20210603101404.7841-3-jhasan@marvell.com
Fixes: 8fd9efca86d0 ("scsi: libfc: Work around -Warray-bounds warning")
CC: stable@vger.kernel.org
Reviewed-by: Himanshu Madhani 
Signed-off-by: Javed Hasan 
Signed-off-by: Martin K. Petersen

scsi: libfc: Fix a format specifier

2021-04-16T02:44:40+00:00

Since the 'mfs' member has been declared as 'u32' in include/scsi/libfc.h,
use the %u format specifier instead of %hu. This patch fixes the following
clang compiler warning:

warning: format specifies type
      'unsigned short' but the argument has type 'u32' (aka 'unsigned int')
      [-Wformat]
                             "lport->mfs:%hu\n", mfs, lport->mfs);
                                         ~~~          ^~~~~~~~~~
                                         %u

Link: https://lore.kernel.org/r/20210415220826.29438-8-bvanassche@acm.org
Cc: Hannes Reinecke 
Signed-off-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen

scsi: libfc: Fix misspelling of fc_fcp_destroy()

2021-03-16T02:28:57+00:00

Fixes the following W=1 kernel build warning(s):

 drivers/scsi/libfc/fc_fcp.c:2255: warning: expecting prototype for fc_fcp_destory(). Prototype was for fc_fcp_destroy() instead

Link: https://lore.kernel.org/r/20210312094738.2207817-8-lee.jones@linaro.org
Cc: Hannes Reinecke 
Cc: "James E.J. Bottomley" 
Cc: "Martin K. Petersen" 
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones 
Signed-off-by: Martin K. Petersen

scsi: libfc: Fix incorrect naming of fc_rport_adisc_resp()

2021-03-16T02:28:57+00:00

Fixes the following W=1 kernel build warning(s):

 drivers/scsi/libfc/fc_rport.c:1500: warning: expecting prototype for fc_rport_els_adisc_resp(). Prototype was for fc_rport_adisc_resp() instead

Link: https://lore.kernel.org/r/20210312094738.2207817-6-lee.jones@linaro.org
Cc: Hannes Reinecke 
Cc: "James E.J. Bottomley" 
Cc: "Martin K. Petersen" 
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones 
Signed-off-by: Martin K. Petersen