linux-stable.git/drivers/scsi/ipr.c, branch linux-4.3.y

ipr: Enable SIS pipe commands for SIS-32 devices.

2015-08-28T20:14:53+00:00

Remove unnecessary check that disabled SIS pipe commands for SIS-32
devices.  This change was sufficient to enable raw mode and send SIS
pipe commands for a 57B3 device.

Fixes: f8ee25d7d239 ("ipr: AF DASD raw mode implementation in ipr driver")
Signed-off-by: Gabriel Krisman Bertazi 
Reviewed-by: Wen Xiong 
Acked-by: Brian King 
Signed-off-by: James Bottomley

ipr: Inhibit underlength data check for AFDASD in raw mode.

2015-08-28T20:14:53+00:00

Disable underlength error verification based on count of bytes actually
transferred for AF DASD devices when SIS pipe mode is enabled.

This avoids unexpected underlength errors when issuing some commands in
raw mode.

Signed-off-by: Gabriel Krisman Bertazi 
Reviewed-by: Wen Xiong 
Acked-by: Brian King 
Signed-off-by: James Bottomley

ipr: Endian / sparse fixes

2015-07-30T19:41:21+00:00

Some misc fixes for endianness checking with sparse so sparse with
endian checking now runs clean. Fixes a minor bug in the process
which was uncovered by sparse which would result in unnecessary
error recovery for check conditions.

Signed-off-by: Brian King 
Reviewed-by: Wen Xiong 
Signed-off-by: James Bottomley

ipr: Byte swapping for device_id attribute in sysfs

2015-07-30T19:39:39+00:00

On LE system, users see the wrong device_id attribute. This patch
does necessary byte swapping for device_id attribute and works on
both of LE and BE systems.

Signed-off-by: Wen Xiong 
Signed-off-by: Brian King 
Signed-off-by: James Bottomley

ipr: Fix invalid array indexing for HRRQ

2015-07-30T17:38:47+00:00

Fixes another signed / unsigned array indexing bug in the ipr driver.
Currently, when hrrq_index wraps, it becomes a negative number. We
do the modulo, but still have a negative number, so we end up indexing
backwards in the array. Given where the hrrq array is located in memory,
we probably won't actually reference memory we don't own, but nonetheless
ipr is still looking at data within struct ipr_ioa_cfg and interpreting it as
struct ipr_hrr_queue data, so bad things could certainly happen.

Each ipr adapter has anywhere from 1 to 16 HRRQs. By default, we use 2 on new
adapters.  Let's take an example:

Assume ioa_cfg->hrrq_index=0x7fffffffe and ioa_cfg->hrrq_num=4:

The atomic_add_return will then return -1. We mod this with 3 and get -2, add
one and get -1 for an array index.

On adapters which support more than a single HRRQ, we dedicate HRRQ to adapter
initialization and error interrupts so that we can optimize the other queues
for fast path I/O. So all normal I/O uses HRRQ 1-15. So we want to spread the
I/O requests across those HRRQs.

With the default module parameter settings, this bug won't hit, only when
someone sets the ipr.number_of_msix parameter to a value larger than 3 is when
bad things start to happen.

Cc: 
Tested-by: Wen Xiong 
Reviewed-by: Wen Xiong 
Reviewed-by: Gabriel Krisman Bertazi 
Signed-off-by: Brian King 
Reviewed-by: Martin K. Petersen 
Signed-off-by: James Bottomley

ipr: Fix incorrect trace indexing

2015-07-30T17:38:00+00:00

When ipr's internal driver trace was changed to an atomic, a signed/unsigned
bug slipped in which results in us indexing backwards in our memory buffer
writing on memory that does not belong to us. This patch fixes this by removing
the modulo and instead just mask off the low bits.

Cc: 
Tested-by: Wen Xiong 
Reviewed-by: Wen Xiong 
Reviewed-by: Gabriel Krisman Bertazi 
Signed-off-by: Brian King 
Reviewed-by: Martin K. Petersen 
Signed-off-by: James Bottomley

ipr: Fix locking for unit attention handling

2015-07-30T17:36:21+00:00

Make sure we have the host lock held when calling scsi_report_bus_reset. Fixes
a crash seen as the __devices list in the scsi host was changing as we were
iterating through it.

Cc: 
Reviewed-by: Wen Xiong 
Reviewed-by: Gabriel Krisman Bertazi 
Signed-off-by: Brian King 
Reviewed-by: Martin K. Petersen 
Signed-off-by: James Bottomley

Merge tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi

2015-04-16T23:02:04+00:00

Pull SCSI updates from James Bottomley:
"This is the usual grab bag of driver updates (lpfc, qla2xxx, storvsc,
aacraid, ipr) plus an assortment of minor updates. There's also a
major update to aic1542 which moves the driver into this millenium"

* tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi: (106 commits)
change SCSI Maintainer email
sd, mmc, virtio_blk, string_helpers: fix block size units
ufs: add support to allow non standard behaviours (quirks)
ufs-qcom: save controller revision info in internal structure
qla2xxx: Update driver version to 8.07.00.18-k
qla2xxx: Restore physical port WWPN only, when port down detected for FA-WWPN port.
qla2xxx: Fix virtual port configuration, when switch port is disabled/enabled.
qla2xxx: Prevent multiple firmware dump collection for ISP27XX.
qla2xxx: Disable Interrupt handshake for ISP27XX.
qla2xxx: Add debugging info for MBX timeout.
qla2xxx: Add serdes read/write support for ISP27XX
qla2xxx: Add udev notification to save fw dump for ISP27XX
qla2xxx: Add message for sucessful FW dump collected for ISP27XX.
qla2xxx: Add support to load firmware from file for ISP 26XX/27XX.
qla2xxx: Fix beacon blink for ISP27XX.
qla2xxx: Increase the wait time for firmware to be ready for P3P.
qla2xxx: Fix crash due to wrong casting of reg for ISP27XX.
qla2xxx: Fix warnings reported by static checker.
lpfc: Update version to 10.5.0.0 for upstream patch set
lpfc: Update copyright to 2015
...

ipr: AF DASD raw mode implementation in ipr driver

2015-04-09T21:17:57+00:00

This patch implements raw mode support for AF DASD in ipr driver
which allows for tools to send commands directly to physical
devices which are members of RAID arrays when enabled in the firmware.

[jejb: fix up whitespace]
Signed-off-by: Wen Xiong
Signed-off-by: Brian King 
Reviewed-by: Daniel Kreling 
Signed-off-by: James Bottomley

ipr: Re-enable write same

2015-04-09T21:14:53+00:00

Re-enable write same support for ipr RAID adapters.

Signed-off-by: Brian King 
Reviewed-by: Wen Xiong 
Reviewed-by: Daniel Kreling 
Signed-off-by: James Bottomley