linux-stable.git/drivers/scsi/device_handler, branch linux-3.10.y

scsi: scsi_dh_emc: return success in clariion_std_inquiry()

2017-11-02T09:46:03+00:00

commit 4d7d39a18b8b81511f0b893b7d2203790bf8a58b upstream.

We accidentally return an uninitialized variable on success.

Fixes: b6ff1b14cdf4 ("[SCSI] scsi_dh: Update EMC handler")
Signed-off-by: Dan Carpenter 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Martin K. Petersen 
Signed-off-by: Willy Tarreau

scsi_dh_rdac: always retry MODE SELECT on command lock violation

2016-02-25T19:57:47+00:00

commit d2d06d4fe0f2cc2df9b17fefec96e6e1a1271d91 upstream.

If MODE SELECT returns with sense '05/91/36' (command lock violation)
it should always be retried without counting the number of retries.
During an HBA upgrade or similar circumstances one might see a flood
of MODE SELECT command from various HBAs, which will easily trigger
the sense code and exceed the retry count.

Signed-off-by: Hannes Reinecke 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen 
Signed-off-by: Greg Kroah-Hartman

[SCSI] scsi_dh_alua: Add module parameter to allow failover to non preferred path without STPG

2013-04-11T23:00:31+00:00

Resending with requested rewording of the parameter description.  Currently
ALUA device handler sends STPG command during failover and failback.  Failover
can be optimized by implicit failover (by not to sending STPG command), when 1
is passed as hwhandler parameter in multipath.conf. ex "2 alua 1". We may need
to pass the parameter through module param for alua device handler to optimize
failover if incase retain_attached_hwhandler set in multipath.conf and
hwhandler is set with non-tpgs device handler ex: '1 rdac'.

[jejb: fix up whitespace and other issues]
Signed-off-by: Vijay Chauhan 
Signed-off-by: Sean Stewart 
Acked-by: Hannes Reinecke 
Signed-off-by: James Bottomley

[SCSI] scsi_dh_alua: fix stpg sense handling

2013-04-10T03:55:21+00:00

For the stpg_endio path we are not evaluating the sense. The bug
is that

1. The error value is set to -EIO when there is sense, so we hit the first
error check and always return SCSI_DH_IO.

2. h->senselen is set to zero in submit_stpg. It is not later set to
req->sense_len like in the synchrounous exection paths, so we must
check the req->sense_len field.

Signed-off-by: Mike Christie 
Signed-off-by: James Bottomley

drivers/scsi/device_handler: remove depends on CONFIG_EXPERIMENTAL

2013-01-21T22:52:45+00:00

The CONFIG_EXPERIMENTAL config item has not carried much meaning for a
while now and is almost always enabled by default. As agreed during the
Linux kernel summit, remove it from any "depends on" lines in Kconfigs.

CC: "James E.J. Bottomley" 
Signed-off-by: Kees Cook 
Signed-off-by: Greg Kroah-Hartman

[SCSI] scsi_dh_alua: Enable STPG for unavailable ports

2012-09-24T08:21:56+00:00

A quote from SPC-4: "While in the unavailable primary target port
asymmetric access state, the device server shall support those of
the following commands that it supports while in the active/optimized
state: [ ... ] d) SET TARGET PORT GROUPS; [ ... ]". Hence enable
sending STPG to a target port group that is in the unavailable state.

Signed-off-by: Bart Van Assche 
Reviewed-by: Mike Christie 
Acked-by: Hannes Reinecke 
Cc: 
Signed-off-by: James Bottomley

[SCSI] scsi_dh_rdac : minor return fix for rdac

2012-09-24T08:11:03+00:00

Signed-off-by: Babu Moger 
Signed-off-by: James Bottomley

[SCSI] scsi_dh_rdac : Consolidate rdac strings together

2012-09-24T08:11:03+00:00

This patch consolidates the strings together. Purpose is to remove minor product strings extensions.
That way the future products with similar strings should not require change  here.

Signed-off-by: Babu Moger 
Signed-off-by: James Bottomley

[SCSI] scsi_dh_rdac: Add a new netapp vendor/product string

2012-09-24T08:11:03+00:00

This patch adds a new vendor/product strings for netapp E series  product.
Also consolidated the strings together with similar names.

Signed-off-by: Babu Moger 
Signed-off-by: James Bottomley

[SCSI] scsi_dh: add scsi_dh_attached_handler_name

2012-07-20T07:58:42+00:00

Introduce scsi_dh_attached_handler_name() to retrieve the name of the
scsi_dh that is attached to the scsi_device associated with the provided
request queue.  Returns NULL if a scsi_dh is not attached.

Also, fix scsi_dh_{attach,detach} function header comments to document
@q rather than @sdev.

Signed-off-by: Mike Snitzer 
Tested-by: Babu Moger 
Reviewed-by: Chandra Seetharaman 
Acked-by: Hannes Reinecke 
Signed-off-by: James Bottomley