linux-stable.git/drivers/scsi/device_handler, branch linux-2.6.32.y

scsi_dh_rdac: always retry MODE SELECT on command lock violation

2016-03-12T13:25:42+00:00

commit d2d06d4fe0f2cc2df9b17fefec96e6e1a1271d91 upstream.

If MODE SELECT returns with sense '05/91/36' (command lock violation)
it should always be retried without counting the number of retries.
During an HBA upgrade or similar circumstances one might see a flood
of MODE SELECT command from various HBAs, which will easily trigger
the sense code and exceed the retry count.

Signed-off-by: Hannes Reinecke 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen 
Signed-off-by: Ben Hutchings 
Signed-off-by: Willy Tarreau

SCSI: scsi_dh: check queuedata pointer before proceeding further

2012-01-12T19:40:12+00:00

commit a18a920c70d48a8e4a2b750d8a183b3c1a4be514 upstream.

This patch validates sdev pointer in scsi_dh_activate before proceeding further.

Without this check we might see the panic as below. I have seen this
panic multiple times..

Call trace:

 #0 [ffff88007d647b50] machine_kexec at ffffffff81020902
 #1 [ffff88007d647ba0] crash_kexec at ffffffff810875b0
 #2 [ffff88007d647c70] oops_end at ffffffff8139c650
 #3 [ffff88007d647c90] __bad_area_nosemaphore at ffffffff8102dd15
 #4 [ffff88007d647d50] page_fault at ffffffff8139b8cf
    [exception RIP: scsi_dh_activate+0x82]
    RIP: ffffffffa0041922  RSP: ffff88007d647e00  RFLAGS: 00010046
    RAX: 0000000000000000  RBX: 0000000000000000  RCX: 00000000000093c5
    RDX: 00000000000093c5  RSI: ffffffffa02e6640  RDI: ffff88007cc88988
    RBP: 000000000000000f   R8: ffff88007d646000   R9: 0000000000000000
    R10: ffff880082293790  R11: 00000000ffffffff  R12: ffff88007cc88988
    R13: 0000000000000000  R14: 0000000000000286  R15: ffff880037b845e0
    ORIG_RAX: ffffffffffffffff  CS: 0010  SS: 0000
 #5 [ffff88007d647e38] run_workqueue at ffffffff81060268
 #6 [ffff88007d647e78] worker_thread at ffffffff81060386
 #7 [ffff88007d647ee8] kthread at ffffffff81064436
 #8 [ffff88007d647f48] kernel_thread at ffffffff81003fba

Signed-off-by: Babu Moger 
Signed-off-by: James Bottomley 
Signed-off-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

scsi_dh_emc: request flag cleanup

2011-05-09T22:55:34+00:00

commit 5738d4449c1baf05e8345684d12371f76296473d upstream.

blk_get_request sets the cmd_flags, so we should not and do not
need to set them. If we did set them to a different value then
it can cause a oops in the elevator code.

Signed-off-by: Mike Christie 
Signed-off-by: James Bottomley 
Signed-off-by: Greg Kroah-Hartman

scsi_dh_emc: fix mode select request setup

2011-05-09T22:55:34+00:00

commit 6c71dcb28ff9b63b814a0b76a256f5dae08d3e0d upstream.

This patch fixes the request setup code for mode selects. I got the fixes from
Hannes Reinecke while trying to hunt down some problems and merged it
into one patch. I am sending it because Hannes is busy with other things.

The patch fixes:
- setting of the length for mode selects.
- setting of the data direction for mode select 10.

Signed-off-by: Hannes Reinecke 
Signed-off-by: Mike Christie 
Signed-off-by: James Bottomley 
Signed-off-by: Greg Kroah-Hartman

scsi_dh_alua: Add IBM Power Virtual SCSI ALUA device to dev list

2011-03-02T14:46:43+00:00

commit 22963a37b3437a25812cc856afa5a84ad4a3f541 upstream.

Adds IBM Power Virtual SCSI ALUA devices to the ALUA device handler.

Signed-off-by: Brian King 
Signed-off-by: James Bottomley 
Cc: maximilian attems 
Signed-off-by: Greg Kroah-Hartman

scsi_dh_alua: add netapp to dev list

2011-03-02T14:46:43+00:00

commit cd4a8814d44672bd2c8f04a472121bfbe193809c upstream.

Newer Netapp target software supports ALUA, so
this patch adds them to the scsi_dev_alua dev list.

Signed-off-by: Mike Christie 
Signed-off-by: James Bottomley 
Cc: maximilian attems 
Signed-off-by: Greg Kroah-Hartman

scsi_dh: create sysfs file, dh_state for all SCSI disk devices

2010-01-28T23:01:22+00:00

commit 5917290ce9b376866b165d02a5ed88d5ecdb32d0 upstream.

Create the sysfs file, dh_state even if the new SCSI device is not
in the any of the device handler's internal lists.

Signed-Off-by: Chandra Seetharaman 
Acked-by: Hannes Reinecke 
Signed-off-by: James Bottomley 
Signed-off-by: Greg Kroah-Hartman

[SCSI] scsi_dh_rdac: Fix for returning correct mode select cmd return info

2009-10-02T14:45:09+00:00

The function mode_select_handle_sense returns SCSI_DH_OK even when there is a sense code which is incorrect. Removing it so that it returns SCSI_DH_IO when there is sense that is not handled by this function.

Signed-off-by: Babu Moger 
Reviewed-by: Vijay Chauhan 
Reviewed-by: Bob Stankey 
Reviewed-by: Chandra Seetharaman 
Signed-off-by: James Bottomley

[SCSI] scsi_dh_rdac: changes for rdac debug logging

2009-09-12T14:35:31+00:00

Patch to add debugging stuff for rdac device handler.
- Added a bit mask "module parameter" rdac_logging with 2 bits for each type
  of logging.
- currently defined only two types of logging(failover and sense logging). Can
  be enhanced later if required.
- By default only failover logging is enabled which is equivalent of current
  logging.

Signed-off-by: Babu Moger 
Reviewed-by: Vijay Chauhan 
Reviewed-by: Bob Stankey 
Signed-off-by: James Bottomley

[SCSI] scsi_dh_rdac: changes to collect the rdac debug information during the initialization

2009-09-12T14:35:31+00:00

Adding the code to read the debug information during initialization. This
patch collects the information about storage and controllers during
rdac_activate.

Signed-off-by: Babu Moger 
Reviewed-by: Vijay Chauhan 
Reviewed-by: Bob Stankey 
Signed-off-by: James Bottomley