linux-stable.git/drivers/scsi/aacraid/commctrl.c, branch linux-5.4.y

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18

2019-05-21T09:28:46+00:00

Based on 1 normalized pattern(s):

  this program is free software you can redistribute it and or modify
  it under the terms of the gnu general public license as published by
  the free software foundation either version 2 or at your option any
  later version this program is distributed in the hope that it will
  be useful but without any warranty without even the implied warranty
  of merchantability or fitness for a particular purpose see the gnu
  general public license for more details you should have received a
  copy of the gnu general public license along with this program see
  the file copying if not write to the free software foundation 675
  mass ave cambridge ma 02139 usa

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-or-later

has been chosen to replace the boilerplate/reference in 52 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Jilayne Lovejoy 
Reviewed-by: Steve Winslow 
Reviewed-by: Kate Stewart 
Reviewed-by: Allison Randal 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190519154042.342335923@linutronix.de
Signed-off-by: Greg Kroah-Hartman

scsi: ata: Use unsigned int for cmd's type in ioctls in scsi_host_template

2019-02-08T22:33:00+00:00

Clang warns several times in the scsi subsystem (trimmed for brevity):

drivers/scsi/hpsa.c:6209:7: warning: overflow converting case value to
switch condition type (2147762695 to 18446744071562347015) [-Wswitch]
        case CCISS_GETBUSTYPES:
             ^
drivers/scsi/hpsa.c:6208:7: warning: overflow converting case value to
switch condition type (2147762694 to 18446744071562347014) [-Wswitch]
        case CCISS_GETHEARTBEAT:
             ^

The root cause is that the _IOC macro can generate really large numbers,
which don't fit into type 'int', which is used for the cmd parameter in
the ioctls in scsi_host_template. My research into how GCC and Clang are
handling this at a low level didn't prove fruitful. However, looking at
the rest of the kernel tree, all ioctls use an 'unsigned int' for the
cmd parameter, which will fit all of the _IOC values in the scsi/ata
subsystems.

Make that change because none of the ioctls expect a negative value for
any command, it brings the ioctls inline with the reset of the kernel,
and it removes ambiguity, which is never good when dealing with compilers.

Link: https://github.com/ClangBuiltLinux/linux/issues/85
Link: https://github.com/ClangBuiltLinux/linux/issues/154
Link: https://github.com/ClangBuiltLinux/linux/issues/157
Signed-off-by: Nathan Chancellor 
Acked-by: Bradley Grove 
Acked-by: Don Brace 
Reviewed-by: Bart Van Assche 
Tested-by: Nick Desaulniers 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Martin K. Petersen

scsi: aacraid: change event_wait to a completion

2018-12-13T01:35:33+00:00

The event_wait semaphore has completion semantics, so we can
change it over to the completion interface for clarity without
changing the behavior.

Signed-off-by: Arnd Bergmann 
Reviewed-by: Johannes Thumshirn 
Reviewed-by: Dave Carroll 
Signed-off-by: Martin K. Petersen

scsi: aacraid: change wait_sem to a completion

2018-12-13T01:35:33+00:00

The wait_sem member is used like a completion, so we should
use the respective API. The behavior is unchanged.

Signed-off-by: Arnd Bergmann 
Reviewed-by: Johannes Thumshirn 
Reviewed-by: Dave Carroll 
Signed-off-by: Martin K. Petersen

scsi: aacraid: remove bogus GFP_DMA32 specifies

2018-06-06T01:15:08+00:00

For one GFP_DMA32 does not actually work with kmalloc, as we only have
GFP_DMA and GFP_KERNEL caches, but not GFP_DMA32.  Second the memory
is mapped using the proper DMA API anyway, which would include proper
bounce buffering if needed by the device.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

scsi: aacraid: Fix ioctl reset hang

2018-01-04T04:26:41+00:00

Driver would hang when attempting to send reset from the ioctl interface,
since it would wait to retrieve the ioctl mutex at send shutdown.

Set adapter shutdown and unlock mutex before sending down reset request.

Signed-off-by: Raghava Aditya Renukunta 
Signed-off-by: Martin K. Petersen

scsi: aacraid: Don't copy uninitialized stack memory to userspace

2017-06-26T19:01:03+00:00

Both aac_send_raw_srb() and aac_get_hba_info() may copy stack allocated
structs to userspace without initializing all members of these
structs. Clear out this memory to prevent information leaks.

Fixes: 423400e64d377 ("scsi: aacraid: Include HBA direct interface")
Fixes: c799d519bf088 ("scsi: aacraid: Retrieve HBA host information ioctl")
Signed-off-by: Seth Forshee 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

scsi: aacraid: fix leak of data from stack back to userspace

2017-06-26T16:32:15+00:00

The fields sense_data_size and sense_data are unitialized garbage from
the stack and are being copied back to userspace.  Fix this leak of
stack information by ensuring they are zero'd.

Detected by CoverityScan, CID#1435473 ("Uninitialized scalar variable")

Fixes: 423400e64d377 ("scsi: aacraid: Include HBA direct interface")
Signed-off-by: Colin Ian King 
Acked-by: Dave Carroll 
Signed-off-by: Martin K. Petersen

scsi: aacraid: Remove __GFP_DMA for raw srb memory

2017-06-13T00:47:59+00:00

The raw srb commands do not requires memory that in the ZONE_DMA memory
space. For 32bit srb commands use GFP_DMA32 to limit the memory to 32bit
memory range (4GB).

Signed-off-by: Raghava Aditya Renukunta 
Reviewed-by: Dave Carroll 
Signed-off-by: Martin K. Petersen

scsi: aacraid: pci_alloc_consistent() failures on ARM64

2017-04-26T22:28:06+00:00

There were pci_alloc_consistent() failures on ARM64 platform.  Use
dma_alloc_coherent() with GFP_KERNEL flag DMA memory allocations.

Signed-off-by: Mahesh Rajashekhara 
[hch: tweaked indentation, removed memsets]
Signed-off-by: Christoph Hellwig 
Acked-by: Dave Carroll 
Signed-off-by: Martin K. Petersen