linux-stable.git/drivers/scsi/aacraid/commctrl.c, branch linux-5.0.y

scsi: aacraid: change event_wait to a completion

2018-12-13T01:35:33+00:00

The event_wait semaphore has completion semantics, so we can
change it over to the completion interface for clarity without
changing the behavior.

Signed-off-by: Arnd Bergmann 
Reviewed-by: Johannes Thumshirn 
Reviewed-by: Dave Carroll 
Signed-off-by: Martin K. Petersen

scsi: aacraid: change wait_sem to a completion

2018-12-13T01:35:33+00:00

The wait_sem member is used like a completion, so we should
use the respective API. The behavior is unchanged.

Signed-off-by: Arnd Bergmann 
Reviewed-by: Johannes Thumshirn 
Reviewed-by: Dave Carroll 
Signed-off-by: Martin K. Petersen

scsi: aacraid: remove bogus GFP_DMA32 specifies

2018-06-06T01:15:08+00:00

For one GFP_DMA32 does not actually work with kmalloc, as we only have
GFP_DMA and GFP_KERNEL caches, but not GFP_DMA32.  Second the memory
is mapped using the proper DMA API anyway, which would include proper
bounce buffering if needed by the device.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

scsi: aacraid: Fix ioctl reset hang

2018-01-04T04:26:41+00:00

Driver would hang when attempting to send reset from the ioctl interface,
since it would wait to retrieve the ioctl mutex at send shutdown.

Set adapter shutdown and unlock mutex before sending down reset request.

Signed-off-by: Raghava Aditya Renukunta 
Signed-off-by: Martin K. Petersen

scsi: aacraid: Don't copy uninitialized stack memory to userspace

2017-06-26T19:01:03+00:00

Both aac_send_raw_srb() and aac_get_hba_info() may copy stack allocated
structs to userspace without initializing all members of these
structs. Clear out this memory to prevent information leaks.

Fixes: 423400e64d377 ("scsi: aacraid: Include HBA direct interface")
Fixes: c799d519bf088 ("scsi: aacraid: Retrieve HBA host information ioctl")
Signed-off-by: Seth Forshee 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

scsi: aacraid: fix leak of data from stack back to userspace

2017-06-26T16:32:15+00:00

The fields sense_data_size and sense_data are unitialized garbage from
the stack and are being copied back to userspace.  Fix this leak of
stack information by ensuring they are zero'd.

Detected by CoverityScan, CID#1435473 ("Uninitialized scalar variable")

Fixes: 423400e64d377 ("scsi: aacraid: Include HBA direct interface")
Signed-off-by: Colin Ian King 
Acked-by: Dave Carroll 
Signed-off-by: Martin K. Petersen

scsi: aacraid: Remove __GFP_DMA for raw srb memory

2017-06-13T00:47:59+00:00

The raw srb commands do not requires memory that in the ZONE_DMA memory
space. For 32bit srb commands use GFP_DMA32 to limit the memory to 32bit
memory range (4GB).

Signed-off-by: Raghava Aditya Renukunta 
Reviewed-by: Dave Carroll 
Signed-off-by: Martin K. Petersen

scsi: aacraid: pci_alloc_consistent() failures on ARM64

2017-04-26T22:28:06+00:00

There were pci_alloc_consistent() failures on ARM64 platform.  Use
dma_alloc_coherent() with GFP_KERNEL flag DMA memory allocations.

Signed-off-by: Mahesh Rajashekhara 
[hch: tweaked indentation, removed memsets]
Signed-off-by: Christoph Hellwig 
Acked-by: Dave Carroll 
Signed-off-by: Martin K. Petersen

scsi: aacraid: Use correct channel number for raw srb

2017-02-22T23:41:41+00:00

The channel being used for raw srb commands is retrieved from the utility
sent fibs and is converted into physical channel id. The driver does not
need to to do this since the management utility sends the correct channel
id in the first place and in addition the driver sets inaccurate
information in the cmd sent to the firmware and gets an invalid response.

Fixed by using channel id from srb command.

Cc: stable@vger.kernel.org
Fixes: 423400e64d377c0 ("scsi: aacraid: Include HBA direct interface")
Signed-off-by: Raghava Aditya Renukunta 
Reviewed-by: David Carroll 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

scsi: aacraid: Update copyrights

2017-02-03T15:35:04+00:00

Added new copyright messages

Signed-off-by: Raghava Aditya Renukunta 
Signed-off-by: Dave Carroll 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen