linux-stable.git/drivers/s390/net, branch linux-4.6.y

qeth: delete napi struct when removing a qeth device

2016-08-10T10:54:47+00:00

commit 7831b4ff0d926e0deeaabef9db8800ed069a2757 upstream.

A qeth_card contains a napi_struct linked to the net_device during
device probing. This struct must be deleted when removing the qeth
device, otherwise Panic on oops can occur when qeth devices are
repeatedly removed and added.

Fixes: a1c3ed4c9ca ("qeth: NAPI support for l2 and l3 discipline")
Signed-off-by: Ursula Braun 
Tested-by: Alexander Klein 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

s390: Use pr_warn instead of pr_warning

2016-03-07T12:12:04+00:00

Convert the uses of pr_warning to pr_warn so there are fewer
uses of the old pr_warning.

Miscellanea:

o Align arguments
o Coalesce formats

Signed-off-by: Joe Perches 
Signed-off-by: Heiko Carstens 
Signed-off-by: Martin Schwidefsky

qeth: get rid of redundant 0-termination

2015-12-14T21:16:45+00:00

0-termination is redundant, since sprintf has done that.

Signed-off-by: Rasmus Villemoes 
Signed-off-by: Ursula Braun 
Signed-off-by: David S. Miller

qeth: repair SBAL elements calculation

2015-12-14T21:16:45+00:00

When sending skbs, qeth determines the number of qdio SBAL elements
required. If qeth sends a fragmented skb, the SBAL element number
calculation is wrong, because the fragmented data part is added
twice in qeth_l3_tso_elements(). This patch makes sure fragmented
data is handled in qeth_elements_for_frags() only, while
qeth_l3_tso_elements() starts calculation of qdio SBAL elements just
with the linear data part of the skb.

Signed-off-by: Ursula Braun 
Reviewed-by: Thomas Richter 
Signed-off-by: David S. Miller

qeth: initialize net_device with carrier off

2015-12-14T21:16:45+00:00

/sys/class/net//operstate for an active qeth network
interface offen shows "unknown", which translates to "state UNKNOWN
in output of "ip link show". It is caused by a missing initialization
of the __LINK_STATE_NOCARRIER bit in the net_device state field.
This patch adds a netif_carrier_off() invocation when creating the
net_device for a qeth device.

Signed-off-by: Ursula Braun 
Acked-by: Hendrik Brueckner 
Reference-ID: Bugzilla 133209
Signed-off-by: David S. Miller

qeth use common function qeth_get_setassparms_cmd

2015-12-14T21:16:45+00:00

There have been 2 identical versions of function
qeth_get_setassparms_cmd() for layer 2 and layer 3.
Remove the layer 3 function qeth_l3_get_setassparms_cmd()
and call the common one named qeth_get_setassparms_cmd()
located in qeth_core_main.c

Signed-off-by: Thomas Richter 
Signed-off-by: Ursula Braun 
Reviewed-by: Eugene Crosser 
Signed-off-by: David S. Miller

s390-ctcm: Delete unnecessary checks before the function call "channel_remove"

2015-12-14T21:16:44+00:00

The channel_remove() function tests whether its argument is NULL
and then returns immediately. Thus the test around the calls is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
Signed-off-by: Ursula Braun 
Signed-off-by: David S. Miller

s390/qeth: optimize MAC handling in rx_mode callback

2015-10-07T11:52:04+00:00

In layer2 mode of the qeth driver, MAC address lists
from struct net_device require mapping to the OSA-card.
The existing implementation is inefficient for lists with
more than several MAC addresses, since for every
ndo_set_rx_mode callback it removes all MAC addresses first,
and then registers the current MAC address list.
This patch changes implementation of ndo_set_rx_mode callback
in qeth, only performing hardware registration/removal for
new/deleted addresses. To shorten lookup of MAC addresses
registered addresses are kept in a hashtable instead of a
linear list.

Signed-off-by: Lakhvich Dmitriy 
Signed-off-by: Ursula Braun 
Reviewed-by: Eugene Crosser 
Reviewed-by: Thomas Richter 
Tested-by: Christian Borntraeger 
Signed-off-by: David S. Miller

s390/qeth: switch to napi_gro_receive

2015-10-07T11:52:04+00:00

Add support for GRO (generic receive offload) in the layer 2
part of device driver qeth. This results in a performance
improvement when GRO and RX is turned on.

Signed-off-by: Thomas Richter 
Signed-off-by: Ursula Braun 
Signed-off-by: David S. Miller

s390/iucv: do not use arrays as argument

2015-09-21T23:03:04+00:00

The iucv code uses arrays as arguments. Even though this does not
really cause a problem, it could be misleading, since the compiler
turns array arguments into just a pointer argument. To be more
precise this patch changes the array arguments into pointers.

Signed-off-by: Ursula Braun 
Signed-off-by: David S. Miller