linux-stable.git/drivers/rtc, branch v5.10.7

rtc: pcf2127: only use watchdog when explicitly available

2021-01-09T12:46:22+00:00

commit 71ac13457d9d1007effde65b54818106b2c2b525 upstream.

Most boards using the pcf2127 chip (in my bubble) don't make use of the
watchdog functionality and the respective output is not connected. The
effect on such a board is that there is a watchdog device provided that
doesn't work.

So only register the watchdog if the device tree has a "reset-source"
property.

Signed-off-by: Uwe Kleine-König 
[RV: s/has-watchdog/reset-source/]
Signed-off-by: Rasmus Villemoes 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20201218101054.25416-3-rasmus.villemoes@prevas.dk
Signed-off-by: Greg Kroah-Hartman

rtc: pcf2127: move watchdog initialisation to a separate function

2021-01-09T12:46:22+00:00

commit 5d78533a0c53af9659227c803df944ba27cd56e0 upstream.

The obvious advantages are:

 - The linker can drop the watchdog functions if CONFIG_WATCHDOG is off.
 - All watchdog stuff grouped together with only a single function call
   left in generic code.
 - Watchdog register is only read when it is actually used.
 - Less #ifdefery

Signed-off-by: Uwe Kleine-König 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20200924105256.18162-2-u.kleine-koenig@pengutronix.de
Cc: Rasmus Villemoes 
Signed-off-by: Greg Kroah-Hartman

rtc: pl031: fix resource leak in pl031_probe

2021-01-06T13:56:53+00:00

[ Upstream commit 1eab0fea2514b269e384c117f5b5772b882761f0 ]

When devm_rtc_allocate_device is failed in pl031_probe, it should release
mem regions with device.

Reported-by: Hulk Robot 
Signed-off-by: Zheng Liang 
Signed-off-by: Alexandre Belloni 
Acked-by: Linus Walleij 
Link: https://lore.kernel.org/r/20201112093139.32566-1-zhengliang6@huawei.com
Signed-off-by: Sasha Levin

rtc: sun6i: Fix memleak in sun6i_rtc_clk_init

2021-01-06T13:56:53+00:00

[ Upstream commit 28d211919e422f58c1e6c900e5810eee4f1ce4c8 ]

When clk_hw_register_fixed_rate_with_accuracy() fails,
clk_data should be freed. It's the same for the subsequent
two error paths, but we should also unregister the already
registered clocks in them.

Signed-off-by: Dinghao Liu 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20201020061226.6572-1-dinghao.liu@zju.edu.cn
Signed-off-by: Sasha Levin

rtc: ep93xx: Fix NULL pointer dereference in ep93xx_rtc_read_time

2020-12-30T10:54:29+00:00

commit 00c33482bb6110bce8110daa351f9b3baf4df7dc upstream.

Mismatch in probe platform_set_drvdata set's and method's that call
dev_get_platdata will result in "Unable to handle kernel NULL pointer
dereference", let's use according method for getting driver data after
platform_set_drvdata.

8<--- cut here ---
Unable to handle kernel NULL pointer dereference at virtual address 00000000
pgd = (ptrval)
[00000000] *pgd=00000000
Internal error: Oops: 5 [#1] ARM
Modules linked in:
CPU: 0 PID: 1 Comm: swapper Not tainted 5.9.10-00003-g723e101e0037-dirty #4
Hardware name: Technologic Systems TS-72xx SBC
PC is at ep93xx_rtc_read_time+0xc/0x2c
LR is at __rtc_read_time+0x4c/0x8c
[...]
[] (ep93xx_rtc_read_time) from [] (__rtc_read_time+0x4c/0x8c)
[] (__rtc_read_time) from [] (rtc_read_time+0x2c/0x4c)
[] (rtc_read_time) from [] (__rtc_read_alarm+0x28/0x358)
[] (__rtc_read_alarm) from [] (__rtc_register_device+0x124/0x2ec)
[] (__rtc_register_device) from [] (ep93xx_rtc_probe+0xa4/0xac)
[] (ep93xx_rtc_probe) from [] (platform_drv_probe+0x24/0x5c)
[] (platform_drv_probe) from [] (really_probe+0x218/0x374)
[] (really_probe) from [] (device_driver_attach+0x44/0x60)
[] (device_driver_attach) from [] (__driver_attach+0xb4/0xc0)
[] (__driver_attach) from [] (bus_for_each_dev+0x68/0xac)
[] (bus_for_each_dev) from [] (driver_attach+0x18/0x24)
[] (driver_attach) from [] (bus_add_driver+0x150/0x1b4)
[] (bus_add_driver) from [] (driver_register+0xb0/0xf4)
[] (driver_register) from [] (__platform_driver_register+0x30/0x48)
[] (__platform_driver_register) from [] (ep93xx_rtc_driver_init+0x10/0x1c)
[] (ep93xx_rtc_driver_init) from [] (do_one_initcall+0x7c/0x1c0)
[] (do_one_initcall) from [] (kernel_init_freeable+0x168/0x1ac)
[] (kernel_init_freeable) from [] (kernel_init+0x8/0xf4)
[] (kernel_init) from [] (ret_from_fork+0x14/0x34)
Exception stack(0xc441dfb0 to 0xc441dff8)
dfa0:                                     00000000 00000000 00000000 00000000
dfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
dfe0: 00000000 00000000 00000000 00000000 00000013 00000000
Code: e12fff1e e92d4010 e590303c e1a02001 (e5933000)
---[ end trace c914d6030eaa95c8 ]---

Fixes: b809d192eb98 ("rtc: ep93xx: stop setting platform_data")
Signed-off-by: Nikita Shubin 
Signed-off-by: Alexandre Belloni 
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20201201095507.10317-1-nikita.shubin@maquefel.me
Signed-off-by: Greg Kroah-Hartman

rtc: pcf2127: fix pcf2127_nvmem_read/write() returns

2020-12-30T10:52:57+00:00

[ Upstream commit ba1c30bf3f2536f248d262c6f257b5a787305991 ]

These functions should return zero on success.  Non-zero returns are
treated as error.  On some paths, this doesn't matter but in
nvmem_cell_read() a non-zero return would be passed to ERR_PTR() and
lead to an Oops.

Fixes: d6c3029f32f7 ("rtc: pcf2127: add support for accessing internal static RAM")
Signed-off-by: Dan Carpenter 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20201022070451.GA2817669@mwanda
Signed-off-by: Sasha Levin

Merge tag 'rtc-5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux

2020-10-21T18:22:08+00:00

Pull RTC updates from Alexandre Belloni:
 "A new driver this cycle is making the bulk of the changes and the
  rx8010 driver has been rework to use the modern APIs.

  Summary:

  Subsystem:
   - new generic DT properties: aux-voltage-chargeable,
     trickle-voltage-millivolt

  New driver:
   - Microcrystal RV-3032

  Drivers:
   - ds1307: use aux-voltage-chargeable
   - r9701, rx8010: modernization of the driver
   - rv3028: fix clock output, trickle resistor values, RAM
     configuration registers"

* tag 'rtc-5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux: (50 commits)
  rtc: r9701: set range
  rtc: r9701: convert to devm_rtc_allocate_device
  rtc: r9701: stop setting RWKCNT
  rtc: r9701: remove useless memset
  rtc: r9701: stop setting a default time
  rtc: r9701: remove leftover comment
  rtc: rv3032: Add a driver for Microcrystal RV-3032
  dt-bindings: rtc: rv3032: add RV-3032 bindings
  dt-bindings: rtc: add trickle-voltage-millivolt
  rtc: rv3028: ensure ram configuration registers are saved
  rtc: rv3028: factorize EERD bit handling
  rtc: rv3028: fix trickle resistor values
  rtc: rv3028: fix clock output support
  rtc: mt6397: Remove unused member dev
  rtc: rv8803: simplify the return expression of rv8803_nvram_write
  rtc: meson: simplify the return expression of meson_vrtc_probe
  rtc: rx8010: rename rx8010_init_client() to rx8010_init()
  rtc: ds1307: enable rx8130's backup battery, make it chargeable optionally
  rtc: ds1307: consider aux-voltage-chargeable
  rtc: ds1307: store previous charge default per chip
  ...

rtc: r9701: set range

2020-10-19T20:48:55+00:00

Set range and remove the set_time check. This is a classic BCD RTC.

Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20201015191135.471249-6-alexandre.belloni@bootlin.com

rtc: r9701: convert to devm_rtc_allocate_device

2020-10-19T20:48:55+00:00

This allows further improvement of the driver.

Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20201015191135.471249-5-alexandre.belloni@bootlin.com

rtc: r9701: stop setting RWKCNT

2020-10-19T20:48:55+00:00

tm_wday is never checked for validity and it is not read back in
r9701_get_datetime. Avoid setting it to stop tripping static checkers:

        drivers/rtc/rtc-r9701.c:109 r9701_set_datetime()
        error: undefined (user controlled) shift '1 << dt->tm_wday'

Reported-by: Dan Carpenter 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20201015191135.471249-4-alexandre.belloni@bootlin.com