linux-stable.git/drivers/rtc/rtc-s5m.c, branch linux-3.16.y

rtc: s5m: fix to update ctrl register

2015-09-29T15:44:49+00:00

commit ff02c0444b83201ff76cc49deccac8cf2bffc7bc upstream.

According to datasheet, the S2MPS13X and S2MPS14X should update write
buffer via setting WUDR bit to high after ctrl register is written.

If not, ALARM interrupt of rtc-s5m doesn't happen first time when i use
tools/testing/selftests/timers/rtctest.c test program and hour format is
used to 12 hour mode in Odroid-XU3 board.

One more issue is the RTC doesn't keep time on Odroid-XU3 board when i
turn on board after power off even if RTC battery is connected. It can
be solved as setting WUDR & RUDR bits to high at the same time after
RTC_CTRL register is written. It's same with condition of only writing
ALARM registers, so this is for only S2MPS14 and we should set WUDR &
A_UDR bits to high on S2MPS13.

I can't find any reasonable description about this like fix from
datasheet, but can find similar codes from rtc driver source of
hardkernel kernel and vendor kernel.

Signed-off-by: Joonyoung Shim 
Reviewed-by: Krzysztof Kozlowski 
Tested-by: Krzysztof Kozlowski 
Signed-off-by: Alexandre Belloni 
Signed-off-by: Luis Henriques

drivers/rtc/rtc-s5m.c: terminate s5m_rtc_id array with empty element

2015-02-04T10:58:19+00:00

commit 45cd15e600ec8006305ce83f62c7208c2cb7a052 upstream.

Array of platform_device_id elements should be terminated with empty
element.

Fixes: 5bccae6ec458 ("rtc: s5m-rtc: add real-time clock driver for s5m8767")
Signed-off-by: Andrey Ryabinin 
Reviewed-by: Krzysztof Kozlowski 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Luis Henriques

rtc: s5m: consolidate two device type switch statements

2014-06-10T22:34:47+00:00

In probe the configuration of driver for different chipsets was done in
two switch (pdata->device_type) statements.  Consolidate them into one
switch statement to increase code readability.

Additionally check the return value of regmap_irq_get_virq and exit
probe on error.

Signed-off-by: Krzysztof Kozlowski 
Cc: Kyungmin Park 
Cc: Lee Jones 
Cc: Alessandro Zummo 
Cc: Sangbeom Kim 
Cc: Samuel Ortiz 
Cc: Marek Szyprowski 
Cc: Bartlomiej Zolnierkiewicz 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: s5m: add support for S2MPS14 RTC

2014-06-10T22:34:47+00:00

Add support for S2MPS14 to the rtc-s5m driver.  Differences in S2MPS14
(in comparison to S5M8767):

 - Layout of registers
 - Lack of century support for time and alarms (7 registers used for
   storing time/alarm)
 - Two buffer control registers: WUDR and RUDR
 - No register for enabling writing time
 - RTC interrupts are reported in main PMIC I2C device

Signed-off-by: Krzysztof Kozlowski 
Cc: Kyungmin Park 
Cc: Lee Jones 
Cc: Alessandro Zummo 
Cc: Sangbeom Kim 
Cc: Samuel Ortiz 
Cc: Marek Szyprowski 
Cc: Bartlomiej Zolnierkiewicz 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: s5m: support different register layout

2014-06-10T22:34:47+00:00

Prepare for adding support for S2MPS14 RTC device to the rtc-s5m driver:

1. Add a map of registers used by the driver which differ between
   the chipsets (S5M876X and S2MPS14).

2. Move code of checking for alarm pending to separate function.

Signed-off-by: Krzysztof Kozlowski 
Cc: Kyungmin Park 
Cc: Lee Jones 
Cc: Alessandro Zummo 
Cc: Sangbeom Kim 
Cc: Samuel Ortiz 
Cc: Marek Szyprowski 
Cc: Bartlomiej Zolnierkiewicz 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: s5m: use shorter time of register update

2014-06-10T22:34:47+00:00

Set the time needed for updating alarm and time registers to 0.45 ms.
The default is 7.32 ms which is too long and leads to warnings when
setting alarm or time:

	s5m-rtc: waiting for UDR update, reached max number of retries

Signed-off-by: Krzysztof Kozlowski 
Cc: Kyungmin Park 
Cc: Lee Jones 
Cc: Alessandro Zummo 
Cc: Sangbeom Kim 
Cc: Samuel Ortiz 
Cc: Marek Szyprowski 
Cc: Bartlomiej Zolnierkiewicz 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: s5m: remove undocumented time init on first boot

2014-06-10T22:34:47+00:00

Remove the code for initializing time if this is first boot.

The code for detecting first boot uses undocumented field RTC_TCON in
RTC_UDR_CON register.  According to S5M8767's datasheet this field is
reserved.  On S2MPS14 it is not documented at all.

On device first boot the registers will be initialized with reset value
(2000-01-01 00:00:00).

The code might work on S5M8763 but still this does not look like a task
for RTC driver.

Signed-off-by: Krzysztof Kozlowski 
Cc: Kyungmin Park 
Cc: Lee Jones 
Cc: Alessandro Zummo 
Cc: Sangbeom Kim 
Cc: Samuel Ortiz 
Cc: Marek Szyprowski 
Cc: Bartlomiej Zolnierkiewicz 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

mfd/rtc: sec/s5m: rename SEC* symbols to S5M

2014-06-10T22:34:46+00:00

Prepare for adding support for S2MPS14 RTC device to the rtc-s5m driver:

1. Rename SEC* symbols to S5M.
2. Add S5M prefix to some of defines which are different between S5M876X
   and S2MPS14.

This is only a rename-like patch, new code is not added.

Signed-off-by: Krzysztof Kozlowski 
Acked-by: Lee Jones 
Cc: Kyungmin Park 
Cc: Alessandro Zummo 
Cc: Sangbeom Kim 
Cc: Samuel Ortiz 
Cc: Marek Szyprowski 
Cc: Bartlomiej Zolnierkiewicz 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

mfd/rtc: s5m: Do not allocate RTC I2C dummy and regmap for unsupported chipsets

2014-06-03T07:11:16+00:00

The rtc-s5m driver does not support all of S2M and S5M chipsets
supported by main MFD sec-core driver. For such chipsets unsupported by
rtc-s5m, the MFD sec-core driver initialized regmap with default config.
This config in such cases wouldn't work at all.

The main MFD sec-core driver shouldn't initialize regmap for child
drivers which is not used by them and even not valid.

Move the allocation of RTC I2C dummy device and initialization of RTC
regmap from main MFD sec-core driver to the rtc-s5m driver. The rtc-s5m
driver will use proper regmap config for supported devices.

Signed-off-by: Krzysztof Kozlowski 
Acked-by: Alessandro Zummo 
Signed-off-by: Lee Jones

drivers/rtc/rtc-s5m.c: s5m_rtc_{suspend,resume}() should depend on CONFIG_PM_SLEEP

2014-01-24T00:37:00+00:00

If CONFIG_PM_SLEEP=n:

drivers/rtc/rtc-s5m.c:643: warning: `s5m_rtc_resume' defined but not used
drivers/rtc/rtc-s5m.c:654: warning: `s5m_rtc_suspend' defined but not used

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds