linux-stable.git/drivers/rtc/rtc-s3c.c, branch linux-3.18.y

drivers/rtc/rtc-s3c.c: add .needs_src_clk to s3c6410 RTC data

2015-03-28T13:59:44+00:00

[ Upstream commit 8792f7772f4f40ffc68bad5f28311205584b734d ]

Commit df9e26d093d3 ("rtc: s3c: add support for RTC of Exynos3250 SoC")
added an "rtc_src" DT property to specify the clock used as a source to
the S3C real-time clock.

Not all SoCs needs this so commit eaf3a659086e ("drivers/rtc/rtc-s3c.c:
fix initialization failure without rtc source clock") changed to check
the struct s3c_rtc_data .needs_src_clk to conditionally grab the clock.

But that commit didn't update the data for each IP version so the RTC
broke on the boards that needs a source clock. This is the case of at
least Exynos5250 and Exynos5440 which uses the s3c6410 RTC IP block.

This commit fixes the S3C rtc on the Exynos5250 Snow and Exynos5420
Peach Pit and Pi Chromebooks.

Signed-off-by: Javier Martinez Canillas 
Cc: Marek Szyprowski 
Cc: Chanwoo Choi 
Cc: Doug Anderson 
Cc: Olof Johansson 
Cc: Kevin Hilman 
Cc: Tyler Baker 
Cc: Alessandro Zummo 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Sasha Levin

drivers/rtc/rtc-s3c.c: fix initialization failure without rtc source clock

2014-10-29T23:33:14+00:00

Fix unconditional initialization failure on non-exynos3250 SoCs.

Commit df9e26d093d3 ("rtc: s3c: add support for RTC of Exynos3250 SoC")
introduced rtc source clock support, but also added initialization
failure on SoCs, which doesn't need such clock.

Signed-off-by: Marek Szyprowski 
Reviewed-by: Chanwoo Choi 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: s3c: add support for RTC of Exynos3250 SoC

2014-10-14T00:18:17+00:00

Add support for RTC of Exynos3250 SoC.  The Exynos3250 needs source
clock(32.768KHz) for RTC block.  If source clock of RTC is registerd on
clock list of common clk framework, Exynos RTC drvier have to control
this clock.

Clock list for s3c-rtc device:
- rtc : CLK_RTC of CLK_GATE_IP_PERIR is gate clock for RTC.
- rtc_src : XrtcXTI is 32.768.kHz source clock for RTC.
 (XRTCXTI: Specifies a clock from 32.768 kHz crystal pad with XRTCXTI and
 XRTCXTO pins. RTC uses this clock as the source of a real-time clock.)

Signed-off-by: Chanwoo Choi 
Acked-by: Kyungmin Park 
Cc: Alessandro Zummo 
Cc: Kukjin Kim 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: s3c: add s3c_rtc_data structure to use variant data instead of s3c_cpu_type

2014-10-14T00:18:17+00:00

Add s3c_rtc_data structure to variant data according to SoC type.  The
s3c_rtc_data structure includes some functions to control RTC operation
and specific data dependent on SoC type.

Signed-off-by: Chanwoo Choi 
Acked-by: Kyungmin Park 
Cc: Alessandro Zummo 
Cc: Kukjin Kim 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: s3c: remove warning message when checking coding style with checkpatch script

2014-10-14T00:18:17+00:00

Remove warning message when checking codeing style with checkpatch script
and reduce un-necessary i2c read operation on s3c_rtc_enable.

    WARNING: line over 80 characters
    #406: FILE: drivers/rtc/rtc-s3c.c:406:
    +		if ((readw(info->base + S3C2410_RTCCON) & S3C2410_RTCCON_RTCEN) == 0) {

    WARNING: line over 80 characters
    #414: FILE: drivers/rtc/rtc-s3c.c:414:
    +		if ((readw(info->base + S3C2410_RTCCON) & S3C2410_RTCCON_CNTSEL)) {

    WARNING: line over 80 characters
    #422: FILE: drivers/rtc/rtc-s3c.c:422:
    +		if ((readw(info->base + S3C2410_RTCCON) & S3C2410_RTCCON_CLKRST)) {

    WARNING: Missing a blank line after declarations
    #451: FILE: drivers/rtc/rtc-s3c.c:451:
    +	struct s3c_rtc_drv_data *data;
    +	if (pdev->dev.of_node) {

    WARNING: Missing a blank line after declarations
    #453: FILE: drivers/rtc/rtc-s3c.c:453:
    +		const struct of_device_id *match;
    +		match = of_match_node(s3c_rtc_dt_match, pdev->dev.of_node);

    WARNING: DT compatible string "samsung,s3c2416-rtc" appears un-documented -- check ./Documentation/devicetree/bindings/
    #650: FILE: drivers/rtc/rtc-s3c.c:650:
    +		.compatible = "samsung,s3c2416-rtc",

    WARNING: DT compatible string "samsung,s3c2443-rtc" appears un-documented -- check ./Documentation/devicetree/bindings/
    #653: FILE: drivers/rtc/rtc-s3c.c:653:
    +		.compatible = "samsung,s3c2443-rtc",

Signed-off-by: Chanwoo Choi 
Acked-by: Kyungmin Park 
Cc: Alessandro Zummo 
Cc: Kukjin Kim 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: s3c: define s3c_rtc structure to remove global variables.

2014-10-14T00:18:17+00:00

Define s3c_rtc structure including necessary variables for S3C RTC device
instead of global variables.  This patch improves the readability by
removing global variables.

Signed-off-by: Chanwoo Choi 
Acked-by: Kyungmin Park 
Cc: Alessandro Zummo 
Cc: Kukjin Kim 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-s3c.c: remove NO_IRQ macro

2014-04-03T23:21:24+00:00

NO_IRQ may be defined as '(unsigned int) -1' in some architectures (arm,
sh ...), and either may not be defined in some architectures (arm64) which
can enable RTC_DRV_S3C.

Also since platform_get_irq returns err-code in case of any error, we do
not need to intialize s3c_rtc_alarmno and s3c_rtc_tickno.

Signed-off-by: Pankaj Dubey 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-s3c.c: fix incorrect way of save/restore of S3C2410_TICNT for TYPE_S3C64XX

2014-03-04T15:55:48+00:00

On exynos5250, exynos5420 and exynos5260 it was observed that, after 1
cycle of S2R, the rtc-tick occurs at a very fast rate as compared to the
rtc-tick occuring before S2R.

This patch fixes the above issue by correcting the wrong way of
save/restore of S3C2410_TICNT for TYPE_S3C64XX.

Signed-off-by: Vikas Sajjan 
Cc: Grant Likely 
Cc: Rob Herring 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: rtc-s3c: remove unnecessary platform_set_drvdata()

2013-07-03T23:07:51+00:00

The driver core clears the driver data to NULL after device_release or
on probe failure, since commit 0998d063100 ("device-core: Ensure drvdata
= NULL when no driver is bound").  Thus, it is not needed to manually
clear the device driver data to NULL.

Signed-off-by: Jingoo Han 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc: don't check resource with devm_ioremap_resource

2013-05-18T09:57:07+00:00

devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.

Signed-off-by: Wolfram Sang 
Acked-by: Stephen Warren