linux-stable.git/drivers/rtc/rtc-pl031.c, branch linux-5.4.y

rtc: pl031: fix resource leak in pl031_probe

2021-01-06T13:48:39+00:00

[ Upstream commit 1eab0fea2514b269e384c117f5b5772b882761f0 ]

When devm_rtc_allocate_device is failed in pl031_probe, it should release
mem regions with device.

Reported-by: Hulk Robot 
Signed-off-by: Zheng Liang 
Signed-off-by: Alexandre Belloni 
Acked-by: Linus Walleij 
Link: https://lore.kernel.org/r/20201112093139.32566-1-zhengliang6@huawei.com
Signed-off-by: Sasha Levin

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152

2019-05-30T18:26:32+00:00

Based on 1 normalized pattern(s):

  this program is free software you can redistribute it and or modify
  it under the terms of the gnu general public license as published by
  the free software foundation either version 2 of the license or at
  your option any later version

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-or-later

has been chosen to replace the boilerplate/reference in 3029 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Allison Randal 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190527070032.746973796@linutronix.de
Signed-off-by: Greg Kroah-Hartman

rtc: pl031: switch to devm_rtc_allocate_device/rtc_register_device

2018-09-11T11:56:35+00:00

Switch to devm_rtc_allocate_device to simplify the erro and driver removal
paths.

Acked-by: Linus Walleij 
Signed-off-by: Alexandre Belloni

rtc: pl031: make interrupt optional

2017-10-12T14:30:30+00:00

On some platforms, the interrupt for the PL031 is optional.  Avoid
trying to claim the interrupt if it's not specified.

Reviewed-by: Linus Walleij 
Signed-off-by: Russell King 
Signed-off-by: Alexandre Belloni

rtc: pl031: avoid exposing alarm if no interrupt

2017-10-12T14:30:25+00:00

If the RTC has no interrupt, there is little point in exposing the RTC
alarm capabilities, as it can't be used as a wakeup source nor can it
deliver an event to userspace.

Signed-off-by: Russell King 
Reviewed-by: Linus Walleij 
Signed-off-by: Alexandre Belloni

rtc: pl031: use devm_* for allocating memory and mapping resource

2017-10-12T14:29:49+00:00

Use the devm_* APIs for allocating memory and mapping the memory in
the probe function to relieve the driver from having to deal with
this in the cleanup paths.

Signed-off-by: Russell King 
Reviewed-by: Linus Walleij 
Signed-off-by: Alexandre Belloni

rtc: pl031: constify amba_ids

2017-10-12T14:27:28+00:00

The AMBA device IDs should be marked const.  Make that so.

Reviewed-by: Linus Walleij 
Signed-off-by: Russell King 
Signed-off-by: Alexandre Belloni

rtc: pl031: remove misuse of IRQF_NO_SUSPEND flag

2015-11-08T13:12:24+00:00

The IRQF_NO_SUSPEND flag is used to identify the interrupts that should
be left enabled so as to allow them to work as expected during the
suspend-resume cycle, but doesn't guarantee that it will wake the system
from a suspended state, enable_irq_wake is recommended to be used for
the wakeup.

This patch removes the use of IRQF_NO_SUSPEND flags and uses newly
introduce PM wakeup APIs dev_pm_{set,clear}_wake_irq.

Cc: Linus Walleij 
Cc: Alessandro Zummo 
Cc: Alexandre Belloni 
Cc: rtc-linux@googlegroups.com
Signed-off-by: Sudeep Holla 
Acked-by: Linus Walleij 
Signed-off-by: Alexandre Belloni

rtc: pl031: fix typo for author email

2015-09-05T11:19:08+00:00

The email address missed character ">", so add it.

Signed-off-by: Leo Yan 
Signed-off-by: Alexandre Belloni

drivers/rtc/rtc-pl03x.c: remove unnecessary amba_set_drvdata()

2013-11-13T03:09:31+00:00

Driver core clears the driver data to NULL after device_release or on
probe failure, so just remove it from here.

The relevant driver core change was commit 0998d0631001 ("device-core:
Ensure drvdata = NULL when no driver is bound").

Signed-off-by: Michal Simek 
Cc: Linus Walleij 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds