linux-stable.git/drivers/rtc/rtc-pcf8563.c, branch v3.18

drivers/rtc/rtc-pcf8563.c: fix pcf8563_irq() error return value

2014-10-14T00:18:19+00:00

As pointed out by Sergei Shtylyov, the pcf8563_irq function contains a
bug in the error handling: an interrupt handler is not supposed to
return an errno value but an 'enum irqreturn'.

Let's fix this by returning IRQ_NONE in case of a communication error.

Signed-off-by: Arnd Bergmann 
Cc: Sergei Shtylyov 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-pcf8563.c: fix uninitialized use warning

2014-10-14T00:18:19+00:00

gcc-4.9 found a potential condition under which the 'pending' variable
may be used uninitialized:

  drivers/rtc/rtc-pcf8563.c: In function 'pcf8563_irq':
  drivers/rtc/rtc-pcf8563.c:173:5: warning: 'pending' may be used uninitialized in this function [-Wmaybe-uninitialized]

This is because in the pcf8563_get_alarm_mode() function, we check any
nonzero return of pcf8563_read_block_data, but in the irq function we
only check for negative values, so a possible positive value does not
get detected if the compiler chooses not to inline the entire call
chain.

Checking for any non-zero value in the interrupt handler as well is just
as correct and lets the compiler know what we are doing, without needing
a bogus initialization.

Signed-off-by: Arnd Bergmann 
Cc: Sergei Shtylyov 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-pcf8563.c: add alarm support

2014-08-08T22:57:20+00:00

This patch adds alarm support for the NXP PCF8563 chip.

Signed-off-by: Vincent Donnefort 
Cc: Simon Guinot 
Cc: Jason Cooper 
Cc: Andrew Lunn 
Cc: Alessandro Zummo 
Cc: Dan Carpenter 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-pcf8563.c: introduce read|write_block_data

2014-08-08T22:57:19+00:00

This functions allow to factorize I2C I/O operations.

Signed-off-by: Vincent Donnefort 
Cc: Simon Guinot 
Cc: Jason Cooper 
Cc: Andrew Lunn 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc: Replace PTR_RET with PTR_ERR_OR_ZERO

2013-07-16T06:36:00+00:00

PTR_RET is now deprecated. Use PTR_ERR_OR_ZERO instead.

Signed-off-by: Sachin Kamat 
Signed-off-by: Rusty Russell

drivers/rtc/rtc-pcf8563.c: use PTR_RET()

2013-07-03T23:07:59+00:00

Use of PTR_RET() simplifies the code.

Signed-off-by: Sachin Kamat 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-pcf8563.c: remove empty function

2013-07-03T23:07:57+00:00

After the switch to devm_* functions and the removal of
rtc_device_unregister(), the 'remove' function does not do anything.
Delete it.

Signed-off-by: Sachin Kamat 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: rtc-pcf8563: use devm_*() functions

2013-04-30T01:28:38+00:00

Use devm_*() functions to make cleanup paths simpler.

Signed-off-by: Jingoo Han 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc: remove unnecessary semicolons

2013-02-22T01:22:27+00:00

Found by Coccinelle: http://coccinelle.lip6.fr/

Signed-off-by: Peter Senna Tschudin 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Drivers: rtc: remove __dev* attributes.

2013-01-03T23:57:02+00:00

CONFIG_HOTPLUG is going away as an option.  As a result, the __dev*
markings need to be removed.

This change removes the use of __devinit, __devexit_p, __devinitdata,
__devinitconst, and __devexit from these drivers.

Based on patches originally written by Bill Pemberton, but redone by me
in order to handle some of the coding style issues better, by hand.

Cc: Bill Pemberton 
Cc: Alessandro Zummo 
Cc: Srinidhi Kasagar 
Cc: Linus Walleij 
Cc: Mike Frysinger 
Cc: Wan ZongShun 
Cc: Guan Xuetao 
Cc: Mark Brown 
Signed-off-by: Greg Kroah-Hartman