linux-stable.git/drivers/rtc/rtc-pcf8563.c, branch linux-4.9.y

rtc: pcf8563: Clear event flags and disable interrupts before requesting irq

2020-01-29T09:24:26+00:00

[ Upstream commit 3572e8aea3bf925dac1dbf86127657c39fe5c254 ]

Besides the alarm, the PCF8563 also has a timer triggered interrupt.
In cases where the previous system left the timer and interrupts on,
or somehow the bits got enabled, the interrupt would keep triggering
as the kernel doesn't know about it.

Clear both the alarm and timer event flags, and disable the interrupts,
before requesting the interrupt line.

Fixes: ede3e9d47cca ("drivers/rtc/rtc-pcf8563.c: add alarm support")
Fixes: a45d528aab8b ("rtc: pcf8563: clear expired alarm at boot time")
Signed-off-by: Chen-Yu Tsai 
Signed-off-by: Alexandre Belloni 
Signed-off-by: Sasha Levin

rtc: pcf8563: fix output clock rate

2017-12-20T09:07:27+00:00

[ Upstream commit a3350f9c57ffad569c40f7320b89da1f3061c5bb ]

The pcf8563_clkout_recalc_rate function erroneously ignores the
frequency index read from the CLKO register and always returns
32768 Hz.

Fixes: a39a6405d5f9 ("rtc: pcf8563: add CLKOUT to common clock framework")
Signed-off-by: Philipp Zabel 
Signed-off-by: Alexandre Belloni 
Signed-off-by: Sasha Levin 
Signed-off-by: Greg Kroah-Hartman

rtc: explicitly set tm_sec = 0 for drivers with minute accurancy

2016-07-19T16:15:21+00:00

Since all time members of the alarm data is initialized to -1 the drivers
are responsible to set the tm_sec member to 0.

Fixes: d68778b80dd7 ("rtc: initialize output parameter for read alarm to "uninitialized"")
Signed-off-by: Uwe Kleine-König 
Signed-off-by: Alexandre Belloni

rtc: simplify implementations of read_alarm

2016-07-09T08:24:45+00:00

Since commit d68778b80dd7 ("rtc: initialize output parameter for read
alarm to "uninitialized"") there is no need to explicitly set
unsupported members to -1. So drop the respective assignments from
drivers.

Signed-off-by: Uwe Kleine-König 
Signed-off-by: Alexandre Belloni

rtc: pcf8563: Remove CLK_IS_ROOT

2016-05-20T10:33:51+00:00

This flag is a no-op now (see commit 47b0eeb3dc8a "clk: Deprecate
CLK_IS_ROOT", 2016-02-02) so remove it.

Cc: Heiko Schocher 
Signed-off-by: Stephen Boyd 
Acked-by: Heiko Schocher 
Signed-off-by: Alexandre Belloni

rtc: remove useless DRV_VERSION

2016-05-20T10:33:51+00:00

Many drivers are defining a DRV_VERSION. This is often only used for
MODULE_VERSION and sometimes to print an info message at probe time. This
is kind of pointless as they are all versionned with the kernel anyway.
Also the core will print a message when a new rtc is found.

Signed-off-by: Alexandre Belloni

rtc: pcf8563: add CLKOUT to common clock framework

2015-11-08T13:12:29+00:00

Add the clkout output clk to the common clock framework.
Disable the CLKOUT of the RTC after power-up.
After power-up/reset of the RTC, CLKOUT is enabled by default,
with CLKOUT enabled the RTC chip has 2-3 times higher power
consumption.

Signed-off-by: Heiko Schocher 
Signed-off-by: Alexandre Belloni

rtc: Drop owner assignment from i2c_driver

2015-09-05T11:19:06+00:00

i2c_driver does not need to set an owner because i2c_register_driver()
will set it.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Alexandre Belloni

rtc: pfc8563: fix uninitialized variable warning

2015-06-24T23:13:46+00:00

Gcc is unable to prove that alm_pending is always initialized
when it is used, so it prints a harmless warning:

drivers/rtc/rtc-pcf8563.c: In function 'pcf8563_probe':
drivers/rtc/rtc-pcf8563.c:449:5: warning: 'alm_pending' may be used uninitialized in this function [-Wmaybe-uninitialized]

This uses the same conditional expression that is used inside of
the pcf8563_get_alarm_mode() function, to help gcc figure it out
and shut up that warning, and make the ARM defconfigs build again
with no warnings.

Signed-off-by: Arnd Bergmann 
Fixes: a45d528aab8b ("rtc: pcf8563: clear expired alarm at boot time")
Signed-off-by: Alexandre Belloni

rtc: pcf8563: Replace deprecated rtc_time_to_tm() and rtc_tm_to_time()

2015-06-24T23:13:41+00:00

pcf8563_rtc_set_alarm() uses deprecated rtc_tm_to_time()
and rtc_time_to_tm(), which will overflow in year 2106
on 32-bit machines.

This patch solves this by:
 - Replacing rtc_time_to_tm() with rtc_time64_to_tm()
 - Replacing rtc_tm_to_time() with rtc_tm_to_time64()

Acked-by: Arnd Bergmann 
Signed-off-by: Xunlei Pang 
Signed-off-by: Alexandre Belloni