linux-stable.git/drivers/rtc/rtc-pcf8563.c, branch linux-3.19.y

rtc: pcf8563: clear expired alarm at boot time

2014-12-11T01:41:15+00:00

In case the card is woken up of the rtc alarm, the
devm_rtc_device_register function detects it as a pending alarm about a
month in the future.  Fix this by clearing the alarm in module probe.

Signed-off-by: Jan Kardell 
Cc: Alessandro Zummo 
Cc: Grant Likely 
Cc: Rob Herring 
Cc: Vincent Donnefort 
Cc: Dan Carpenter 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: pcf8563: save battery power

2014-12-11T01:41:15+00:00

According to Haoyu hym8563 datasheet this saves som power.  Might be
importat to battery life.  And maybe it works for the NXP part as well.

Signed-off-by: Jan Kardell 
Cc: Alessandro Zummo 
Cc: Grant Likely 
Cc: Rob Herring 
Cc: Vincent Donnefort 
Cc: Dan Carpenter 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: pcf8563: handle consequeces of lacking second alarm reg

2014-12-11T01:41:15+00:00

To guarantee that a set alarm occurs in the future, the set alarm time
is rounded up to the nearest minute.  Also we cannot handle UIE as it
requires second precision.

Signed-off-by: Jan Kardell 
Cc: Alessandro Zummo 
Cc: Grant Likely 
Cc: Rob Herring 
Cc: Vincent Donnefort 
Cc: Dan Carpenter 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: pcf8563: fix wrong time from read_alarm

2014-12-11T01:41:15+00:00

Incorrect mask was used for hour and monthday fields.

Signed-off-by: Jan Kardell 
Cc: Alessandro Zummo 
Cc: Grant Likely 
Cc: Rob Herring 
Cc: Vincent Donnefort 
Cc: Dan Carpenter 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: pcf8563: fix write of invalid bits to ST2 reg

2014-12-11T01:41:15+00:00

The NXP datasheet says:
 "Bits labeled as N should always be written with logic 0."

At least one of those bits is sometime read as a 1, therfore violating
this rule.  To fix this we mask away those bits.

Signed-off-by: Jan Kardell 
Cc: Alessandro Zummo 
Cc: Grant Likely 
Cc: Rob Herring 
Cc: Vincent Donnefort 
Cc: Dan Carpenter 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: pcf8563: remove leftover code

2014-12-11T01:41:14+00:00

Remove some code that was left from before block read/write was used.

Signed-off-by: Jan Kardell 
Cc: Alessandro Zummo 
Cc: Grant Likely 
Cc: Rob Herring 
Cc: Vincent Donnefort 
Cc: Dan Carpenter 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-pcf8563.c: fix pcf8563_irq() error return value

2014-10-14T00:18:19+00:00

As pointed out by Sergei Shtylyov, the pcf8563_irq function contains a
bug in the error handling: an interrupt handler is not supposed to
return an errno value but an 'enum irqreturn'.

Let's fix this by returning IRQ_NONE in case of a communication error.

Signed-off-by: Arnd Bergmann 
Cc: Sergei Shtylyov 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-pcf8563.c: fix uninitialized use warning

2014-10-14T00:18:19+00:00

gcc-4.9 found a potential condition under which the 'pending' variable
may be used uninitialized:

  drivers/rtc/rtc-pcf8563.c: In function 'pcf8563_irq':
  drivers/rtc/rtc-pcf8563.c:173:5: warning: 'pending' may be used uninitialized in this function [-Wmaybe-uninitialized]

This is because in the pcf8563_get_alarm_mode() function, we check any
nonzero return of pcf8563_read_block_data, but in the irq function we
only check for negative values, so a possible positive value does not
get detected if the compiler chooses not to inline the entire call
chain.

Checking for any non-zero value in the interrupt handler as well is just
as correct and lets the compiler know what we are doing, without needing
a bogus initialization.

Signed-off-by: Arnd Bergmann 
Cc: Sergei Shtylyov 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-pcf8563.c: add alarm support

2014-08-08T22:57:20+00:00

This patch adds alarm support for the NXP PCF8563 chip.

Signed-off-by: Vincent Donnefort 
Cc: Simon Guinot 
Cc: Jason Cooper 
Cc: Andrew Lunn 
Cc: Alessandro Zummo 
Cc: Dan Carpenter 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-pcf8563.c: introduce read|write_block_data

2014-08-08T22:57:19+00:00

This functions allow to factorize I2C I/O operations.

Signed-off-by: Vincent Donnefort 
Cc: Simon Guinot 
Cc: Jason Cooper 
Cc: Andrew Lunn 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds