linux-stable.git/drivers/rtc/rtc-mxc.c, branch v5.3

rtc: mxc: use .set_time

2019-04-29T13:53:43+00:00

Use .set_time instead of the deprecated .set_mmss64.

Signed-off-by: Alexandre Belloni

rtc: mxc: set range

2019-04-29T13:53:42+00:00

Let the core handle the range, and in particular the imx1 offsetting. This
has the benefit of extending the range of the RTC further than 365 days and
making .read_time useful again on imx1.

Signed-off-by: Alexandre Belloni

rtc: mxc: fix possible race condition

2019-04-29T13:53:42+00:00

The IRQ is requested before the struct rtc is allocated and registered, but
this struct is used in the IRQ handler. This may lead to a NULL pointer
dereference.

Switch to devm_rtc_allocate_device/rtc_register_device to allocate the rtc
struct before requesting the IRQ.

Signed-off-by: Alexandre Belloni

rtc: mxc: use dev_pm_set_wake_irq() to simplify code

2019-04-11T21:18:32+00:00

With calling dev_pm_set_wake_irq() to set MXC RTC as wakeup source
for suspend, generic wake irq mechanism will automatically enable
it as wakeup source when suspend, then the suspend/resume callback
which are ONLY for enabling/disabling irq wake can be removed, it
simplifies the code.

Signed-off-by: Anson Huang 
Signed-off-by: Alexandre Belloni

rtc: mxc: use devm_platform_ioremap_resource() to simplify code

2019-04-04T08:07:11+00:00

Use the new helper devm_platform_ioremap_resource() which wraps the
platform_get_resource() and devm_ioremap_resource() together, to
simplify the code.

Signed-off-by: Anson Huang 
Signed-off-by: Alexandre Belloni

rtc: mxc: Switch to SPDX identifier

2018-05-22T07:47:17+00:00

Adopt the SPDX license identifier headers to ease license compliance
management.

Signed-off-by: Fabio Estevam 
Signed-off-by: Alexandre Belloni

rtc: simplify getting .drvdata

2018-05-03T20:08:00+00:00

We should get drvdata from struct device directly. Going via
platform_device is an unneeded step back and forth.

Signed-off-by: Wolfram Sang 
Acked-by: Michal Simek  (for zynqmp)
Signed-off-by: Alexandre Belloni

rtc: mxc: avoid disabling interrupts on device close

2017-08-24T14:23:16+00:00

Currently, the IRQs are disabled when the rtc character device is closed.
This means that the device needs to stay open to get alarms while the usual
use case will open the device, set the alarm and close the device as is
done in rtcwake.

Keep the alarm functional on character device release so the platform can
actually wakeup.

Reviewed-by: Fabio Estevam 
Signed-off-by: Alexandre Belloni

rtc: mxc: remove unused variable

2017-06-24T05:58:09+00:00

This variable was never used. With GCC 6.2, we get the following warning:

drivers/rtc/rtc-mxc.c:44:18: warning: ‘PIE_BIT_DEF’ defined but not used [-Wunused-const-variable=]
 static const u32 PIE_BIT_DEF[MAX_PIE_NUM][2] = {

Signed-off-by: Diaz de Grenu, Jose 
Signed-off-by: Alexandre Belloni

rtc: constify rtc_class_ops structures

2017-01-11T16:23:06+00:00

Declare rtc_class_ops structures as const as they are only passed
as an argument to the function devm_rtc_device_register. This argument
is of type const struct rtc_class_ops *, so rtc_class_ops structures
having this property can be declared const.
Done using Coccinelle:

@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct rtc_class_ops i@p = {...};

@ok1@
identifier r1.i;
position p;
@@
devm_rtc_device_register(...,&i@p,...)

@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct rtc_class_ops i;

Signed-off-by: Bhumika Goyal 
Signed-off-by: Alexandre Belloni