linux-stable.git/drivers/rtc/rtc-mxc.c, branch linux-5.11.y

rtc: rework rtc_register_device() resource management

2020-11-19T11:50:12+00:00

rtc_register_device() is a managed interface but it doesn't use devres
by itself - instead it marks an rtc_device as "registered" and the devres
callback for devm_rtc_allocate_device() takes care of resource release.

This doesn't correspond with the design behind devres where managed
structures should not be aware of being managed. The correct solution
here is to register a separate devres callback for unregistering the
device.

While at it: rename rtc_register_device() to devm_rtc_register_device()
and add it to the list of managed interfaces in devres.rst. This way we
can avoid any potential confusion of driver developers who may expect
there to exist a corresponding unregister function.

Signed-off-by: Bartosz Golaszewski 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20201109163409.24301-8-brgl@bgdev.pl

rtc: mxc: use of_device_get_match_data

2020-11-17T20:55:02+00:00

Use of_device_get_match_data to simplify mxc_rtc_probe.

Signed-off-by: Alexandre Belloni 
Reviewed-by: Fabio Estevam 
Link: https://lore.kernel.org/r/20201117203035.1280099-1-alexandre.belloni@bootlin.com

rtc: mxc: Convert the driver to DT-only

2020-11-17T19:33:29+00:00

Since 5.10-rc1 i.MX is a devicetree-only platform, so simplify the code
by removing the unused non-DT support.

Signed-off-by: Fabio Estevam 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20201116180326.5199-1-festevam@gmail.com

rtc: mxc: Use devm_add_action_or_reset() for calls to clk_disable_unprepare()

2020-03-22T21:10:41+00:00

Use devm_add_action_or_reset() for calls to clk_disable_unprepare(),
which can simplify the error handling, and .remove callback can be dropped.

Signed-off-by: Anson Huang 
Link: https://lore.kernel.org/r/1584349785-27042-1-git-send-email-Anson.Huang@nxp.com
Signed-off-by: Alexandre Belloni

rtc: mxc: use spin_lock_irqsave instead of spin_lock_irq in IRQ context

2019-08-12T21:04:25+00:00

As spin_unlock_irq will enable interrupts.
mxc_rtc_irq_enable is called from interrupt handler mxc_rtc_interrupt.
Interrupts are enabled in interrupt handler.
Use spin_lock_irqsave/spin_unlock_irqrestore instead of spin_(un)lock_irq
in IRQ context to avoid this.

Signed-off-by: Fuqian Huang 
Link: https://lore.kernel.org/r/20190807082310.10135-1-huangfq.daxian@gmail.com
Signed-off-by: Alexandre Belloni

rtc: mxc: use .set_time

2019-04-29T13:53:43+00:00

Use .set_time instead of the deprecated .set_mmss64.

Signed-off-by: Alexandre Belloni

rtc: mxc: set range

2019-04-29T13:53:42+00:00

Let the core handle the range, and in particular the imx1 offsetting. This
has the benefit of extending the range of the RTC further than 365 days and
making .read_time useful again on imx1.

Signed-off-by: Alexandre Belloni

rtc: mxc: fix possible race condition

2019-04-29T13:53:42+00:00

The IRQ is requested before the struct rtc is allocated and registered, but
this struct is used in the IRQ handler. This may lead to a NULL pointer
dereference.

Switch to devm_rtc_allocate_device/rtc_register_device to allocate the rtc
struct before requesting the IRQ.

Signed-off-by: Alexandre Belloni

rtc: mxc: use dev_pm_set_wake_irq() to simplify code

2019-04-11T21:18:32+00:00

With calling dev_pm_set_wake_irq() to set MXC RTC as wakeup source
for suspend, generic wake irq mechanism will automatically enable
it as wakeup source when suspend, then the suspend/resume callback
which are ONLY for enabling/disabling irq wake can be removed, it
simplifies the code.

Signed-off-by: Anson Huang 
Signed-off-by: Alexandre Belloni

rtc: mxc: use devm_platform_ioremap_resource() to simplify code

2019-04-04T08:07:11+00:00

Use the new helper devm_platform_ioremap_resource() which wraps the
platform_get_resource() and devm_ioremap_resource() together, to
simplify the code.

Signed-off-by: Anson Huang 
Signed-off-by: Alexandre Belloni