linux-stable.git/drivers/rtc/rtc-isl1208.c, branch linux-4.19.y

rtc: isl1208: avoid possible sysfs race

2019-11-20T17:47:52+00:00

[ Upstream commit 1b4c794fda583edabe864ac466e9cd43c707be80 ]

Use rtc_add_group to add the common sysfs group to avoid a possible race
condition.

[Denis.Osterland@diehl.com: use to_i2c_client(dev->parent)]
Signed-off-by: Denis Osterland 
Signed-off-by: Alexandre Belloni 

The move of atrim, dtrim usr sysfs properties from i2c device
to rtc device require to access them via dev->parent.
This patch also aligns timestamp0.

Signed-off-by: Sasha Levin

rtc: isl1208: set ev-evienb bit from device tree

2018-08-14T21:22:27+00:00

Add support to disable event in pull-up.

Signed-off-by: Denis Osterland 
Signed-off-by: Alexandre Belloni

rtc: isl1208: Add "evdet" interrupt source for isl1219

2018-08-14T21:03:19+00:00

Add support for "evdet" named interrupt source.

The check if i2c client irq matches evdet irq is needed
for the case that there is only one interrupt named "evdet".
In this case i2c client code handles this like an unnamed
interrupt souce and assigns the value.

Signed-off-by: Denis Osterland 
Reviewed-by: Michael Grzeschik 
Signed-off-by: Alexandre Belloni

rtc: isl1208: add support for isl1219 with tamper detection

2018-08-14T21:00:58+00:00

We add support for the ISL1219 chip that got an integrated tamper
detection function. This patch implements the feature by adding
an additional timestamp0 file to sysfs device path.
This file contains seconds since epoch, if an event occurred,
or is empty, if none occurred.

Signed-off-by: Michael Grzeschik 
Signed-off-by: Denis Osterland 
Signed-off-by: Alexandre Belloni

rtc: isl1208: switch to rtc_register_device

2018-03-17T13:20:54+00:00

Fix possible race condition.
It is not allowed to return with an error code after RTC is registered.

Suggested-by: Alexandre Belloni 
Signed-off-by: Denis Osterland 
Reviewed-by: Michael Grzeschik 
Signed-off-by: Alexandre Belloni

rtc: isl1208: enable interrupt after context preparation

2018-03-17T13:20:53+00:00

The interrupt handler got enabled very early. If the interrupt cause is
triggering immediately before the context is fully prepared. This can
lead to undefined behaviour. Therefor we move the interrupt enable code
to the end of the probe function.

Signed-off-by: Michael Grzeschik 
Signed-off-by: Denis Osterland 
Signed-off-by: Alexandre Belloni

rtc: isl1208: Fix unintended clear of SR bits

2018-03-01T09:49:36+00:00

After successful
sr = isl1208_i2c_set_regs(client, 0, regs, ISL1208_RTC_SECTION_LEN);
sr will be 0.
As a result
sr = i2c_smbus_write_byte_data(client, ISL1208_REG_SR,
			sr & ~ISL1208_REG_SR_WRTC);
is equal to
sr = i2c_smbus_write_byte_data(client, ISL1208_REG_SR, 0);
which clears all flags in SR.

Add an additional read of SR, to have value of SR in sr again.

Signed-off-by: Denis Osterland 
Signed-off-by: Michael Grzeschik 
Signed-off-by: Alexandre Belloni

rtc: isl1208: Add OF device ID table

2017-03-09T00:29:27+00:00

The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:.

But this could change in the future so the correct approach is to have an
OF device ID table if the devices are registered via OF.

Signed-off-by: Javier Martinez Canillas 
Signed-off-by: Alexandre Belloni

rtc: remove useless DRV_VERSION

2016-05-20T10:33:51+00:00

Many drivers are defining a DRV_VERSION. This is often only used for
MODULE_VERSION and sometimes to print an info message at probe time. This
is kind of pointless as they are all versionned with the kernel anyway.
Also the core will print a message when a new rtc is found.

Signed-off-by: Alexandre Belloni

rtc: isl1208: Pass the IRQF_ONESHOT flag

2015-11-08T13:12:30+00:00

Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
bogus threaded irq requests") threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request will fail.

So pass the IRQF_ONESHOT flag in this case.

The semantic patch that makes this change is available
in scripts/coccinelle/misc/irqf_oneshot.cocci

Signed-off-by: Fabio Estevam 
Signed-off-by: Alexandre Belloni