linux-stable.git/drivers/rtc/rtc-ds1685.c, branch linux-4.19.y

rtc: ds1685: use EXPORT_SYMBOL_GPL for ds1685_rtc_poweroff

2023-09-23T08:47:56+00:00

commit 95e7ebc6823170256a8ce19fad87912805bfa001 upstream.

ds1685_rtc_poweroff is only used externally via symbol_get, which was
only ever intended for very internal symbols like this one.  Use
EXPORT_SYMBOL_GPL for it so that symbol_get can enforce only being used
on EXPORT_SYMBOL_GPL symbols.

Signed-off-by: Christoph Hellwig 
Acked-by: Joshua Kinard 
Reviewed-by: Greg Kroah-Hartman 
Signed-off-by: Luis Chamberlain 
Signed-off-by: Greg Kroah-Hartman

rtc: ds1685: remove sysfs access to control registers

2018-06-20T10:38:14+00:00

Access to the control registers is mostly not needed and can cause runtime
issues (like missed interrupts). Remove this debugging interface.

Signed-off-by: Alexandre Belloni

rtc: ds1685: remove improper datetime access ABI

2018-06-20T10:36:04+00:00

The driver exposes an undocumented ABI to access the date and time
registers. It is not actually used by any userspace tools. Remove it.

Signed-off-by: Alexandre Belloni

rtc: ds1685: Add range

2018-05-31T21:02:11+00:00

Useful range is 2000-2099 because leap year fails on centuries.

Signed-off-by: Alexandre Belloni

rtc: ds1685: fix possible race condition

2018-05-31T21:02:11+00:00

The IRQ is requested before the struct rtc is allocated and registered, but
this struct is used in the IRQ handler.

Switch to devm_rtc_allocate_device/rtc_register_device to allocate the rtc
before requesting the IRQ.

Signed-off-by: Alexandre Belloni

rtc: simplify getting .drvdata

2018-05-03T20:08:00+00:00

We should get drvdata from struct device directly. Going via
platform_device is an unneeded step back and forth.

Signed-off-by: Wolfram Sang 
Acked-by: Michal Simek  (for zynqmp)
Signed-off-by: Alexandre Belloni

rtc: stop validating rtc_time in .read_time

2018-03-02T09:09:58+00:00

The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.

Signed-off-by: Alexandre Belloni

rtc: simplify implementations of read_alarm

2016-07-09T08:24:45+00:00

Since commit d68778b80dd7 ("rtc: initialize output parameter for read
alarm to "uninitialized"") there is no need to explicitly set
unsupported members to -1. So drop the respective assignments from
drivers.

Signed-off-by: Uwe Kleine-König 
Signed-off-by: Alexandre Belloni

rtc: ds1685: correct day of month checking

2016-06-04T13:46:08+00:00

The day of month is checked in ds1685_rtc_read_alarm
and ds1685_rtc_set_alarm.

Multiple errors exist in the day of month check.

Operator ! has a higher priority than &&.
(!(mday >= 1) && (mday <= 31)) is false for mday == 32.

When verifying the day of month the binary and the BCD mode
have to be considered.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexandre Belloni

rtc: ds1685: actually spin forever in poweroff path

2016-05-20T10:33:51+00:00

objtool reports the following warning:

  drivers/rtc/rtc-ds1685.o: warning: objtool: ds1685_rtc_poweroff() falls through to next function ds1685_rtc_work_queue()

Similar to commit 361c6ed6b153 ("rtc: ds1685: actually spin forever in
poweroff error path"), there's another unreachable() annotation which is
actually reachable, which we missed the first time.

Actually spin forever to be consistent with the comment and to make the
unreachable() annotation guaranteed to be unreachable.

Reported-by: kbuild test robot 
Signed-off-by: Josh Poimboeuf 
Signed-off-by: Alexandre Belloni